The following issue has been SUBMITTED. ====================================================================== http://www.dbmail.org/mantis/view.php?id=967 ====================================================================== Reported By: elfring Assigned To: ====================================================================== Project: DBMail Issue ID: 967 Category: General Reproducibility: have not tried Severity: major Priority: normal Status: new target: ====================================================================== Date Submitted: 08-Apr-12 19:36 CEST Last Modified: 08-Apr-12 19:36 CEST ====================================================================== Summary: reserved identifier violation Description: I would like to point out that identifiers like "_DBMAIL_H" and "_SERVER_H" do not fit to the expected naming convention of the C language standard. https://github.com/pjstevns/dbmail/blob/48fcebdfc7a6510298679c79bbd9a40880d047d9/src/dbmail.h.in#L26 https://github.com/pjstevns/dbmail/blob/c72a140cc5ab678973a2b991604d7fe322b6bcc7/src/server.h#L27 https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29
Identifiers like "dm_driver_t" and "fetch_items_t" tamper with the POSIX name space. https://github.com/pjstevns/dbmail/blob/daa56bf99666c3b780db4d524d92040910f146c9/src/dbmailtypes.h#L64 http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_02_02 Would you like to adjust your selection for unique names? ====================================================================== Issue History Date Modified Username Field Change ====================================================================== 08-Apr-12 19:36 elfring New Issue ====================================================================== _______________________________________________ Dbmail-dev mailing list Dbmail-dev@dbmail.org http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev
