The following issue has been RESOLVED. 
====================================================================== 
http://www.dbmail.org/mantis/view.php?id=988 
====================================================================== 
Reported By:                fabiangergely
Assigned To:                paul
====================================================================== 
Project:                    DBMail
Issue ID:                   988
Category:                   IMAP daemon
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     resolved
target:                      
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             27-Sep-12 14:34 CEST
Last Modified:              25-Jul-13 16:03 CEST
====================================================================== 
Summary:                    APPENDUID feature
Description: 
The APPENDUID IMAP-extension is described in
http://tools.ietf.org/html/rfc4315 as part of the UIDPLUS extensions.

I'd request adding this feature to Dbmail. I'll attach a patch that does
just this.
====================================================================== 

---------------------------------------------------------------------- 
 (0003495) fabiangergely (reporter) - 27-Sep-12 16:20
 http://www.dbmail.org/mantis/view.php?id=988#c3495 
---------------------------------------------------------------------- 
This issue is closely related to 0000989. That issue depends on the changes
committed in the patch submitted for this issue. 

---------------------------------------------------------------------- 
 (0003496) paul (administrator) - 27-Sep-12 17:21
 http://www.dbmail.org/mantis/view.php?id=988#c3496 
---------------------------------------------------------------------- 
your patch doesn't apply cleanly to master or dbmail_3_0.

Try to rebase it against master and resubmit.

Some questions:

- why ruby? there's a complete python based framework in place.
- try to avoid allocation. In the append response stack buffer seems more
appropriate.
- a single UIDPLUS patch, or a git repo I can pull from (fork on github?)
would be preferable. With a github fork I can also check your history, so I
can rebase if necessary: I'm moving fast atm doing a lot of profiling. 

---------------------------------------------------------------------- 
 (0003497) fabiangergely (reporter) - 28-Sep-12 10:41
 http://www.dbmail.org/mantis/view.php?id=988#c3497 
---------------------------------------------------------------------- 
I'll rebase the patch (and the rest of our fork) to match on top of master,
by next Tuesday/Wednesday.
Ruby was chosen from two reasons. We weren't thinking of contributing
these patches when they were made, and I'm simply more comfortable with it.
However I'll also try to rewrite the tests in the Python framework.
We've created a github repo for our company's dbmail fork. It's publicly
available here: https://github.com/moveone/dbmail. 

---------------------------------------------------------------------- 
 (0003500) fabiangergely (reporter) - 03-Oct-12 14:41
 http://www.dbmail.org/mantis/view.php?id=988#c3500 
---------------------------------------------------------------------- 
Our fork's (https://github.com/moveone/dbmail) m1 branch contains a rebased
version (with 9bed91b1, aka. origin/master~17; we could do just this due to
an error in master). All 4 patches that we sent lately are there rebased.
The APPENDUID patch now contains Python tests too (the rest is in
progress). 

---------------------------------------------------------------------- 
 (0003550) paul (administrator) - 25-Jul-13 16:03
 http://www.dbmail.org/mantis/view.php?id=988#c3550 
---------------------------------------------------------------------- 
patch merged using the moveone github branch 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
27-Sep-12 14:34  fabiangergely  New Issue                                    
27-Sep-12 14:52  fabiangergely  File Added: 0001-APPENDUID-feature.patch        
           
27-Sep-12 16:20  fabiangergely  Note Added: 0003495                          
27-Sep-12 17:21  paul           Note Added: 0003496                          
28-Sep-12 10:41  fabiangergely  Note Added: 0003497                          
03-Oct-12 14:41  fabiangergely  Note Added: 0003500                          
25-Jul-13 16:03  paul           Note Added: 0003550                          
25-Jul-13 16:03  paul           Assigned To               => paul            
25-Jul-13 16:03  paul           Status                   new => resolved     
25-Jul-13 16:03  paul           Resolution               open => fixed       
======================================================================

_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev

Reply via email to