On Wed, 23 Mar 2005 09:05:00 +0100, Paul J Stevens <[EMAIL PROTECTED]> wrote: > Ok. I checked the source. > > Looks like do_null_messages correctly finds all the NULL messages, and does > set > MESSAGE_STATUS_ERROR on all these messages. But there's no code to actually > flush all those messages from the database. I suspect that somewhere in the > past, this was handled subtly different. > > Aaron, Ilja: any reason why do_null_messages calls db_set_message_status to > set > MESSAGE_STATUS_ERROR instead of MESSAGE_STATUS_PURGE?
I guess it does this for purely historical reasons. I checked some old code from the 1.2 branch, and it does exactly the same there. It would certainly be better to set the status to MESSAGE_STATUS_PURGE. Ilja
