Rafa,
>From the e-mail it sounds great. Have you regenerated everything using the
new code?
Please send the pull request. It will allow us to comment directly on the
pull request, see the code and even test it before pulling in.
Cheers
Pablo
On Dec 15, 2012 12:54 AM, "Rafa Haro" <[email protected]> wrote:
> Hi,
>
> Sorry for the delayed response, I have been quite busy these days. So, I
> wanted to enumerate my changes before finally send the pull request if you
> agree with them:
>
> # download.sh
>
> - Create a folder for storing English OpenNLP models when the language is
> not English but some English models need to be used
>
> - When an OpenNLP model in a concrete language is missing, correspondent
> English model is downloaded and stored in the previous folder, so the model
> file is not renamed anymore.
>
> - Default spotter.dict file renamed to spotter.en.dict
>
> - Changed output folder from $dbpedia_workspace/dbpedia_**data/data/output
> to $dbpedia_workspace/dbpedia_**data/data/output/index_en
>
> Due to these changes, it is necessary to also include a language parameter
> in index.sh script to relocate outputs to the proper folder (output files
> shouldn't be in .../data/output folder anymore, instead, they should be
> generated in its correspondent language folder, for instance,
> .../data/output/spanish)
>
> Finally, default paths in files conf/indexing.properties and
> conf/server.properties have changed to reflect the above changes.
>
> Regards
>
> El 11/12/12 08:35, Max Jakob escribió:
>
>> Hi Rafa,
>>
>> the idea with opening an issue first is that effort is not duplicated,
>> i.e. people know that you are working on a specific thing. If you are
>> already done, just send a pull request. Discussing a concrete solution
>> is also perfectly fine.
>>
>> Cheers,
>> Max
>>
>> On Tue, Dec 11, 2012 at 12:23 AM, Rafa Haro <[email protected]> wrote:
>>
>>> I think I have all the changes ready but before sending a pull request I
>>> was
>>> wondering if I should open first an issue in the project to discuss about
>>> them.
>>>
>>
> This message should be regarded as confidential. If you have received this
> email in error please notify the sender and destroy it immediately.
> Statements of intent shall only become binding when confirmed in hard copy
> by an authorised signatory.
>
> Zaizi Ltd is registered in England and Wales with the registration number
> 6440931. The Registered Office is 222 Westbourne Studios, 242 Acklam Road,
> London W10 5JJ, UK.
>
>
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Dbp-spotlight-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dbp-spotlight-users
