Hi JC ,

please Review those changes [1] in order i can send a pull request :
this is the code mainly for Refactoring the Core to accept new formats issue
#38 <https://github.com/dbpedia/extraction-framework/issues/38> as well as
adding Wikidata Extraction process

other changes that not included in the proposed
design<https://github.com/dbpedia/extraction-framework/pull/35#issuecomment-16127792>is
:

1- changed old WikiPageExtractor into ArticlePageExtractor in order that we
can create WikiPageExtractor trait for all Extractors[Wikipage] , for type
safety as we agreed before

2- Dimitris asked me to change the Parsers so that they now Returns
Option[xxx], in which it internally checks for page format sent
(Application/Json ... etc) and try to parse it, it returns None if it's not
of a suitable format , Hence we wouldn't need the WikiPageFormat.scala enum

Considering this, we needed to change the project to handle `Option[xx]` as
a return from parsers (already done in core and dump modules not yet in
Server and Live ) , so if we agree on this we can make the rest of the
changes. otherwise we will return back to throwing exceptions for wrong
format .

[1]
https://github.com/hadyelsahar/extraction-framework/compare/dbpedia:master...wikidata
<https://github.com/hadyelsahar/extraction-framework/compare/dbpedia:master...wikidata>


Thanks
Regards
-------------------------------------------------
Hady El-Sahar
Research Assistant
Center of Informatics Sciences | Nile University<http://nileuniversity.edu.eg/>
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Dbpedia-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dbpedia-developers

Reply via email to