This solution is also flawed. Check with Batman_Kane.jpg I recommend using org.apache.commons.codec.digest.DigestUtils#md5Hex Relying on a commonly used library is a lot less bug prone.
On Mon, Dec 5, 2011 at 4:17 PM, Tommy Chheng <tommy.chh...@gmail.com> wrote: > Thanks to the folks on the wikipedia api mailing list, the problem was > that the leading zero was being eaten. > > This will fix it in ImageExtractor#getImageUrl: > > val result = (new BigInteger(1, messageDigest)).toString(16) > val md5 = if (result.length % 2 != 0) "0" + result else result > > I would submit a patch but i'm unsure how to do so. > > > On Sat, Dec 3, 2011 at 6:38 PM, Tommy Chheng <tommy.chh...@gmail.com> wrote: >> I'm using ImageExtractor#getImageUrl in the extraction_framework to >> get the url of an image. >> >> val md = MessageDigest.getInstance("MD5") >> val messageDigest = md.digest(fileName.getBytes) >> val md5 = (new BigInteger(1, messageDigest)).toString(16) >> >> val hash1 = md5.substring(0, 1) >> val hash2 = md5.substring(0, 2); >> >> val urlPart = hash1 + "/" + hash2 + "/" + fileName >> >> Most of the time, the function works correctly but on a few cases, it >> is incorrect: >> >> For "Stewie_Griffin.png", I get 2/26/Stewie_Griffin.png but the real >> one is 0/02/Stewie_Griffin.png >> >> The source file info is here: >> http://en.wikipedia.org/wiki/File:Stewie_Griffin.png >> http://upload.wikimedia.org/wikipedia/en/0/02/Stewie_Griffin.png >> >> Any ideas why the hashing scheme doesn't work sometimes? >> >> -- >> @tommychheng >> http://tommy.chheng.com > > > > -- > @tommychheng > http://tommy.chheng.com -- @tommychheng http://tommy.chheng.com ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ Dbpedia-discussion mailing list Dbpedia-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion