Hi Ahmed, On 25 March 2013 17:44, Ahmed Ktob <kto...@gmail.com> wrote: > Alright, I committed the changes, I hope someone will review them.
It looks like this didn't quite work. I don't see a pull request here: https://github.com/dbpedia/extraction-framework/pulls Did you send a pull request? (Step 7 in https://github.com/dbpedia/extraction-framework/wiki/Contributing ) JC > > On 25 March 2013 17:32, Ahmed Ktob <kto...@gmail.com> wrote: >> >> Hello Jona, >> >> Thank you so much, I am going to follow the instructions on that link, in >> case I face some problems, I will be back. >> >> On 25 March 2013 17:30, Jona Christopher Sahnwaldt <j...@sahnwaldt.de> >> wrote: >>> >>> On 25 March 2013 17:21, Ahmed Ktob <kto...@gmail.com> wrote: >>> > Hello guys, >>> > >>> > I have made some changes to the following files (I added the Arabic >>> > configuration) : >>> > In the path "main/scala/org.dbpedia.extraction/config/dataparser >>> > >>> > DateTimeParserConfig.scala >>> > DurationParserConfig.scala >>> > FlagTemplateParserConfig.scala >>> > ParserUtilsConfig.scala >>> > >>> > In the path "main/scala/org.dbpedia.extraction/config/mappings >>> > >>> > DateIntervalMappingConfig.scala >>> > DisambiguationExtractorConfig.scala >>> > HomepageExtractorConfig.scala >>> > ImageExtractorConfig.scala >>> > InfoboxExtractorConfig.scala >>> > TopicalConceptsExtractorConfig.scala >>> > >>> >>> That's great! >>> >>> > My question is should I commit these changes now or there are some >>> > steps >>> > that I should follow ? >>> >>> I am not a git or github expert, but I think these instructions will help >>> you: >>> >>> https://github.com/dbpedia/extraction-framework/wiki/Contributing >>> >>> If you have any questions, feel free to ask us! >>> >>> Welcome to DBpedia! >>> >>> Cheers, >>> JC >>> >>> > Thank you so much. >>> > >>> > Best regards; >>> > Ahmed. >>> > -- >>> > ------------------------------------------------ >>> > Ahmed Ktob >>> > Dr. Taher Moulay University >>> > Department of Computer Science >>> > Saida , Algeria >>> > Tel : +213 554 811 151 >>> > ------------------------------------------------ >>> > >>> > >>> > ------------------------------------------------------------------------------ >>> > Everyone hates slow websites. So do we. >>> > Make your web apps faster with AppDynamics >>> > Download AppDynamics Lite for free today: >>> > http://p.sf.net/sfu/appdyn_d2d_mar >>> > _______________________________________________ >>> > Dbpedia-discussion mailing list >>> > Dbpedia-discussion@lists.sourceforge.net >>> > https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion >>> > >> >> >> >> >> -- >> ------------------------------------------------ >> Ahmed Ktob >> Dr. Taher Moulay University >> Department of Computer Science >> Saida , Algeria >> Tel : +213 554 811 151 >> ------------------------------------------------ > > > > > -- > ------------------------------------------------ > Ahmed Ktob > Dr. Taher Moulay University > Department of Computer Science > Saida , Algeria > Tel : +213 554 811 151 > ------------------------------------------------ ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Dbpedia-discussion mailing list Dbpedia-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion
