True, the condition at the bottom should probably read

AssertThrow 
> <file:///Users/jp/Programs/GitHub/deal.II/install/doc/doxygen/deal.II/group__Exceptions.html#ga2791cb68c815f9e072e709b731c060c7>
>  
> (newton_iteration < parameters.max_iterations_NR,
> ExcMessage 
> <file:///Users/jp/Programs/GitHub/deal.II/install/doc/doxygen/deal.II/group__Exceptions.html#gae9a45f517af1401c50811a11083f9114>
> ("No convergence in nonlinear solver!"));


Thanks, I'll make a note to fix this.

On Thursday, November 17, 2016 at 1:22:54 AM UTC+1, Anup Basak wrote:
>
> Dear developers,
>
> I see a small issue in function 'solve_nonlinear_timestep(
> BlockVector<double> 
> <https://www.dealii.org/8.4.0/doxygen/deal.II/classBlockVector.html> 
> &solution_delta)' of step44.
> If the 'for' loop corresponding to the Newton iteration is considered in 
> its present form, the exception in the end of
> this function will never be thrown, because 'newton_iteration' will never 
> exceed 'parameters.max_iterations_NR'.
> Hence I think in the 'for' statement '<=' should be considered instead of 
> '<', i.e,
>
> for ( ; newton_iteration <= parameters.max_iterations_NR; 
> ++newton_iteration)
>
> Thank you,
>
> Regards,
> Anup.
>
>

-- 
The deal.II project is located at http://www.dealii.org/
For mailing list/forum options, see 
https://groups.google.com/d/forum/dealii?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"deal.II User Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to dealii+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to