Control: tags -1 +patch
Hello!
On 10/17/21 19:38, John Paul Adrian Glaubitz wrote:
> This should be reported upstream. Chances are higher that upstream will see
> the bug and fix it.
>
> I'll forward it.
The attached patch fixes the problem for me and allows the build to succeed on
hppa without any problems. I have also opened a pull request upstream [1].
Adrian
> [1]
> https://github.com/Yubico/libfido2/pull/444/commits/257e380a0e8433d9579606580bdaaba15e802c5c.
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
From 257e380a0e8433d9579606580bdaaba15e802c5c Mon Sep 17 00:00:00 2001
From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
Date: Sun, 17 Oct 2021 19:49:00 +0200
Subject: [PATCH] cmake: Add -Werror when checking host compiler for
-fstack-protector
Since calling GCC with -fstack-protector will just generate a warning
when it doesn't support the flag on a given host architecture, we need
to add -Werror so the warning turns into an error and cause the cmake
check HAVE_STACK_PROTECTOR_ALL to fail when the flag is not supported.
fixes gh#443
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ed3819e..64013ca 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -80,7 +80,7 @@ if(NOT MSVC)
endif()
check_c_compiler_flag("-Wshorten-64-to-32" HAVE_SHORTEN_64_TO_32)
-check_c_compiler_flag("-fstack-protector-all" HAVE_STACK_PROTECTOR_ALL)
+check_c_compiler_flag("-Werror -fstack-protector-all" HAVE_STACK_PROTECTOR_ALL)
check_include_files(cbor.h HAVE_CBOR_H)
check_include_files(endian.h HAVE_ENDIAN_H)
--
2.30.2
