On Wed, Oct 29, 2008 at 12:01:20PM +0000, Wookey wrote: > > > The error is coming from gsf-init. Reassigning accordingly. > > > > Thanks for fixing this promptly. > > > > > gsf thinks only vfp enabled arm uses natural endian doubles. However, > > > eabi does that as well. As anyone using vfp is also using eabi, > > > the correct change is to switch the define. > > > > -#if defined(__arm__) && !defined(__vfp__) && (G_BYTE_ORDER == > > > G_LITTLE_ENDIAN) > > > +#if defined(__arm__) && !defined(__ARM_EABI__) && (G_BYTE_ORDER == > > > G_LITTLE_ENDIAN) > > This is my/phil blundell's fault. > > libgsf was fixed a long time ago - before eabi stuff had any sort of > plan in Debian. Using __vfp__ seemed like the best test at the time, > as recommended to me by pb. I'm not sure when you end up with > __ARM_EABI__ defined but __vfp__ not defined in practice, but I agree > the change is now correct.
__VFP_FP__ still is a better choice than __ARM_EABI__, IMHO, since it makes it clear that it's a fp byte order thing, and not any of the other EABI-mandated things. (Although I doubt you're going to be seeing many non-eabi vfp arm installs from this point onward.) (It's __VFP_FP__, not __vfp__.) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
