* Matt Waddel <matt.wad...@linaro.org> [2010-09-14 14:05]: > -- The list of supported architectures seems pretty much alphabetical. So I > put this one at the top. Hope that's OK.
That's fine but you should also add support for the udeb, i.e. debian/flash-kernel-installer.isinstallable, debian/flash-kernel-installer.postinst Would it also make sense to add the device to initramfs-tools/hooks/flash_kernel_set_root? Colin, Loïc: can you comment on the patch since I don't know anything about Versatile Express? > case "$machine" in > + "ARM-Versatile Express CA9x4") > + check_mtd Should there be a call to check_subarch? Or there an agreen subarch name for this platform? > + kmtd=$(mtdblock "kernel") > + if [ -z "$kmtd" ]; then > + error "Cannot find mtd partition 'kernel'" > + fi > + check_dev_mtdblock "$kmtd" > + kmtdsize=$(mtdsize "kernel") > + check_size "kernel" $(($kfilesize + 8 + 64)) $kmtdsize > + printf "Generating a u-boot compatible kernel image... " >&2 > + tmp=$(tempfile) > + cat $kfile >> $tmp > + mkimage -A arm -O linux -T kernel -C none -a 0x60008000 \ > + -e 0x60008000 -n "Linaro Kernel" -d $tmp $tmp.uboot \ This shouldn't say "Linaro". I wonder if it would make sense to drop "Debian" from all kernel/ramdisk references. > + >&2 1>/dev/null > + printf "Erasing Kernel NOR space... " >&2 > + dd if=/dev/zero of=$kmtd bs=$kmtdsize count=1 2>/dev/null How large is this partition? The reason I ask is because I wonder why you don't pad the file on disk before writing it, but maybe that's a bad idea when the mtd partition is very large. (Same goes for the initrd partition) -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100914215051.gn5...@jirafa.cyrius.com
