On Wed, May 04, 2011 at 08:19:25PM +0200, Christian PERRIER wrote: > Quoting Roland Dreier ([email protected]): > > diff --git a/grub-installer b/grub-installer > > index 95b6532..c8c1e74 100755 > > --- a/grub-installer > > +++ b/grub-installer > > @@ -231,7 +231,7 @@ case $prefix in > > /dev/mapper) > > disc_offered_devfs="$bootfs" > > ;; > > - > > /dev/[hsv]d[a-z0-9]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]*|/dev/ida/c[0-9]d[0-9]*|/dev/rs/c[0-9]d[0-9]*|/dev/mmcblk[0-9]|/dev/ad[0-9]*|/dev/da[0-9]*) > > + > > /dev/[hsv]d[a-z]|/dev/[sv]d[a-z][a-z]|/dev/[sv]d[a-z][a-z][a-z]|/dev/xvd[a-z]|/dev/cciss/c[0-9]d[0-9]*|/dev/ida/c[0-9]d[0-9]*|/dev/rs/c[0-9]d[0-9]*|/dev/mmcblk[0-9]|/dev/ad[0-9]*|/dev/da[0-9]*) > > disc_offered_devfs="$prefix" > > ;; > > Why are you changing [a-z0-9} to [a-z]?
I think, from distant memory, that that breaks the Hurd, which has /dev/hd0 etc. I don't see why we need /dev/[sv]d[a-z][a-z][a-z], either. Documentation/devices.txt doesn't list SCSI devices that high, and I'd be astonished if you ever found that many virtio devices either. The rest looks OK to me. -- Colin Watson [[email protected]] -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
