On Fri, 2016-09-30 at 11:21 -0700, Martin Michlmayr wrote: > Looking at the code, all uses of find_dtb_file() check for the result > and produce an error if the file doesn't exist, so maybe we should > just move the error messages into find_dtb_file(). Then we could > tell > the user where we were looking. > > Ian, any comments?
Nope, sounds sensible to me! Looks like handle_dtb() doesn't produce an error if the file doesn't exist -- but it probably should. Need to take care in the postrm.d case (where the file might legitimately not be there) though -- fortunately it looks like the result of find_dtb_file isn't actually used in that half of the if, so it could probably be moved. Cheers, Ian.