Control: retitle -1 please build libzstd udeb so that btrfs-progs can use zstd in Debian Installer Control: reassign -1 src:libzstd/ 1.3.5+dfsg-1
On Tue, Oct 09, 2018 at 06:24:47PM +0200, Alex Mestiashvili wrote: > On 10/09/2018 04:32 PM, Dimitri John Ledkov wrote: > > is o > > On Tue, 9 Oct 2018 at 12:23, Alex Mestiashvili <ames...@rsh2.donotuse.de> > > wrote: > >> > >> On 09/14/2018 08:04 PM, Nicholas D Steeves wrote: ... > >>> > >>> Would you please build a zstd udeb so that btrfs-progs can use zstd in > >>> Debian Installer and Rescue System? It uses zstd for transparent > >>> filesystem compression. > >>> > >>> eg: `chattr +c`, or `btrfs filesystem defrag -c`, or via a mount > >>> option `compress=zstd`. I believe the first and last of these use the > >>> kernel's libzstd, and that the udeb is primarily required for > >>> `btrfs-repair` to handle zstd extents in the Rescue System. Also, please > >>> continue to CC Dmitri Ledkov, Debian's btrfs-progs maintainer. > >>> ... > >> > >> As far as I see it's enough to add udeb stanzas in d/control in order to > >> build the udebs[0]. > >> Is there anything else to consider before uploading lisbzstd with udebs? > >> > > > > No, that's not at all enough. It ends up creating two empty packages, > > without any files in them. > > Oh, I see. I thought there is some debhelper magic involved and didn't > check the generated packages.. > I'm also surprised it didn't run a second dh_install run with $DESTDIR set to debian/udeb-package. Or alternatively dh_install debian/udeb-package. > > > > One needs to actually install a library into the library udeb and > > tools into tools-udeb. > > Note for fbtrfs only library-udeb is needed. > > Does that also apply for btrfs-repair? Initial bug report is about zstd > udeb as I see. Sorry for the inaccuracy; I've retitled and reassigned this bug. Initially I thought zstd was the name of the source package. > > > > Also do get it reviewed, as last time unwritten rules w.r.t. udebs got > > enforced and above patch was rejected on ground of not strict enough > > alternative shlibs deps generated. > > Thank you for clarifying, but I didn't understand the reason of reject :). Ditto, me neither. If I had to guess maybe ftpmasters want a manually generated symbols file for libzstd and libzstd-udeb? https://wiki.debian.org/UsingSymbolsFiles > @debian-boot folks, please review and please either fix it or explain > what is required. > Please read what Cyril (Debian Installer Team) wrote at these bugs in case these questions have already been answered: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898410 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886968 > Are there any udeb related docs available? > Sorry, I don't know of any. Kind regards, Nicholas
signature.asc
Description: PGP signature