On 25/06/2024 20:22, Cyril Brulebois wrote:
Michael Tokarev <m...@tls.msk.ru> (2024-06-25):
31.12.2023 19:11, Michael Tokarev wrote:
Hi!
There's a debian-specific patch in busybox since 2017 which adds ability
to lift variable name filtering rules for d-i. A comment in there says:
This is not a long term fix for this problem: a different approach is
needed to parse the values from the kernel command-line, but we don't
want to be responsible for holding up the debian-installer alpha
release any longer than it has already.
Is it still needed in 2024?
A friendly ping?
I can't dive into it right now to be 100% sure, but I can't think of a
reason why we wouldn't need to keep that. (I'm not aware of any work in
that area, except some extra fun with hostname last year, but maybe
someone worked on that without my noticing.)
I remember adding that. From memory, it's because we pass arguments to
d-i as kernel command-line args. Those get converted to environment
variables by the kernel (I think?), which is how d-i picks them up.
But those arguments have odd characters (for environment variables) in
them, such as slashes. At some point busybox started filtering out such
invalid environment variables, so d-i stopped seeing them. The hack is
needed to avoid filtering them out.
Before we can remove this hack, d-i would need to presumably parse
/proc/cmdline itself to get its arguments, rather than simply assuming
they would be in the environment. As far as I'm aware this hasn't been done.
HTH,
Chris
--
Chris Boot
bo...@debian.org
