Hi Otavio, On Saturday 12 August 2006 12:31, Frans Pop wrote: > If none of the now optional commands have been run, the progress bar > will still be stuck on 1 after the pkgsel/include step. So, what needs > to happen after this step is to make the progress bar jump to the > current value of progress_end.
You asked on IRC why the following code was needed: > if [ $progress_end -gt $progress_start ]; then > db_progress STEP $(($progress_end - $progress_start)) > fi Look what happens in the following scenario when the script is run: - set scrollkeeper diversions; progress bar is stepped to 1 - popularity-contest/participate is preseeded false => nothing happens - tasksel/first is preseeded empty => nothing happens - pkgsel/include is empty => nothing happens Or even the following scenario: - set scrollkeeper diversions; progress bar is stepped to 1 - popularity-contest/participate is not preseeded, progress bar goes to 5 - tasksel/first is preseeded empty => nothing happens - pkgsel/include is empty => nothing happens So where is the progress bar before the last two fixed items (that together only move the progress bar by 5 units) are run? My patch should make sure the progress bar always is at 95 before the last two items are run. One other thing: these new preseeding options that you are creating should be documented in the installation guide. Please make sure that happens (you don't necessarily have to do it yourself). Cheers, FJP
pgpbG4l9OSkGP.pgp
Description: PGP signature
