On Mon, Aug 21, 2006 at 09:47:59PM +0200, Frans Pop wrote:
On Monday 21 August 2006 20:55, Ronny Aasen wrote:
if it finds that the vg is isolated to the disk, preseeded to be
erased, it removes all Logicalvolumes, and VolumeGroups on that disk.

The basic algorithm looks OK, but you should probably try to use the general functions already available in lvm_tools.sh (part of the partman-lvm package) instead of the direct calls to pvs and vgs.

I think it would be a good idea to separate out the functionality to a lvm_purge_from_disk function in lvm_tools.sh.

Then it can be used both for partman-lvm and partman-auto-lvm, and in addition it would be trivial to use this if partman-auto-lvm gains support for multiple disks later.

Regards,
David


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to