Your message dated Wed, 19 Jan 2005 00:02:14 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#288814: fixed in debmirror 20050118
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 5 Jan 2005 20:07:02 +0000
>From [EMAIL PROTECTED] Wed Jan 05 12:07:02 2005
Return-path: <[EMAIL PROTECTED]>
Received: from lana.hrz.tu-chemnitz.de [134.109.132.3]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CmHQr-00051I-00; Wed, 05 Jan 2005 12:07:01 -0800
Received: from hedwig.hrz.tu-chemnitz.de ([134.109.132.173]
helo=mailbox.hrz.tu-chemnitz.de)
by lana.hrz.tu-chemnitz.de with esmtp (Exim 4.41)
id 1CmHQq-0007C7-Cg
for [EMAIL PROTECTED]; Wed, 05 Jan 2005 21:07:00 +0100
Received: from maximus.informatik.tu-chemnitz.de ([134.109.192.246] ident=mail)
by mailbox.hrz.tu-chemnitz.de with esmtp (Exim 4.43)
id 1CmHQq-0006eg-Ar
for [EMAIL PROTECTED]; Wed, 05 Jan 2005 21:07:00 +0100
Received: from stilzchen.informatik.tu-chemnitz.de ([134.109.192.209]
ident=mail)
by maximus.informatik.tu-chemnitz.de with esmtp (Exim 3.35 #1 (Debian))
id 1CmHQp-0000FC-00
for <[EMAIL PROTECTED]>; Wed, 05 Jan 2005 21:06:59 +0100
Received: from mpa by stilzchen.informatik.tu-chemnitz.de with local (Exim 3.35
#1 (Debian))
id 1CmHQp-0006HQ-00
for <[EMAIL PROTECTED]>; Wed, 05 Jan 2005 21:06:59 +0100
Date: Wed, 5 Jan 2005 21:06:59 +0100
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: debmirror replaces Packages{,bz2} too early
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="2oS5YaxWCcQjTEyO"
Content-Disposition: inline
User-Agent: Mutt/1.5.6i
From: Mirko Parthey <[EMAIL PROTECTED]>
X-Scan-Signature: 83a5f8de2c0ef3b8f39a5f9e6c2450f2
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--2oS5YaxWCcQjTEyO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: debmirror
Version: 20041209
Tags: patch
As far as I understand it, debmirror is supposed to download meta files
(e.g. Packages.gz) to .temp/, to avoid breaking the existing mirror
during a debmirror run. This is especially important when using
--postcleanup.
However, this does not work properly: when Packages and Packages.bz2 are
generated from Packages.gz, they are updated in both the mirror
directory and the temporary directory at the same time, since they are
hardlinked between the two directories. This leaves the mirror
inconsistent until the debmirror run is completed.
debmirror should break the hardlink before generating these files,
similar to the remote_get() subroutine.
Attached is a patch which fixes the problem for me.
Please apply it (or a suitably tweaked version) to debmirror.
Mirko
--2oS5YaxWCcQjTEyO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=debmirror-patch
--- debmirror 2005-01-05 20:33:48.000000000 +0100
+++ debmirror.new 2005-01-05 20:34:44.000000000 +0100
@@ -1146,6 +1146,15 @@
}
}
+# run system() with stdin and stdout redirected to files
+# unlinks stdout target file first to break hard links
+sub system_redirect_io {
+ my ($command, $fromfile, $tofile) = @_;
+
+ unlink($tofile) or die "unlink($tofile) failed: $!";
+ system("$command <$fromfile >$tofile");
+}
+
# Get Packages file in the passed subdirectory.
sub get_packages {
my $subdir=shift;
@@ -1157,8 +1166,8 @@
say("$subdir/Packages.gz needs fetch");
remote_get("$subdir/Packages.gz");
if (check_lists ("$tempdir/$subdir/Packages.gz")) {
- system("gunzip <$tempdir/$subdir/Packages.gz
>$tempdir/$subdir/Packages");
- system("bzip2 <$tempdir/$subdir/Packages
>$tempdir/$subdir/Packages.bz2");
+ system_redirect_io("gunzip", "$tempdir/$subdir/Packages.gz",
"$tempdir/$subdir/Packages");
+ system_redirect_io("bzip2", "$tempdir/$subdir/Packages",
"$tempdir/$subdir/Packages.bz2");
} else {
say("$subdir/Packages.gz failed md5sum check");
push (@errlog,"$subdir/Packages.gz failed md5sum check\n");
@@ -1178,7 +1187,7 @@
say("$subdir/Packages needs fetch");
remote_get("$subdir/Packages");
if (check_lists ("$tempdir/$subdir/Packages")) {
- system("bzip2 <$tempdir/$subdir/Packages
>$tempdir/$subdir/Packages.bz2");
+ system_redirect_io("bzip2", "$tempdir/$subdir/Packages",
"$tempdir/$subdir/Packages.bz2");
} else {
say("$subdir/Packages failed md5sum check");
push (@errlog,"$subdir/Packages failed md5sum check\n");
@@ -1231,8 +1240,8 @@
say("$subdir/Sources.gz needs fetch");
remote_get("$subdir/Sources.gz");
if (check_lists ("$tempdir/$subdir/Sources.gz")) {
- system("gunzip <$tempdir/$subdir/Sources.gz
>$tempdir/$subdir/Sources");
- system("bzip2 <$tempdir/$subdir/Sources
>$tempdir/$subdir/Sources.bz2");
+ system_redirect_io("gunzip", "$tempdir/$subdir/Sources.gz",
"$tempdir/$subdir/Sources");
+ system_redirect_io("bzip2", "$tempdir/$subdir/Sources",
"$tempdir/$subdir/Sources.bz2");
} else {
say("$subdir/Sources.gz failed md5sum check");
push (@errlog,"$subdir/Sources.gz failed md5sum check\n");
@@ -1252,7 +1261,7 @@
say("$subdir/Sources needs fetch");
remote_get("$subdir/Sources");
if (check_lists ("$tempdir/$subdir/Sources")) {
- system("bzip2 <$tempdir/$subdir/Sources
>$tempdir/$subdir/Sources.bz2");
+ system_redirect_io("bzip2", "$tempdir/$subdir/Sources",
"$tempdir/$subdir/Sources.bz2");
} else {
say("$subdir/Sources failed md5sum check, removing");
push (@errlog,"$subdir/Sources failed md5sum check, removing\n");
--2oS5YaxWCcQjTEyO--
---------------------------------------
Received: (at 288814-close) by bugs.debian.org; 19 Jan 2005 05:07:03 +0000
>From [EMAIL PROTECTED] Tue Jan 18 21:07:03 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Cr83b-0002zo-00; Tue, 18 Jan 2005 21:07:03 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1Cr7yw-00039w-00; Wed, 19 Jan 2005 00:02:14 -0500
From: Goswin von Brederlow <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#288814: fixed in debmirror 20050118
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Wed, 19 Jan 2005 00:02:14 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.3 required=4.0 tests=BAYES_00,DATING,
HAS_BUG_NUMBER,SUBJ_HAS_UNIQ_ID autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 4
Source: debmirror
Source-Version: 20050118
We believe that the bug you reported is fixed in the latest version of
debmirror, which is due to be installed in the Debian FTP archive:
debmirror_20050118.dsc
to pool/main/d/debmirror/debmirror_20050118.dsc
debmirror_20050118.tar.gz
to pool/main/d/debmirror/debmirror_20050118.tar.gz
debmirror_20050118_all.deb
to pool/main/d/debmirror/debmirror_20050118_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Goswin von Brederlow <[EMAIL PROTECTED]> (supplier of updated debmirror package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 18 Jan 2005 02:59:34 +0200
Source: debmirror
Binary: debmirror
Architecture: source all
Version: 20050118
Distribution: unstable
Urgency: low
Maintainer: Goswin von Brederlow <[EMAIL PROTECTED]>
Changed-By: Goswin von Brederlow <[EMAIL PROTECTED]>
Description:
debmirror - Debian partial mirror script, with ftp and package pool support
Closes: 286575 287465 287732 288814 288973 289286 289752
Changes:
debmirror (20050118) unstable; urgency=low
.
* Add --no-tty option to gpg (Closes: #289286)
reported by Holger Ruckdeschel <[EMAIL PROTECTED]>
* Move cleanup code into function and add missing chdir (Closes: #287465)
adapted patch by Daniel Parthey <[EMAIL PROTECTED]>
* Unlink hardlinks before system calls with redirected IO (Closes: #288814)
adapted patch by Mirko Parthey <[EMAIL PROTECTED]>
* Unlink metafiles later (Closes: #289752)
patch by Ingo Saitz <[EMAIL PROTECTED]>
* Typo fixes as found by Martin Kourim <[EMAIL PROTECTED]>
(Closes: #287732)
* Add --ignore-small-errors to allow updating inconsistent upstream
mirrors (Closes: #288973)
* Hide gpg signature check output if !verbose (Closes: #286575)
Files:
721036b68f9c9e221d43edc0632980e6 494 net extra debmirror_20050118.dsc
c609fb5d618a180157b88bbbbc71b1d1 16085 net extra debmirror_20050118.tar.gz
6959c3a591021792521759b1644b755c 23356 net extra debmirror_20050118_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFB7eZf78o9R9NraMQRAg97AJ9eYpxRe/ztR/15ghRVwbZ8txY/eQCfSWNr
geBs2nxyMprsNXMFf3/XerM=
=iySD
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
