Your message dated Sat, 29 Jan 2005 13:32:02 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#265879: fixed in afio 2.5-3
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Aug 2004 14:26:33 +0000
>From [EMAIL PROTECTED] Sun Aug 15 07:26:33 2004
Return-path: <[EMAIL PROTECTED]>
Received: from server14.greatnet.de [83.133.96.74]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BwLxw-0000gC-00; Sun, 15 Aug 2004 07:26:32 -0700
Received: from loba.usermo.de (p5086E0D9.dip0.t-ipconnect.de [80.134.224.217])
by server14.greatnet.de (server14.greatnet.de) with ESMTP id 6BB0FC8474
for <[EMAIL PROTECTED]>; Sun, 15 Aug 2004 16:26:40 +0200 (CEST)
Received: from loba.usermo.de ([EMAIL PROTECTED] [127.0.0.1])
by loba.usermo.de (8.12.3/8.12.3/Debian-6.6) with ESMTP id
i7FEQGKZ028170
(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK);
Sun, 15 Aug 2004 16:26:16 +0200
Received: (from [EMAIL PROTECTED])
by loba.usermo.de (8.12.3/8.12.3/Debian-6.6) id i7FEQBPK028159;
Sun, 15 Aug 2004 16:26:11 +0200
Message-Id: <[EMAIL PROTECTED]>
From: Christian Schrader <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: afio: Missing nullbyte separator for filelists and missing possibility
to disable globbing
X-Mailer: reportbug 1.50
Date: Sun, 15 Aug 2004 16:26:11 +0200
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: afio
Version: 2.5-2
Severity: wishlist
Tags: patch
-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux loba 2.6.7 #2 Wed Jun 16 12:23:14 CEST 2004 i686
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED]
Versions of packages afio depends on:
ii libc6 2.2.5-11.5 GNU C Library: Shared libraries an
Hi,
afio is able to use a nullbyte as separator for building the archive
(find ... -print0 | afio -o -0 ... ) but it is not possible to rebuild a
filelist out of the archive via "afio -t ..." with using a nullbyte
separator. If you got a filename with newlines the filelist contains
invalid filenames. I think it should be possible to use -0 also in
conjuction with -t (and may be other functions).
The second problem is that it is impossible to tell afio the exact names
for which files it should fetch from an archive. eg. If i use "-w filelist"
all names are used as glob patterns so that I can't simply use entries
of the archive toc als filelist. A filename like '/www/*html' would
extract all files which end on 'html' under /www. And it is not easy to
quote all possible chars to prevent globbing. Patterns which contains
newlines are impossible.
The following patch adds two switches:
-0 all entries in filelist use \0 as delimiter. "afio -t -0" generates
a filelist with this delimiter instead of \n. If a patternfile is
used with -w or -W it has to use \0 as delimiter.
-7 this disables globbing so that it is possible to use -w to specify
a filelist for which files to extract
This patch is just an example (sorry but I can't program). It is
possible that it breakes other functions and contains thousands of bugs. :)
I think afio should be robust against strange filenames because all
characters beside / and \0 are allowed in filenames especially when it
is used as backup backend. The is no reason to use -0 only for building
the archive and not for restoring the files.
regards,
Christian Schrader
---------------------- afio-nullbyte-globbing.patch ----------------------
diff -u afio-2.5.orig/afio.c afio-2.5/afio.c
--- afio-2.5.orig/afio.c Sun Aug 15 01:08:52 2004
+++ afio-2.5/afio.c Sun Aug 15 13:21:37 2004
@@ -309,6 +309,7 @@
STATIC Dir *DirP=NULL; /* list of directories with their saved timestamps
*/
STATIC char firstfilename[PATHSIZE]=""; /* for temp storage during -o */
STATIC int useoutmodetoc=0; /* used in tocentry() */
+ STATIC short noglob=0; /* disable globbing */
int main (int ac, char **av)
{
@@ -343,7 +344,7 @@
*/
while ((c = options (ac, av,
-
"aioprtIOVCb:c:de:fghjklmns:uvxXy:Y:zFKZL:R:qAE:G:M:w:W:T:SBD:P:Q:U4JH:0@:N:3:1:92:56:"))
+
"aioprtIOVCb:c:de:fghjklmns:uvxXy:Y:zFKZL:R:qAE:G:M:w:W:T:SBD:P:Q:U4JH:0@:N:3:1:92:56:7"))
)
{
switch (c)
@@ -437,6 +438,9 @@
case 'n':
++nflag;
break;
+ case '7':
+ noglob = 1;
+ break;
case 's':
/* Do a 'dry run' to check all values for syntax errors */
aruntil_string = strdup(optarg);
@@ -4481,8 +4485,12 @@
if (ISCONTROL(asb))
res = printf("//--%s",name);
else
- res = printf ("%s", name);
-
+ {
+ if (flag0)
+ res = printf ("%s%c", name, 0);
+ else
+ res = printf ("%s", name);
+ }
/* to find out about broken pipe as early as possible */
if(res > 0) res = fflush(stdout);
/* check for broken pipe on stdout, this ends the listing */
@@ -4542,7 +4550,8 @@
#endif /* S_IFLNK */
}
- putchar ('\n');
+ if (!flag0)
+ putchar ('\n');
}
/*
diff -u afio-2.5.orig/afio.h afio-2.5/afio.h
--- afio-2.5.orig/afio.h Sat Dec 20 14:59:42 2003
+++ afio-2.5/afio.h Sun Aug 15 14:28:37 2004
@@ -530,3 +530,5 @@
ulonglong optsize (char *);
void update_aruntil(void);
extern ulonglong maxsizetocompress;
+extern short noglob;
+extern short flag0;
Common subdirectories: afio-2.5.orig/debian and afio-2.5/debian
diff -u afio-2.5.orig/match.c afio-2.5/match.c
--- afio-2.5.orig/match.c Thu Apr 17 23:04:37 2003
+++ afio-2.5/match.c Sun Aug 15 15:35:05 2004
@@ -92,10 +92,34 @@
{
FILE *infile;
char pat[PATHSIZE+1];
-
+ int c,i;
+
infile=fopen(fname,"r");
if(infile==0) return 0;
+ if(flag0)
+ {
+ /* also the last entry needs a nullbyte! */
+
+ i=0;
+ while((c = fgetc(infile))!=EOF)
+ {
+ if(i > sizeof(pat))
+ fatal(pat,"Path name too long");
+
+ pat[i]=c;
+
+ if(c == '\0')
+ {
+ nameadd(pat,ptype);
+ i=0;
+ continue;
+ }
+ i++;
+ }
+ }
+ else
+ {
while(fgets(pat,PATHSIZE,infile)!=NULL)
{
/* remove \n */
@@ -110,7 +134,8 @@
nameadd(pat,ptype);
}
-
+ }
+
fclose(infile);
return 1;
}
@@ -180,7 +205,14 @@
p=px->p_str;
if(ignoreslash && (p[0]=='/')) p++;
- if(fnmatch(p,n,0)==0) return 0;
+ if (noglob)
+ {
+ if(strcmp(p,n)==0) return 0;
+ }
+ else
+ {
+ if(fnmatch(p,n,0)==0) return 0;
+ }
}
if(!existpospat) return 0; else return -1;
------------------------- snip --------------------------
---------------------------------------
Received: (at 265879-close) by bugs.debian.org; 29 Jan 2005 18:35:47 +0000
>From [EMAIL PROTECTED] Sat Jan 29 10:35:47 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CuxRi-0006v8-00; Sat, 29 Jan 2005 10:35:46 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1CuxO6-0006Fm-00; Sat, 29 Jan 2005 13:32:02 -0500
From: Erik Schanze <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#265879: fixed in afio 2.5-3
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 29 Jan 2005 13:32:02 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: afio
Source-Version: 2.5-3
We believe that the bug you reported is fixed in the latest version of
afio, which is due to be installed in the Debian FTP archive:
afio_2.5-3.diff.gz
to pool/main/a/afio/afio_2.5-3.diff.gz
afio_2.5-3.dsc
to pool/main/a/afio/afio_2.5-3.dsc
afio_2.5-3_i386.deb
to pool/main/a/afio/afio_2.5-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Erik Schanze <[EMAIL PROTECTED]> (supplier of updated afio package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 25 Jan 2005 22:36:29 +0100
Source: afio
Binary: afio
Architecture: source i386
Version: 2.5-3
Distribution: unstable
Urgency: low
Maintainer: Erik Schanze <[EMAIL PROTECTED]>
Changed-By: Erik Schanze <[EMAIL PROTECTED]>
Description:
afio - archive file manipulation program
Closes: 265879 280201 289107
Changes:
afio (2.5-3) unstable; urgency=low
.
* New maintainer
* cleaned up debian/copyright for better reading, updated download URL
* debian/control: set Standards-Version to 3.6.1
* removed patch-* files from debian/ to save space
* Added dpatch to Build-Depends
* Put previous fix of bug 246044 to patch file 05_variable_msg_length.dpatch
but changes malloc() call to afio's memget() for error handling
* Added patch 10_afio_nullbyte_globbing.dpatch:
- brings nullbyte separator for filelists and missing possibility to
disable globbing (Closes: #265879)
* Added patch 20_manpage.dpatch:
- added .ogg extention to list "will not compressed" (Closes: #280201)
- removed additional line in afio.1 (Closes: #289107)
- added explaination on option -0 and new option -7 (for bug #265879)
* Increased debhelper compat level to 4
* Added watch file for DEHS
* Description line now begins lowercase (fixes lintian warning)
Files:
37b1e5e74b9ad2379333ade0ec0f191a 545 utils optional afio_2.5-3.dsc
afb57a2c6440d60b550a1ad504ebecf6 10384 utils optional afio_2.5-3.diff.gz
cb59c536a8b374fa6bb447adbfcee3d7 80092 utils optional afio_2.5-3_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFB+89jCZSR95Gw07cRAv20AKCJDdeOCIgT9PLcx18xJwD6w0WHxgCgjSO3
iV+N2W2GevHJrl8zpltmCCk=
=G6hH
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
