Your message dated Thu, 17 Mar 2005 22:32:02 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#298509: fixed in kernel-package 8.127
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 8 Mar 2005 00:49:35 +0000
>From [EMAIL PROTECTED] Mon Mar 07 16:49:35 2005
Return-path: <[EMAIL PROTECTED]>
Received: from mail.renesas.com (mail04.idc.renesas.com) [202.234.163.13]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D8Sug-0007wr-00; Mon, 07 Mar 2005 16:49:30 -0800
Received: (from [EMAIL PROTECTED])
by guardian05.idc.renesas.com with id j280mwu3003385;
Tue, 8 Mar 2005 09:48:58 +0900 (JST)
Received: from unknown [172.20.8.69] by guardian05.idc.renesas.com with SMTP id
KAA03384 ; Tue, 8 Mar 2005 09:48:57 +0900
Received: from mrkaisv.hoku.renesas.com ([10.145.105.245])
by ml01.idc.renesas.com (8.12.10/8.12.10) with ESMTP id j280muko012367;
Tue, 8 Mar 2005 09:48:56 +0900 (JST)
Received: from localhost (pcepx10 [10.145.105.241])
by mrkaisv.hoku.renesas.com (Postfix) with ESMTP
id 4C7C0798072; Tue, 8 Mar 2005 09:48:56 +0900 (JST)
Date: Tue, 08 Mar 2005 09:48:56 +0900 (JST)
Message-Id: <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: Re: kernel-package: Missing CROSS_ARG causes spurious warnings
From: Hirokazu Takata <[EMAIL PROTECTED]>
In-reply-to: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
Original-recipient: rfc822;[EMAIL PROTECTED]
X-Mailer: Mew version 3.3 on XEmacs 21.4.17 (Jumbo Shrimp)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: kernel-package
Version: 8.125
Severity: minor
Tags: patch
From: Horms <[EMAIL PROTECTED]>
Date: Wed, 2 Mar 2005 17:46:33 +0900
> When using --cross-compile XXX, make-kpkg sets the environment
> variable CROSS_COMPILE=XXX. It subsequently also sets
> CROSS_ARG="CROSS_COMPILE=XXX-".
Hmm...
It seems that make-kpkg script assumes --cross-compile or --cross_compile
is to be set "XXX-".
--- make-kpkg ---
my $cc = $ENV{'CC'} if $ENV{'CC'};
$cc =~ s/^\s+//g if $cc;
$cc =~ s/\s+$//g if $cc;
$cc .= " ";
if ($cc eq ' ') { $cc = $cross_compile; $cc .= "gcc "; };
--- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... this code assumes $cross_compile includes "-".
> Most invocations of Make for the kernel tree's toplevel Makefile
> are of the form make ... $CROSS_ARG ... target. And this works fine.
> However, in some cases $CROSS_ARG is missing an this causes warnings
> to be displayed as make picks up the value of CROSS_COMPILE from
> the environment, which is XXX instead of XXX-.
>
> I think that the warnings are harmless but it is at the very least
> confusing. The attached patch seems to resolve the problem.
> However, perhaps a better fix would be to have make-kpkg
> set CROSS_COMPILE=XXX- and abandon CROSS_ARG all together.
Actually, it breaks kernel compilation.
ex.)
For environment variable CROSS_COMPILE=m32r-linux-,
"-" is duplicated and it causes errors.
make: m32r-linux--gcc: Command not found
In case of using a environement variable CROSS_COMPILE,
I think the variable CROSS_COMPILE should keep "XXX-", because a kernel
must be able to be compiled without a make-kpkg script.
> However, perhaps a better fix would be to have make-kpkg
> set CROSS_COMPILE=XXX- and abandon CROSS_ARG all together.
I agree with you in a point of CROSS_COMPILE must keep "XXX-".
Please let me summarize:
1) If we use --cross-compile, we have to specify --cross-compile "XXX-".
--cross-compile "XXX-" sets a make variable CROSS_COMPILE="XXX-", which
is used to set CROSS_ARG.
2) If not --cross-compile is specified, an environment variable
CROSS_COMPILE(=XXX-) is used to set CROSS_ARG.
Anyway, we should always specify --cross-compile or CROSS_COMPILE in
"XXX-" style (with a "-" character at the last).
Therefore, I think an additional patch is required as follows:
--- kernel-package-8.125.org/kernel/rules 2005-03-02 01:52:17.000000000
+0900
+++ kernel-package-8.125/kernel/rules 2005-03-07 22:38:15.243926272 +0900
@@ -118,7 +118,7 @@ ifndef CROSS_COMPILE
endif
endif
else
- KERNEL_CROSS:=$(CROSS_COMPILE)-
+ KERNEL_CROSS:=$(CROSS_COMPILE)
endif
ifneq ($(strip $(KERNEL_CROSS)),)
Please apply this.
Thank you.
--
Hirokazu Takata <[EMAIL PROTECTED]>
Linux/M32R Project: http://www.linux-m32r.org/
---------------------------------------
Received: (at 298509-close) by bugs.debian.org; 18 Mar 2005 04:03:05 +0000
>From [EMAIL PROTECTED] Thu Mar 17 20:03:04 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DC8hU-0003lM-00; Thu, 17 Mar 2005 20:03:04 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DC8DS-0002ao-00; Thu, 17 Mar 2005 22:32:02 -0500
From: Manoj Srivastava <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#298509: fixed in kernel-package 8.127
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Thu, 17 Mar 2005 22:32:02 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 2
Source: kernel-package
Source-Version: 8.127
We believe that the bug you reported is fixed in the latest version of
kernel-package, which is due to be installed in the Debian FTP archive:
kernel-package_8.127.dsc
to pool/main/k/kernel-package/kernel-package_8.127.dsc
kernel-package_8.127.tar.gz
to pool/main/k/kernel-package/kernel-package_8.127.tar.gz
kernel-package_8.127_all.deb
to pool/main/k/kernel-package/kernel-package_8.127_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Manoj Srivastava <[EMAIL PROTECTED]> (supplier of updated kernel-package
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 17 Mar 2005 21:12:35 -0600
Source: kernel-package
Binary: kernel-package
Architecture: source all
Version: 8.127
Distribution: unstable
Urgency: low
Maintainer: Manoj Srivastava <[EMAIL PROTECTED]>
Changed-By: Manoj Srivastava <[EMAIL PROTECTED]>
Description:
kernel-package - A utility for building Linux kernel related Debian packages.
Closes: 298509 299863
Changes:
kernel-package (8.127) unstable; urgency=low
.
* Bug fix: "kernel-package: make-kpkg uses run-parts -v option, which
breaks woody->sarge upgrades", thanks to Sven Luther (Closes: #299863).
* Bug fix: "kernel-package: Missing CROSS_ARG causes spurious warnings",
thanks to Hirokazu Takata (Closes: #298509).
Files:
cda4d0a73a60bb2e9fde38d3d80aaaee 483 misc optional kernel-package_8.127.dsc
14ed68e64ad07974f0733de9a5cca83a 503227 misc optional
kernel-package_8.127.tar.gz
18608810b4b0e6e05ab5a36c1fc58f6c 355232 misc optional
kernel-package_8.127_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCOkgOIbrau78kQkwRAnlkAJ9RvQAUZGekcKV3zAnOdCcm2RN4WwCfWyoD
41iMS5NYiHIIGpToxtguZ4M=
=PZoT
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
