Your message dated Mon, 28 Mar 2005 08:32:57 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#301234: fixed in libpam-mount 0.9.22-5
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Mar 2005 14:53:47 +0000
>From [EMAIL PROTECTED] Thu Mar 24 06:53:47 2005
Return-path: <[EMAIL PROTECTED]>
Received: from uucp.gnuu.de [151.189.20.84]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DETiU-0003WM-00; Thu, 24 Mar 2005 06:53:46 -0800
Received: from alea.gnuu.de ([EMAIL PROTECTED])
by uucp.gnuu.de (8.12.9/8.12.9) with bsmtp id j2OErjMV045085
for [EMAIL PROTECTED]; Thu, 24 Mar 2005 15:53:45 +0100 (CET)
(envelope-from [EMAIL PROTECTED])
Received: from ibook.localnet ([192.168.0.5] helo=alea.gnuu.de)
by alea.gnuu.de with esmtp (Exim 3.36 #1 (Debian))
id 1DEQhP-00044B-00
for <[EMAIL PROTECTED]>; Thu, 24 Mar 2005 12:40:27 +0100
Received: from joerg by alea.gnuu.de with local (Exim 4.50)
id 1DEQh4-00011W-1a
for [EMAIL PROTECTED]; Thu, 24 Mar 2005 12:40:06 +0100
Date: Thu, 24 Mar 2005 12:40:06 +0100
From: =?iso-8859-1?Q?J=F6rg?= Sommer <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: libpam-mount: improvments
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="ieNMXl1Fr3cevapt"
Content-Disposition: inline
User-Agent: Mutt/1.5.6+20040907i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--ieNMXl1Fr3cevapt
Content-Type: multipart/mixed; boundary="CblX+4bnyfN0pR09"
Content-Disposition: inline
--CblX+4bnyfN0pR09
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: libpam-mount
Version: 0.9.22-2
Severity: minor
Hi,
I've did some improvments:
IFS may have any influence on other command. You should set it back to
default.
+unset IFS
This is the same with one sed call:
- DMDEVICE=3D`$LOSETUP $DEVICE | egrep '(.+)' | awk '{print $3}' | se=
d 's/(//; s/)//'`
+ DMDEVICE=3D`$LOSETUP $DEVICE 2>/dev/null | sed -n '/(.+)/ { s/.*(//;
s/).=
*//; p;}'`
This call all be done with shell variable substitution:
-CIPHEROPT=3D"aes"
-if [ -n "$CIPHER" ]; then
- CIPHEROPT=3D"$CIPHER"
-fi
-
-HASHOPT=3D"ripemd160"
-if [ -n "$HASH" ]; then
- HASHOPT=3D"$HASH"
-fi
-
-KEYSIZEOPT=3D"256"
-if [ -n "$KEYSIZE" ]; then
- KEYSIZEOPT=3D"$KEYSIZE"
-fi
-
-$CRYPTSETUP -c $CIPHEROPT -h $HASHOPT -s $KEYSIZEOPT create $DMDEVICE $DEV=
ICE
+$CRYPTSETUP -c ${CIPHER:-aes} -h ${HASH:-ripemd160} -s ${KEYSIZE:-256} \
+ create $DMDEVICE $DEVICE
With !=3D you compare strings. This means 00 !=3D 0 returns true. What you
want is numerical comaprison with -ne
-if [ $? !=3D 0 ]; then
+if [ $? -ne 0 ]; then
This can also be done with variable substitution:
-if [ -z "$MOUNTOPTIONS" ]; then
- # $MOUNT_POINT might not exist as mount can try to read it from
/etc/fstab
- $MOUNT /dev/mapper/$DMDEVICE $MOUNT_POINT
- if [ $? !=3D 0 ]; then
- echo "${0##*/}: error mounting $DMDEVICE" >&2
- $CRYPTSETUP remove $DMDEVICE
- [ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
- exit 1
- fi
-else
- $MOUNT -o $MOUNTOPTIONS /dev/mapper/$DMDEVICE $MOUNT_POINT
- if [ $? !=3D 0 ]; then
- echo "${0##*/}: error mounting $DMDEVICE" >&2
- $CRYPTSETUP remove $DMDEVICE
- [ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
- exit 1
- fi
+# $MOUNT_POINT might not exist as mount can try to read it from /etc/fstab
+$MOUNT ${MOUNTOPTIONS:+-o $MOUNTOPTIONS} /dev/mapper/$DMDEVICE $MOUNT_POINT
+if [ $? -ne 0 ]; then
+ echo "${0##*/}: error mounting $DMDEVICE" >&2
+ $CRYPTSETUP remove $DMDEVICE
+ [ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
+ exit 1
fi
J=F6rg.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (990, 'unstable')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.9
Locale: LANG=3Dde_DE, LC_CTYPE=3Dde_DE (charmap=3DISO-8859-1)
Versions of packages libpam-mount depends on:
ii libc6 2.3.2.ds1-20 GNU C Library: Shared librarie=
s an
ii libglib2.0-0 2.6.3-1 The GLib library of C routines
ii libssl0.9.7 0.9.7e-3 SSL shared libraries
ii mount 2.12p-3 Tools for mounting and manipul=
atin
ii zlib1g 1:1.2.2-4 compression library - runtime
-- no debconf information
--CblX+4bnyfN0pR09
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
Content-Transfer-Encoding: quoted-printable
--- mount.crypt 2005-03-07 17:34:09.000000000 +0100
+++ /tmp/mount.crypt 2005-03-24 12:06:42.790952752 +0100
@@ -115,6 +115,7 @@
;;
esac
done
+unset IFS
=20
if [ x"${LOOP}" =3D xtrue ]; then
DEVICE=3D`_losetup $DEVICE`
@@ -122,7 +123,7 @@
# if loop device, make device mapper name based on file pointed to
case "$DEVICE" in
/dev/loop*)
- DMDEVICE=3D`$LOSETUP $DEVICE | egrep '(.+)' | awk '{print $3}' | se=
d 's/(//; s/)//'`
+ DMDEVICE=3D`$LOSETUP $DEVICE 2>/dev/null | sed -n '/(.+)/ { s/.*(//;
s/).=
*//; p;}'`
esac
# if not a loop device or previous command fails use $DEVICE
: ${DMDEVICE:=3D$DEVICE}
@@ -130,43 +131,19 @@
# FIXME: blind replacement of / with _ may be a bad idea.
DMDEVICE=3D`echo $DMDEVICE | sed 's/\//_/g'`
=20
-CIPHEROPT=3D"aes"
-if [ -n "$CIPHER" ]; then
- CIPHEROPT=3D"$CIPHER"
-fi
-
-HASHOPT=3D"ripemd160"
-if [ -n "$HASH" ]; then
- HASHOPT=3D"$HASH"
-fi
-
-KEYSIZEOPT=3D"256"
-if [ -n "$KEYSIZE" ]; then
- KEYSIZEOPT=3D"$KEYSIZE"
-fi
-
-$CRYPTSETUP -c $CIPHEROPT -h $HASHOPT -s $KEYSIZEOPT create $DMDEVICE $DEV=
ICE
-if [ $? !=3D 0 ]; then
+$CRYPTSETUP -c ${CIPHER:-aes} -h ${HASH:-ripemd160} -s ${KEYSIZE:-256} \
+ create $DMDEVICE $DEVICE
+if [ $? -ne 0 ]; then
echo "${0##*/}: error creating $DMDEVICE" >&2
[ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
exit 1
fi
=20
-if [ -z "$MOUNTOPTIONS" ]; then
- # $MOUNT_POINT might not exist as mount can try to read it from
/etc/fstab
- $MOUNT /dev/mapper/$DMDEVICE $MOUNT_POINT
- if [ $? !=3D 0 ]; then
- echo "${0##*/}: error mounting $DMDEVICE" >&2
- $CRYPTSETUP remove $DMDEVICE
- [ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
- exit 1
- fi
-else
- $MOUNT -o $MOUNTOPTIONS /dev/mapper/$DMDEVICE $MOUNT_POINT
- if [ $? !=3D 0 ]; then
- echo "${0##*/}: error mounting $DMDEVICE" >&2
- $CRYPTSETUP remove $DMDEVICE
- [ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
- exit 1
- fi
+# $MOUNT_POINT might not exist as mount can try to read it from /etc/fstab
+$MOUNT ${MOUNTOPTIONS:+-o $MOUNTOPTIONS} /dev/mapper/$DMDEVICE $MOUNT_POINT
+if [ $? -ne 0 ]; then
+ echo "${0##*/}: error mounting $DMDEVICE" >&2
+ $CRYPTSETUP remove $DMDEVICE
+ [ x"$LOOP" =3D xtrue ] && $LOSETUP -d $DEVICE
+ exit 1
fi
--CblX+4bnyfN0pR09--
--ieNMXl1Fr3cevapt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iQEVAwUBQkKnFYZ13Cz2nwVYAQId8wgAkQoZ/ZPtRfRGdFvqVWgVEBseSomaICWm
ERJV2lkys1Z4OUE3YpBJ/02sSY5HUw9dtKF59PcWy9qjsGtv5E/9NHu82pMv31B+
dXnYMooeCQa1rDu9wH7nSUW72YUXehIoy7EZN6Nl7lR4zyOxo0cQUQeGb5fwUfXP
5un4ZVVFroYu2Uuikleuzi3+4FAzgneIbaewkrdAbD/YCPgTyxNMR+jOb1mKj8Da
LcbB6xEGRchCtqbqxcMnYOX1VnND7JfJVwtxkcLF2s2JtEGyeT2ZCm7LX2VUGAlQ
Tp0gVJdNS7aeutIyqHEGvoxQhSFlPbKDzPWIog92z3MQOM/N9/gu2A==
=FUbE
-----END PGP SIGNATURE-----
--ieNMXl1Fr3cevapt--
---------------------------------------
Received: (at 301234-close) by bugs.debian.org; 28 Mar 2005 13:38:20 +0000
>From [EMAIL PROTECTED] Mon Mar 28 05:38:20 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DFuRg-000688-00; Mon, 28 Mar 2005 05:38:20 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DFuMT-0005SG-00; Mon, 28 Mar 2005 08:32:57 -0500
From: Bastian Kleineidam <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#301234: fixed in libpam-mount 0.9.22-5
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Mon, 28 Mar 2005 08:32:57 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 2
Source: libpam-mount
Source-Version: 0.9.22-5
We believe that the bug you reported is fixed in the latest version of
libpam-mount, which is due to be installed in the Debian FTP archive:
libpam-mount_0.9.22-5.diff.gz
to pool/main/libp/libpam-mount/libpam-mount_0.9.22-5.diff.gz
libpam-mount_0.9.22-5.dsc
to pool/main/libp/libpam-mount/libpam-mount_0.9.22-5.dsc
libpam-mount_0.9.22-5_i386.deb
to pool/main/libp/libpam-mount/libpam-mount_0.9.22-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastian Kleineidam <[EMAIL PROTECTED]> (supplier of updated libpam-mount
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 28 Mar 2005 15:03:23 +0200
Source: libpam-mount
Binary: libpam-mount
Architecture: source i386
Version: 0.9.22-5
Distribution: unstable
Urgency: high
Maintainer: Bastian Kleineidam <[EMAIL PROTECTED]>
Changed-By: Bastian Kleineidam <[EMAIL PROTECTED]>
Description:
libpam-mount - a PAM module that can mount volumes for a user session
Closes: 301232 301233 301234
Changes:
libpam-mount (0.9.22-5) unstable; urgency=high
.
* README.Debian:
- Improved the dm-crypt mount point example using a random password
keyfile, not a simple password string.
- Clarified the mystic keysize calculation (bits vs. bytes).
- Added note about how important the .key files are for crypted
partitions
* Added space to IFS in mount.crypt when splitting options,
thanks to Jörg Sommer for the patch. (Closes: #301233).
* added more improvements from Jörg Sommer to mount.crypt
(Closes: #301234)
* Added fsck option to mount.crypt to execute fsck before mounting
(Closes: #301232)
* urgency still high
Files:
88ca0049741a7ebefbd7729300d465ba 670 admin extra libpam-mount_0.9.22-5.dsc
b31bda6eab817d2605402c455400dff4 103935 admin extra
libpam-mount_0.9.22-5.diff.gz
ec3bf23373c9b9405535e88564b11a93 103316 admin extra
libpam-mount_0.9.22-5_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCSAGbeBwlBDLsbz4RAl1HAKCqyDd5ndjhprcYZeywQyE00jPsUgCgnr0i
dDM4h41QdbIld0BmwKpYX4A=
=IaSe
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
