Your message dated Tue, 28 Nov 2006 03:47:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#399717: fixed in shibboleth-sp 1.3f.dfsg1-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: shibboleth-sp
Version: 1.3f.dfsg1-1
Severity: normal
Tags: patch

When building 'shibboleth-sp' on amd64/unstable, I get the following error:

Making all in apache
make[3]: Entering directory `/shibboleth-sp-1.3f.dfsg1/apache'
if /bin/sh ../libtool --silent --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I. -I..    -DLINUX=2 -D_GNU_SOURCE -D_REENTRANT -I/usr/include/apache2 -I. 
-I/usr/include/apr-1.0 -I/usr/include/postgresql  -DLINUX=2 -D_GNU_SOURCE 
-D_REENTRANT -I/usr/include/apr-1.0 -I/usr/include/openssl 
-I/usr/include/postgresql -I/usr/include/xmltok -pthread    -pipe -Wall -g -O2 
-pthread  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE  -I/usr/include/apr-1.0  
-I/usr/include/apache2 -pthread -Wall -g -O2 -Wall -O2 -DNDEBUG -MT 
mod_shib_22_la-mod_shib_22.lo -MD -MP -MF 
".deps/mod_shib_22_la-mod_shib_22.Tpo" -c -o mod_shib_22_la-mod_shib_22.lo 
`test -f 'mod_shib_22.cpp' || echo './'`mod_shib_22.cpp; \
        then mv -f ".deps/mod_shib_22_la-mod_shib_22.Tpo" 
".deps/mod_shib_22_la-mod_shib_22.Plo"; else rm -f 
".deps/mod_shib_22_la-mod_shib_22.Tpo"; exit 1; fi
mod_apache.cpp: In function 'const char* 
shib_set_server_string_slot(cmd_parms*, void*, const char*)':
mod_apache.cpp:196: error: cast from 'void*' to 'int' loses precision
mod_apache.cpp: In function 'int shib_check_user(request_rec*)':
mod_apache.cpp:344: error: cast from 'void*' to 'int' loses precision
mod_apache.cpp:348: error: cast from 'void*' to 'int' loses precision
mod_apache.cpp: In function 'int shib_handler(request_rec*)':
mod_apache.cpp:393: error: cast from 'void*' to 'int' loses precision
mod_apache.cpp: In function 'int shib_auth_checker(request_rec*)':
mod_apache.cpp:430: error: cast from 'void*' to 'int' loses precision
make[3]: *** [mod_shib_22_la-mod_shib_22.lo] Error 1
make[3]: Leaving directory `/shibboleth-sp-1.3f.dfsg1/apache'

With the attached patch 'shibboleth-sp' can be compiled on amd64.

Regards
Andreas Jochens

diff -urN ../tmp-orig/shibboleth-sp-1.3f.dfsg1/apache/mod_apache.cpp 
./apache/mod_apache.cpp
--- ../tmp-orig/shibboleth-sp-1.3f.dfsg1/apache/mod_apache.cpp  2006-10-02 
17:51:48.000000000 +0000
+++ ./apache/mod_apache.cpp     2006-11-20 14:35:10.000000000 +0000
@@ -193,7 +193,7 @@
 extern "C" const char* shib_set_server_string_slot(cmd_parms* parms, void*, 
const char* arg)
 {
     char* 
base=(char*)ap_get_module_config(parms->server->module_config,&mod_shib);
-    int offset=(int)parms->info;
+    long offset=(long)parms->info;
     *((char**)(base + offset))=ap_pstrdup(parms->pool,arg);
     return NULL;
 }
@@ -341,11 +341,11 @@
     // Check user authentication and export information, then set the handler 
bypass
     pair<bool,void*> res = sta.doCheckAuthN(true);
     apr_pool_userdata_setn((const void*)42,g_UserDataKey,NULL,r->pool);
-    if (res.first) return (int)res.second;
+    if (res.first) return (long)res.second;
 
     // user auth was okay -- export the assertions now
     res = sta.doExportAssertions();
-    if (res.first) return (int)res.second;
+    if (res.first) return (long)res.second;
 
     // export happened successfully..  this user is ok.
     return OK;
@@ -390,7 +390,7 @@
     ShibTargetApache sta(r);
 
     pair<bool,void*> res = sta.doHandler();
-    if (res.first) return (int)res.second;
+    if (res.first) return (long)res.second;
 
     ap_log_rerror(APLOG_MARK, APLOG_ERR|APLOG_NOERRNO, SH_AP_R(r), 
"doHandler() did not do anything.");
     return SERVER_ERROR;
@@ -427,7 +427,7 @@
     ShibTargetApache sta(r);
 
     pair<bool,void*> res = sta.doCheckAuthZ();
-    if (res.first) return (int)res.second;
+    if (res.first) return (long)res.second;
 
     // We're all okay.
     return OK;


--- End Message ---
--- Begin Message ---
Source: shibboleth-sp
Source-Version: 1.3f.dfsg1-2

We believe that the bug you reported is fixed in the latest version of
shibboleth-sp, which is due to be installed in the Debian FTP archive:

libapache2-mod-shib_1.3f.dfsg1-2_i386.deb
  to pool/main/s/shibboleth-sp/libapache2-mod-shib_1.3f.dfsg1-2_i386.deb
libshib-dev_1.3f.dfsg1-2_i386.deb
  to pool/main/s/shibboleth-sp/libshib-dev_1.3f.dfsg1-2_i386.deb
libshib-target5_1.3f.dfsg1-2_i386.deb
  to pool/main/s/shibboleth-sp/libshib-target5_1.3f.dfsg1-2_i386.deb
libshib6_1.3f.dfsg1-2_i386.deb
  to pool/main/s/shibboleth-sp/libshib6_1.3f.dfsg1-2_i386.deb
shibboleth-sp_1.3f.dfsg1-2.diff.gz
  to pool/main/s/shibboleth-sp/shibboleth-sp_1.3f.dfsg1-2.diff.gz
shibboleth-sp_1.3f.dfsg1-2.dsc
  to pool/main/s/shibboleth-sp/shibboleth-sp_1.3f.dfsg1-2.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <[EMAIL PROTECTED]> (supplier of updated shibboleth-sp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 27 Nov 2006 19:26:19 -0800
Source: shibboleth-sp
Binary: libapache2-mod-shib libshib6 libshib-dev libshib-target5
Architecture: source i386
Version: 1.3f.dfsg1-2
Distribution: unstable
Urgency: low
Maintainer: Quanah Gibson-Mount <[EMAIL PROTECTED]>
Changed-By: Russ Allbery <[EMAIL PROTECTED]>
Description: 
 libapache2-mod-shib - Shibboleth implements the OASIS SAML v1.1 specification,
 libshib-dev - Shibboleth federated authorization system (development)
 libshib-target5 - Shibboleth implements the OASIS SAML v1.1 specification,
 libshib6   - Shibboleth federated authorization system (development)
Closes: 399717
Changes: 
 shibboleth-sp (1.3f.dfsg1-2) unstable; urgency=low
 .
   * Cast Apache configuration data to a long rather than an int, since the
     Apache configuration interface uses a pointer type to store it and
     otherwise C++ compilers abort with a (correct) error on 64-bit
     platforms.  Patch from Andreas Jochens.  (Closes: #399717)
   * Reformat the README.Debian for the Apache module and add detailed
     instructions on how to test with testshib.org.
   * Remove IQ-metadata.xml and relocate example-metadata.xml
Files: 
 a286768b178642ad576b65de01a7fc41 936 web optional 
shibboleth-sp_1.3f.dfsg1-2.dsc
 ea1f054a34d877888c49ccf336d8f636 30261 web optional 
shibboleth-sp_1.3f.dfsg1-2.diff.gz
 aa466fcea8885adde1c9f9b4b548482d 432404 libdevel extra 
libshib-dev_1.3f.dfsg1-2_i386.deb
 945a6251f20aeafb46e655daaeb04039 76284 libs optional 
libshib6_1.3f.dfsg1-2_i386.deb
 49f2ffbd1637344308ce514b99c2f1c3 200062 libs optional 
libshib-target5_1.3f.dfsg1-2_i386.deb
 128e26fffc49f4227d8735edae3cd1d9 3708480 web optional 
libapache2-mod-shib_1.3f.dfsg1-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFa7B2+YXjQAr8dHYRAlLNAJ9yGwZbar+oXtXWsSSrt9OcvfmJEwCgwQdJ
9JbqfHPnrsu5/8GRougC9PI=
=jLkG
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to