Your message dated Tue, 29 Mar 2005 02:40:19 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Bug #301313 - kernel-package: Plus sign in appended version 
breaks menu.lst
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 25 Mar 2005 06:41:05 +0000
>From [EMAIL PROTECTED] Thu Mar 24 22:41:05 2005
Return-path: <[EMAIL PROTECTED]>
Received: from (deb.local) [134.39.100.5] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DEiVF-0007qe-00; Thu, 24 Mar 2005 22:41:05 -0800
Received: by deb.local (Postfix, from userid 1000)
        id D387B3A; Thu, 24 Mar 2005 22:40:44 -0800 (PST)
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: kernel-package: Plus sign in appended version breaks menu.lst
X-Debbugs-CC: jun <[EMAIL PROTECTED]>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Message-Id: <[EMAIL PROTECTED]>
Date: Thu, 24 Mar 2005 22:40:44 -0800 (PST)
From: [EMAIL PROTECTED] (Jun Inoue)
Content-Transfer-Encoding: quoted-printable
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
        X_DEBBUGS_CC autolearn=ham version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: kernel-package
Version: 8.125
Severity: normal


I created a package with make-kpkg --append-to-version=3D+2005.03.21,
and the corresponding menu.lst entry was:

title           Debian GNU/Linux, kernel 2.6.8+2005.03.21=20
root            (hd0,4)
kernel          /vmlinuz-2.6.8+2005.03.21 +2005.03.21
initrd          /initrd.img-2.6.8+2005.03.21
savedefault
boot

The kernel option should be `root=3D/dev/hda8 ro', not `+2005.03.21'.
This happens because update-grub stores options for each kernel in a
shell variable named `kopt_<ver>', where <ver> is the version string.
Reference to $kopt_+2005.03.21 is interpreted as an unbound variable
(kopt_) and the string '+2005.03.21' (see get_kernel_opt()).

I think deprecating `+' would do just fine, unless there's an
important reason to do otherwise.


diff -ur org.kernel-package-8.125/make-kpkg kernel-package-8.125/make-kpk=
g
--- org.kernel-package-8.125/make-kpkg  2005-03-23 23:17:34.000000000 -080=
0
+++ kernel-package-8.125/make-kpkg      2005-03-23 23:04:28.000000000 -0800
@@ -147,8 +147,8 @@
 component of the kernel version, it is also added to the Debian
 package name, and, as such must obey the policy governing the package
 name. That means it may contain only B<lowercase> alphanumerics and
-the characters - + . (full stop, hyphen, and plus). Uppercase letters
-are not permitted under the Policy for a new package.
+the characters - . (full stop and hyphen). Uppercase letters are not
+permitted under the Policy for a new package.
=20
 Please note that you must run a B<make-kpkg clean> after configuring
 the kernel using make (x|menu)?config, since that creates
@@ -164,9 +164,9 @@
 Sets the kernel flavour to the argument B<foo>. The flavour is also
 appended to the package name. You need a patched Makefile to make this
 work properly (see /usr/share/doc/kernel-package/Flavours.gz).  It may
-contain only B<lowercase> alphanumerics and the characters - + . (full
-stop, hyphen, and plus). Uppercase letters are not permitted under the
-Policy for a new package. B<NOTE>: Hyphens are discouraged.  (Look at
+contain only B<lowercase> alphanumerics and the characters - . (full
+stop and hyphen). Uppercase letters are not permitted under the Policy
+for a new package. B<NOTE>: Hyphens are discouraged.  (Look at
 Chapters 4 of the Policy manual for details).
=20
=20
@@ -911,9 +911,9 @@
   }
=20
   if ($append_to_version){
-    if ($append_to_version !~ m/^[a-z\d\.\-\+]+$/o) {
+    if ($append_to_version !~ m/^[a-z\d\.\-]+$/o) {
       print STDERR " Error: The extended version may only contain\n";
-      print STDERR " lowercase alphanumerics and  the  characters  - +  =
.\n";
+      print STDERR " lowercase alphanumerics and  the  characters  - .\n=
";
       print STDERR " The current value is: $append_to_version\n";
       print STDERR " Aborting.\n";
       exit 1;
diff -ur org.kernel-package-8.125/make-kpkg.8 kernel-package-8.125/make-k=
pkg.8
--- org.kernel-package-8.125/make-kpkg.8        2005-03-23 23:17:34.000000000 
-0=
800
+++ kernel-package-8.125/make-kpkg.8    2005-03-24 19:39:50.040284616 -0800
@@ -131,9 +131,9 @@
 must obey the policy governing the package name. That means it may
 contain only=20
 .B  lowercase
-alphanumerics and the characters - + . (full stop, hyphen, and
-plus). Uppercase letters are not permitted under the Policy for a new
-package.  If the environment variable
+alphanumerics and the characters - . (full stop and hyphen). Uppercase
+letters are not permitted under the Policy for a new package.  If the
+environment variable
 .B IGNORE_UPPERCASE_VERSION
 is set, make-kpkg shall lower case version numbers set in the Makefile
 or in the=20
diff -ur org.kernel-package-8.125/make-kpkg.es.8 kernel-package-8.125/mak=
e-kpkg.es.8
--- org.kernel-package-8.125/make-kpkg.es.8     2005-03-23 23:17:34.000000000=
 -0800
+++ kernel-package-8.125/make-kpkg.es.8 2005-03-24 19:42:21.947191256 -08=
00
@@ -131,8 +131,8 @@
 que est=E1n sujetos los nombres de los paquetes Debian. Esto quiere deci=
r que s=F3lo
 puede contener caracteres alfanum=E9ricos en
 .B  min=FAsculas
-y los caracteres \- + . (gui=F3n, signo m=E1s y punto). Las Normas no pe=
rmiten
-letras may=FAsculas en los paquetes nuevos. Si la variable de entorno
+y los caracteres \- . (gui=F3n y punto). Las Normas no permiten letras
+may=FAsculas en los paquetes nuevos. Si la variable de entorno
 .B IGNORE_UPPERCASE_VERSION
 est=E1 establecida, make-kpkg pasar=E1 a min=FAsculas los n=FAmeros de v=
ersi=F3n en el
 Makefile o en el fichero
diff -ur org.kernel-package-8.125/make-kpkg.fr.8 kernel-package-8.125/mak=
e-kpkg.fr.8
--- org.kernel-package-8.125/make-kpkg.fr.8     2005-03-23 23:17:34.000000000=
 -0800
+++ kernel-package-8.125/make-kpkg.fr.8 2005-03-24 19:46:12.856087768 -08=
00
@@ -133,7 +133,7 @@
 aux contraintes de la charte concernant les noms de paquets. Ce qui veut=
 dire
 qu'il ne doit contenir que des caract=E8res alphanum=E9riques=20
 .B  minuscules
-et les caract=E8res -, + et . (trait d'union, plus et point). Les lettre=
s
+et les caract=E8res - et . (trait d'union et point). Les lettres
 majuscules ne sont pas autoris=E9es par la Charte pour un nouveau paquet=
. Si la=20
 variable d'environnement=20
 .B IGNORE_UPPERCASE_VERSION



-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.8.2005.03.21
Locale: LANG=3Dja_JP.eucJP, LC_CTYPE=3Dja_JP.eucJP (charmap=3DEUC-JP) (ig=
nored: LC_ALL set to ja_JP.eucJP)

Versions of packages kernel-package depends on:
ii  altgcc [c-compiler]          1:2.7.2.3-2 Alternate gcc package for th=
e libc
ii  dpkg                         1.10.27     Package maintenance system f=
or Deb
ii  dpkg-dev                     1.10.27     Package building tools for D=
ebian
ii  gcc [c-compiler]             4:3.3.5-1   The GNU C compiler
ii  gcc-3.3 [c-compiler]         1:3.3.5-8   The GNU C compiler
ii  gcc-3.4 [c-compiler]         3.4.3-6     The GNU C compiler
ii  make                         3.80-9      The GNU version of the "make=
" util
ii  perl                         5.8.4-8     Larry Wall's Practical Extra=
ction=20

-- no debconf information

---------------------------------------
Received: (at 301313-done) by bugs.debian.org; 29 Mar 2005 00:40:49 +0000
>From [EMAIL PROTECTED] Mon Mar 28 16:40:49 2005
Return-path: <[EMAIL PROTECTED]>
Received: from smtp9.wanadoo.fr [193.252.22.22] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DG4mn-0000IB-00; Mon, 28 Mar 2005 16:40:49 -0800
Received: from me-wanadoo.net (localhost [127.0.0.1])
        by mwinf0904.wanadoo.fr (SMTP Server) with ESMTP id 4FB8A24001A0
        for <[EMAIL PROTECTED]>; Tue, 29 Mar 2005 02:40:18 +0200 (CEST)
Received: from argos.server.maison 
(AToulouse-152-1-46-163.w82-125.abo.wanadoo.fr [82.125.156.163])
        by mwinf0904.wanadoo.fr (SMTP Server) with ESMTP id 2E4B4240019D
        for <[EMAIL PROTECTED]>; Tue, 29 Mar 2005 02:40:18 +0200 (CEST)
X-ME-UUID: [EMAIL PROTECTED]
Received: from prahal by argos.server.maison with local (Exim 4.50)
        id 1DG4mJ-00089i-0k
        for [EMAIL PROTECTED]; Tue, 29 Mar 2005 02:40:19 +0200
Date: Tue, 29 Mar 2005 02:40:19 +0200
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: Re: Bug #301313 - kernel-package: Plus sign in appended version breaks 
menu.lst
Message-ID: <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Sender: [EMAIL PROTECTED]
User-Agent: Mutt/1.5.8i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-1.4 required=4.0 tests=BAYES_00,NO_REAL_NAME 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

This is a followup for bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=301313

the problem was already reported in :
update-grub generates wrong automagic entries if the name of the
kernel contains a "+" :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=299528

the problem with + in kernel name was fixed in unstable  and should
 be available in testing soon.

Regards
Alban


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to