Your message dated Sat, 02 Apr 2005 17:33:10 -0500
with message-id <[EMAIL PROTECTED]>
and subject line Bug#300945: fixed in romeo 0.5.0-6
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 22 Mar 2005 20:29:13 +0000
>From [EMAIL PROTECTED] Tue Mar 22 12:29:13 2005
Return-path: <[EMAIL PROTECTED]>
Received: from c223012.adsl.hansenet.de (localhost.localdomain) [213.39.223.12]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DDq00-000757-00; Tue, 22 Mar 2005 12:29:13 -0800
Received: from aj by localhost.localdomain with local (Exim 4.44)
id 1DDpzz-000366-8k; Tue, 22 Mar 2005 21:29:11 +0100
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
From: Andreas Jochens <[EMAIL PROTECTED]>
Subject: romeo: FTBFS (amd64/gcc-4.0): invalid lvalue in assignment
Message-Id: <[EMAIL PROTECTED]>
Date: Tue, 22 Mar 2005 21:29:11 +0100
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: romeo
Severity: normal
Tags: patch
When building 'romeo' on amd64 with gcc-4.0,
I get the following error:
assemble.c:581: error: invalid lvalue in assignment
assemble.c: In function 'MergeIfAdjacent':
assemble.c:645: error: invalid lvalue in assignment
assemble.c:647: error: invalid lvalue in assignment
assemble.c:649: error: invalid lvalue in assignment
assemble.c: In function 'ROMfree':
assemble.c:710: error: invalid lvalue in assignment
assemble.c:720: error: invalid lvalue in assignment
assemble.c:744: error: invalid lvalue in assignment
assemble.c:745: error: invalid lvalue in assignment
assemble.c: In function 'CompareTypeCtor':
assemble.c:1420: warning: pointer targets in passing argument 1 of 'strncmp'
differ in signedness
assemble.c:1420: warning: pointer targets in passing argument 2 of 'strncmp'
differ in signedness
assemble.c: In function 'SetSystem':
assemble.c:1504: warning: pointer targets in initialization differ in signedness
assemble.c:1597: warning: pointer targets in passing argument 1 of 'strlen'
differ in signedness
assemble.c:1606: warning: pointer targets in passing argument 1 of 'strlen'
differ in signedness
make[1]: *** [assemble.o] Error 1
make[1]: Leaving directory `/romeo-0.5.0'
make: *** [build-stamp] Error 2
With the attached patch 'romeo' can be compiled
on amd64 using gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/romeo-0.5.0/MemoryPrv.h ./MemoryPrv.h
--- ../tmp-orig/romeo-0.5.0/MemoryPrv.h 2001-03-17 02:27:51.000000000 +0100
+++ ./MemoryPrv.h 2005-03-22 21:26:00.407687297 +0100
@@ -311,6 +311,11 @@
#define memUHeapSize(p,ver) \
(ver>2 ? ((MemHeapHeaderPtr)p)->size : (ver>1 ?
((Mem2HeapHeaderPtr)p)->size : ((Mem1HeapHeaderPtr)p)->size))
+#define memUHeapSizeSet(p,ver,Size) \
+ if (ver>2) ((MemHeapHeaderPtr )p)->size = Size; \
+ else if (ver>1) ((Mem2HeapHeaderPtr)p)->size = Size; \
+ else ((Mem1HeapHeaderPtr)p)->size = Size
+
#define memUHeapFlags(p) \
(((MemHeapHeaderPtr)p)->flags)
@@ -340,6 +345,10 @@
#define memUChunkSize(p,ver) \
(ver>1 ? ((MemChunkHeaderPtr)p)->size : ((Mem1ChunkHeaderPtr)p)->size)
+#define memUChunkSizeSet(p,ver,Size) \
+ if (ver>1) ((MemChunkHeaderPtr)p)->size = Size; \
+ else ((Mem1ChunkHeaderPtr)p)->size = Size
+
#define memUChunkFlags(p,ver) \
(ver>1 ? memChunkFlags(p) : ((Mem1ChunkHeaderPtr)p)->flags & 0xF0)
@@ -355,6 +364,10 @@
#define memUChunkHOffset(p,ver) \
(ver>1 ? ((MemChunkHeaderPtr)p)->hOffset :
((Mem1ChunkHeaderPtr)p)->hOffset)
+#define memUChunkHOffsetSet(p,ver,Offset) \
+ if (ver>1) ((MemChunkHeaderPtr )p)->hOffset = Offset; \
+ else ((Mem1ChunkHeaderPtr)p)->hOffset = Offset
+
diff -urN ../tmp-orig/romeo-0.5.0/assemble.c ./assemble.c
--- ../tmp-orig/romeo-0.5.0/assemble.c 2001-03-17 02:27:57.000000000 +0100
+++ ./assemble.c 2005-03-22 21:27:31.906082885 +0100
@@ -61,7 +61,7 @@
// Initialize this entire heap to 0.
memset (hdr, 0, size); //memUSizeOfHeapHeader(ver));
- memUHeapSize (hdr, ver) = size;
+ memUHeapSizeSet(hdr, ver, size);
memUHeapFlags(hdr) |= memHeapFlagReadOnly;
switch (ver)
@@ -87,7 +87,7 @@
memUSizeOfHeapTerminator(ver));
if (ver > 2)
{
- memUChunkHOffset(pChunk, chunkVer) = memUChunkSize(pChunk,
chunkVer) >> 1;
+ memUChunkHOffsetSet(pChunk, chunkVer, memUChunkSize(pChunk,
chunkVer) >> 1);
}
}
@@ -556,8 +556,8 @@
{
// Only update the hOffset (pointer to next free chunk) if
// the hOffset of the old free chunk was set.
- memUChunkHOffset(newFree, ver) = memUChunkHOffset(oldFree, ver)
-
- ((roundedSize +
memUSizeOfChunkHeader(ver)) >>1);
+ memUChunkHOffsetSet(newFree, ver, memUChunkHOffset(oldFree,
ver) -
+ ((roundedSize +
memUSizeOfChunkHeader(ver)) >>1));
}
@@ -576,9 +576,9 @@
{
// The previous free chunk now needs to point to the new free
chunk.
if (newsize)
- memUChunkHOffset(prevFree, ver) = ((UInt32)newFree -
(UInt32)prevFree) >> 1;
+ memUChunkHOffsetSet(prevFree, ver, ((UInt32)newFree -
(UInt32)prevFree) >> 1);
else
- memUChunkHOffset(prevFree, ver) +=
memUChunkHOffset(oldFree,ver);
+ memUChunkHOffsetSet(prevFree, ver,
memUChunkHOffset(prevFree, ver) + memUChunkHOffset(oldFree,ver));
}
@@ -642,11 +642,11 @@
{
/* Free, contiguous and neither are terminators */
if (memUChunkHOffset(pSecond,ver) != 0)
- memUChunkHOffset(pFirst,ver) +=
memUChunkHOffset(pSecond,ver);
+ memUChunkHOffsetSet(pFirst,ver,
memUChunkHOffset(pFirst,ver) + memUChunkHOffset(pSecond,ver));
else
- memUChunkHOffset(pFirst,ver) = 0;
+ memUChunkHOffsetSet(pFirst,ver, 0);
- memUChunkSize(pFirst,ver) += memUChunkSize(pSecond,ver);
+ memUChunkSizeSet(pFirst,ver,memUChunkSize(pFirst,ver) +
memUChunkSize(pSecond,ver));
return (1);
}
@@ -706,18 +706,18 @@
{
// This new free chunk will be the first one on the free list.
if (pFreeChunk)
- memUChunkHOffset(pChunk,chunkVer) = ((UInt32)pFreeChunk
- (UInt32)pChunk)
-
>> 1;
+ memUChunkHOffsetSet(pChunk,chunkVer,((UInt32)pFreeChunk
- (UInt32)pChunk)
+
>> 1);
if (heapVer > 2)
{
if (! pFreeChunk)
// In version 3 and above, the final free chunk
points
// to the heap terminator.
- memUChunkHOffset(pChunk,chunkVer) =
((UInt32)pHeap +
+ memUChunkHOffsetSet(pChunk,chunkVer,
((UInt32)pHeap +
memUHeapSize(pHeap, heapVer) -
memUSizeOfHeapTerminator(chunkVer) -
-
(UInt32)pChunk) >> 1;
+
(UInt32)pChunk) >> 1);
pHeap->header.ver3.firstFreeChunkOffset =
((UInt32)pChunk - (UInt32)pHeap)>>1;
}
@@ -741,8 +741,8 @@
hOffset =
((UInt32)memUChunkNextFree(pFreeChunk,chunkVer) - (UInt32)pChunk)
>> 1;
- memUChunkHOffset(pChunk, chunkVer) = hOffset;
- memUChunkHOffset(pFreeChunk,chunkVer) = ((UInt32)pChunk -
(UInt32)pFreeChunk)>>1;
+ memUChunkHOffsetSet(pChunk, chunkVer, hOffset);
+ memUChunkHOffsetSet(pFreeChunk,chunkVer, ((UInt32)pChunk -
(UInt32)pFreeChunk)>>1);
}
MergeIfAdjacent(pChunk, memUChunkNextFree(pChunk,chunkVer), chunkVer);
---------------------------------------
Received: (at 300945-close) by bugs.debian.org; 2 Apr 2005 22:55:28 +0000
>From [EMAIL PROTECTED] Sat Apr 02 14:55:27 2005
Return-path: <[EMAIL PROTECTED]>
Received: from gluck.debian.org [192.25.206.10]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DHrWZ-0001np-00; Sat, 02 Apr 2005 14:55:27 -0800
Received: from newraff.debian.org [208.185.25.31] (mail)
by gluck.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DHrWZ-00005g-00; Sat, 02 Apr 2005 15:55:27 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DHrB0-0002wS-00; Sat, 02 Apr 2005 17:33:10 -0500
From: Shaun Jackman <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#300945: fixed in romeo 0.5.0-6
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 02 Apr 2005 17:33:10 -0500
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: romeo
Source-Version: 0.5.0-6
We believe that the bug you reported is fixed in the latest version of
romeo, which is due to be installed in the Debian FTP archive:
romeo_0.5.0-6.diff.gz
to pool/main/r/romeo/romeo_0.5.0-6.diff.gz
romeo_0.5.0-6.dsc
to pool/main/r/romeo/romeo_0.5.0-6.dsc
romeo_0.5.0-6_i386.deb
to pool/main/r/romeo/romeo_0.5.0-6_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Shaun Jackman <[EMAIL PROTECTED]> (supplier of updated romeo package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 2 Apr 2005 14:09:55 -0800
Source: romeo
Binary: romeo
Architecture: source i386
Version: 0.5.0-6
Distribution: unstable
Urgency: low
Maintainer: Shaun Jackman <[EMAIL PROTECTED]>
Changed-By: Shaun Jackman <[EMAIL PROTECTED]>
Description:
romeo - Palm ROM Discombobulator
Closes: 300945
Changes:
romeo (0.5.0-6) unstable; urgency=low
.
* Fix build on amd64 with gcc-4.0 (closes: #300945).
Files:
13055159b74470173370c9af4501e857 557 otherosfs extra romeo_0.5.0-6.dsc
45c73d44405c0d8414a49935d71b2c75 10250 otherosfs extra romeo_0.5.0-6.diff.gz
2f00be3ba673ec9823d708fe103553d7 39412 otherosfs extra romeo_0.5.0-6_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFCTxpuvFdYF1IwUUoRAmPpAKDe100BLjEqMWwf4KKvix9ugTK7mACgrqVZ
RdzkpJ04i5SwTpREj2YQplY=
=R7pK
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
