Your message dated Thu, 18 Jan 2007 23:17:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#406250: fixed in exim4 4.66-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: lintian,at,exim4,initscripts,udev,gdm
# Clone+Reassign soon
These packages all ignore errors from (invoke|update)-rc.d.
The History
===========
Due to debhelper bug #337664, dh_installinit inserted calls to packages
maintainer scripts which had "|| exit 0" rather than "|| exit $?" (due to
insufficient escaping). The original intent (I assume) is to exit if the
program fails, even if the maintainer hasn't made the script set -e. lintian
now includes a check for this, as requested in #358523 (but lintian.d.o isn't
yet updated to a sufficiently recent version).
The Problem
===========
I suspect that maintainers of packages which contain initscripts but don't use
dh_installinit have copied from debhelper, and now also include the broken
error checking code. Lintian might not be able to find all the
problems, either, since some use "|| true" or "|| :" instead.
Proposal
========
The general problem is covered by policy, which requires all scripts to either
run set -e, or to test the exit status of every command. || true shouldn't be
widely allowed, perhaps this could be expressed as foo || [ $? -ne 0 ], which
accomplishes the same, but indicates to lintian that the exit status is
actually checked. (And the extra crud is reasonable to discourage people from
using it...) Proper error checking in subshells should also be tested.
I propose that lintian detect this as a special case, and trigger the same or
comparable warning as for the debhelper bug. (Ideally, I know that lintian
would grok Bourne).
It isn't clear to me that any of the following have a special reason for
ignoring errors, though exim4-daemon-light comments on the need for
it...
[EMAIL PROTECTED]:/var/lib/dpkg/info$ grep -rE
'(invoke|update)-rc\.d\b.*\|\|.*(true|:)' .
./at.prerm: invoke-rc.d atd stop || true
./exim4-config.postinst: invoke-rc.d exim4 restart ||
true
./initscripts.postinst: update-rc.d -f single remove >/dev/null 2>&1 || :
./initscripts.postinst: update-rc.d -f mtab.sh remove >/dev/null 2>&1 || :
./initscripts.postinst: update-rc.d -f hostname.sh remove >/dev/null 2>&1 || :
./initscripts.postinst: update-rc.d -f sendsigs remove >/dev/null 2>&1 || :
./initscripts.postinst: update-rc.d $F remove >/dev/null 2>&1 || :
./initscripts.postinst:# invoke-rc.d mountkernfs.sh start || :
./exim4-daemon-light.postinst: invoke-rc.d exim4 start ||
invoke-rc.d exim4 reload || true
./udev.postinst: [ -x /etc/init.d/$script ] && invoke-rc.d $script restart
|| true
./gdm.postinst: invoke-rc.d gdm reload || true
--- End Message ---
--- Begin Message ---
Source: exim4
Source-Version: 4.66-2
We believe that the bug you reported is fixed in the latest version of
exim4, which is due to be installed in the Debian FTP archive:
exim4-base_4.66-2_i386.deb
to pool/main/e/exim4/exim4-base_4.66-2_i386.deb
exim4-config_4.66-2_all.deb
to pool/main/e/exim4/exim4-config_4.66-2_all.deb
exim4-daemon-heavy-dbg_4.66-2_i386.deb
to pool/main/e/exim4/exim4-daemon-heavy-dbg_4.66-2_i386.deb
exim4-daemon-heavy_4.66-2_i386.deb
to pool/main/e/exim4/exim4-daemon-heavy_4.66-2_i386.deb
exim4-daemon-light-dbg_4.66-2_i386.deb
to pool/main/e/exim4/exim4-daemon-light-dbg_4.66-2_i386.deb
exim4-daemon-light_4.66-2_i386.deb
to pool/main/e/exim4/exim4-daemon-light_4.66-2_i386.deb
exim4-dbg_4.66-2_i386.deb
to pool/main/e/exim4/exim4-dbg_4.66-2_i386.deb
exim4-dev_4.66-2_i386.deb
to pool/main/e/exim4/exim4-dev_4.66-2_i386.deb
exim4_4.66-2.diff.gz
to pool/main/e/exim4/exim4_4.66-2.diff.gz
exim4_4.66-2.dsc
to pool/main/e/exim4/exim4_4.66-2.dsc
exim4_4.66-2_all.deb
to pool/main/e/exim4/exim4_4.66-2_all.deb
eximon4_4.66-2_i386.deb
to pool/main/e/exim4/eximon4_4.66-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Marc Haber <[EMAIL PROTECTED]> (supplier of updated exim4 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 18 Jan 2007 20:50:06 +0100
Source: exim4
Binary: exim4-daemon-light-dbg exim4-daemon-custom exim4-daemon-heavy exim4-dbg
exim4-daemon-heavy-dbg exim4-config exim4-daemon-custom-dbg eximon4 exim4-base
exim4 exim4-dev exim4-daemon-light
Architecture: source i386 all
Version: 4.66-2
Distribution: experimental
Urgency: low
Maintainer: Exim4 Maintainers <[EMAIL PROTECTED]>
Changed-By: Marc Haber <[EMAIL PROTECTED]>
Description:
exim4 - metapackage to ease exim MTA (v4) installation
exim4-base - support files for all exim MTA (v4) packages
exim4-config - configuration for the exim MTA (v4)
exim4-daemon-heavy - exim MTA (v4) daemon with extended features, including
exiscan-ac
exim4-daemon-heavy-dbg - debugging symbols for the exim MTA (v4) packages
exim4-daemon-light - lightweight exim MTA (v4) daemon
exim4-daemon-light-dbg - debugging symbols for the exim MTA (v4) packages
exim4-dbg - debugging symbols for the exim MTA (v4) packages
exim4-dev - header files for the exim MTA (v4) packages
eximon4 - monitor application for the exim MTA (v4) (X11 interface)
Closes: 403583 406250 406686 406989
Changes:
exim4 (4.66-2) experimental; urgency=low
.
* replace ` with $() in most scripts
* only ignore invoke-rc.d return value if configtype none.
Thanks to Justin Pryzby. Closes: #406250
* merge trunk changes:
* exim4_refresh_gnutls-params: allow EXIM4_SPOOLDIR to be overridden from
the environment. Closes: #406989
* Re-work client authenticators to handle passwords containing
colons and circumflexes. Thanks to Steaphan Greene. Closes: #406686
* transport/30_exim4-config_remote_smtp_smarthost: feed
hosts_try_auth from $host and $host_address, avoiding issues with
round-robin DNS setup.
Thanks to Celejar and Heiko Schlittermann. Closes: #403583
Files:
c03f3d7b389af8d9bcb5e68a937c0dee 1169 mail standard exim4_4.66-2.dsc
76281bdcc1199573c66f2ca2d50803ef 547270 mail standard exim4_4.66-2.diff.gz
42fc32243e086386eff14875861f8ba6 961282 mail standard
exim4-base_4.66-2_i386.deb
ed2eca18049895e35a200e29311d3dca 93846 mail optional eximon4_4.66-2_i386.deb
01d8544e8ceeea392890b067ac328cab 417850 mail standard
exim4-daemon-light_4.66-2_i386.deb
0cc872c852317340ecd13fcf80e04c21 472866 mail optional
exim4-daemon-heavy_4.66-2_i386.deb
f56e1547d1a13a156a5221ad024ff5a1 623922 mail extra
exim4-daemon-light-dbg_4.66-2_i386.deb
608b38b3fe5b42c8c450f932babed2ac 707410 mail extra
exim4-daemon-heavy-dbg_4.66-2_i386.deb
9da60cc4c5017e314f2e7a224adba05b 243074 mail extra exim4-dbg_4.66-2_i386.deb
03f17fe9b35c278a328e6b6c1b2ee7d1 61352 mail extra exim4-dev_4.66-2_i386.deb
b95193352f56d09502454678def34ff3 334308 mail standard
exim4-config_4.66-2_all.deb
d1c3ed20913f31c9ce06cbad61c6cfcd 2080 mail standard exim4_4.66-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFFr/y2gZalRGu6PIQRApUjAJ4hDIEpz8NyR3ocf2LeUMzshG2i+QCgnmXo
4lWPXHh7BBKuLJvVOYVWzCU=
=XWfV
-----END PGP SIGNATURE-----
--- End Message ---
