Your message dated Sat, 27 Jan 2007 10:32:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#406266: fixed in debsums 2.0.31
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: debsums
Version: 2.0.16
Severity: minor
Tags: patch
After a "run fsck manually" episode, I knew I'd need to reinstall some
packages. I ran debsums to get a quick listing of what packages were messed
up. But it wasn't quick at all. It sat there for a long time not producing
output. Eventually I dceided something was wrong. It wasn't using any CPU and
the disk wasn't busy, and I knew debsums wouldn't normally take this long.
fsck had fixed several files, and one of them got "fixed" real good - it went
from being a normal boring man page to being a named pipe (prwS--S-wT or some
such nonsense). debsums was blocked trying to open it because, as you might
expect, there were no writers. I wouldn't have figured this out if it hadn't
been for strace -p `pidof debsums`
In case this happens to anyone else, I suggest that debsums should either
use a non-blocking open or stat the file before opening to make sure it's a
regular file. Named pipe isn't the worst case. It could have been a block or
character device with unpleasant side effects on being opened (and read, if
the open succeeded).
Here's a patch that does stat-before-open.
--- debsums.orig 2007-01-09 17:05:41.000000000 -0500
+++ debsums 2007-01-09 17:05:44.000000000 -0500
@@ -234,6 +234,12 @@
$path = $diversion{$path}[0] if exists $diversion{$path}
and $diversion{$path}[1] ne $pack;
+ if (-e "$root/$path" && !-f _)
+ {
+ warn "$self: not regular file: $pack file $root/$path\n";
+ return 0;
+ }
+
unless (open F, "$root/$path")
{
return 0 if $localepurge
-- System Information:
Debian Release: 3.1
Architecture: powerpc (ppc)
Kernel: Linux 2.6.17.6
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages debsums depends on:
ii debconf [debconf-2.0] 1.4.30.13 Debian configuration management sy
ii perl 5.8.4-8sarge5 Larry Wall's Practical Extraction
-- debconf information:
debsums/apt-autogen: true
--- End Message ---
--- Begin Message ---
Source: debsums
Source-Version: 2.0.31
We believe that the bug you reported is fixed in the latest version of
debsums, which is due to be installed in the Debian FTP archive:
debsums_2.0.31.dsc
to pool/main/d/debsums/debsums_2.0.31.dsc
debsums_2.0.31.tar.gz
to pool/main/d/debsums/debsums_2.0.31.tar.gz
debsums_2.0.31_all.deb
to pool/main/d/debsums/debsums_2.0.31_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Brendan O'Dea <[EMAIL PROTECTED]> (supplier of updated debsums package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 27 Jan 2007 21:08:30 +1100
Source: debsums
Binary: debsums
Architecture: source all
Version: 2.0.31
Distribution: unstable
Urgency: low
Maintainer: Brendan O'Dea <[EMAIL PROTECTED]>
Changed-By: Brendan O'Dea <[EMAIL PROTECTED]>
Description:
debsums - Verify installed package files against MD5 checksums.
Closes: 406266
Changes:
debsums (2.0.31) unstable; urgency=low
.
* More paranoia: open files non-blocking (closes: #406266).
Files:
f8bf672acd2cb17f8b20829eef72bc6b 496 admin optional debsums_2.0.31.dsc
cf3beb21d912925d071d768fccd8aed9 34399 admin optional debsums_2.0.31.tar.gz
00bf8daf310d5acb28ae12f03abde811 30704 admin optional debsums_2.0.31_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFFuyiE8NyOALKMWZURAvc0AJ9Nu8Mu1ruWzDEQinB+II1Q6FFuVACeKqQf
Mye9lPgxgyVK7gK3M5jgMFU=
=N7yG
-----END PGP SIGNATURE-----
--- End Message ---
