Your message dated Wed, 14 Feb 2007 16:20:20 +0100
with message-id <[EMAIL PROTECTED]>
and subject line mutt/1779: warning: passing arg 1 of `safe_free' makes pointer
from integer without a cast.
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: mutt
Severity: normal
Hi,
you are trying to misuse a long to store pointers into memory and to
free them later (e.g. init.c:922, init.c:951). The problem is the
following struct:
struct option_t
{
char *option;
short type;
short flags;
unsigned long data;
unsigned long init; /* initial value */
};
You should no rely on unsigned long being large enough to hold a
pointer. The C99 standard defines intptr_t and uintptr_t if you realy
need an integer type there, which you should cast to pointer before
using it as one. Otherwise I suggest using an
union {
unsigned long data;
void* data_ptr;
}
which would be the only clean way to do this in traditional C.
Seeing a _safe_ function getting called with such an insecure cast
warning is a bit of an oximoron.
MfG
Goswin
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux dual 2.4.23dual #1 SMP Sun Dec 14 13:57:16 CET 2003 i686
Locale: LANG=C, LC_CTYPE=de_DE
--- End Message ---
--- Begin Message ---
Version: 1.5.3-1
Re: Paul Walker 2006-03-25 <[EMAIL PROTECTED]>
> Synopsis: warning: passing arg 1 of `safe_free' makes pointer from integer
> without a cast.
>
> State-Changed-From-To: open->closed
> State-Changed-By: paul
> State-Changed-When: Sat, 25 Mar 2006 00:22:50 +0100
> State-Changed-Why:
> Patch was applied (according to Debian bug log). gcc now
> emits no significant warnings when building mutt, even with
> -pedantic. Tested building with --std=c99 just to be sure,
> same thing. Visual check can't see the lines the submitter
> was complaining about.
>
> (Please re-open if I've missed an instance.)
Christoph
--
[EMAIL PROTECTED] | http://www.df7cb.de/
signature.asc
Description: Digital signature
--- End Message ---
