Your message dated Tue, 24 Apr 2007 11:50:21 +0200 with message-id <[EMAIL PROTECTED]> and subject line Bug#310413: This bug...is not a bug has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: samba Version: 3.0.14a-2 Severity: normal Tags: patch The "delete veto files" is broken since Samba 3.0.12. Deleting a directory containing only veto files returns NT_STATUS_DIRECTORY_NOT_EMPTY instead of deleting all veto files/directories. This seems to be caused by an error in source/smbd/reply.c in rmdir_internals. The variable dirpos gets changed by the first ReadDirName() and will not rewind the dir handle in SeekDir() afterwards. The following patch corrects the problem: --- samba-3.0.14a/source/smbd/reply.c 2005-04-14 06:14:20.000000000 +0000 +++ samba-3.0.14a_test/source/smbd/reply.c 2005-05-23 12:34:54.933365288 +0000 @@ -3462,7 +3462,8 @@ if(dir_hnd != NULL) { long dirpos = TellDir(dir_hnd); - while ((dname = ReadDirName(dir_hnd,&dirpos))) { + long dirtemp=dirpos; + while ((dname = ReadDirName(dir_hnd,&dirtemp))) { if((strcmp(dname, ".") == 0) || (strcmp(dname, "..")==0)) continue; if (!is_visible_file(conn, directory, dname, &st, False)) -- System Information: Debian Release: 3.1 APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.8-2-686 Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15) (ignored: LC_ALL set to [EMAIL PROTECTED]) Versions of packages samba depends on: ii debconf [debconf-2.0] 1.4.30.13 Debian configuration management sy ii libacl1 2.2.23-1 Access control list shared library ii libc6 2.3.2.ds1-21 GNU C Library: Shared libraries an ii libcomerr2 1.37-2 common error description library ii libcupsys2-gnutls10 1.1.23-10 Common UNIX Printing System(tm) - ii libkrb53 1.3.6-2 MIT Kerberos runtime libraries ii libldap2 2.1.30-6 OpenLDAP libraries ii libpam-modules 0.76-22 Pluggable Authentication Modules f ii libpam-runtime 0.76-22 Runtime support for the PAM librar ii libpam0g 0.76-22 Pluggable Authentication Modules l ii logrotate 3.7-2 Log rotation utility ii netbase 4.21 Basic TCP/IP networking system ii samba-common 3.0.14a-2 Samba common files used by both th -- debconf information: samba/nmbd_from_inetd: * samba/run_mode: daemons * samba/log_files_moved: * samba/tdbsam: true * samba/generate_smbpasswd: false
--- End Message ---
--- Begin Message ---Version: 3.0.24-6 Quoting Christian Perrier ([EMAIL PROTECTED]): > The bug submitter said: > > The "delete veto files" is broken since Samba 3.0.12. > Deleting a directory containing only veto files returns > NT_STATUS_DIRECTORY_NOT_EMPTY instead of deleting all veto files/directories. > > > Apparently, this changed....but now, the directory is > deleted...whatever the "delete veto files" setting is: After reporting to upstream, Jeremy Allison sent that clear explanation (thanks, Jeremy, and apologies for wasting you time): Actually, it's behaving to spec. See the man page in smb.conf : delete veto files (S) .../... This option only has meaning if the veto'd object is a *directory*, not a file. So if you do the following : mkdir bar mkdir bar/notseen.tmp echo foo >bar/notseen.tmp/foo.tmp Then bar will not be deleted. So, I'm hereby closing the Debian bug report as the original bug it describes has been fixed a while ago and "delete veto files" works as expected.
signature.asc
Description: Digital signature
--- End Message ---
