Your message dated Mon, 04 Jun 2007 10:32:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#348985: fixed in apt-proxy 1.9.36
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: apt-proxy
Version: 1.9.32
Severity: normal


somewhere along the line apt-proxy stopped handling ftp
username/password correctly and was leaving the '@' symbol on the start
of the host name.


Below is a copy of the error from the logs and two patches.

There are two patches as I'm not really a python programmer and not really sure 
which way is best.
I like the first one my self since it uses one less function call.

--- apt_proxy.py.orig   2005-08-20 03:15:20.000000000 +1000
+++ apt_proxy.py        2006-01-20 19:52:58.000000000 +1100
@@ -1305,8 +1305,7 @@
                      query, fragment = urlparse.urlparse(uri)
 
         if '@' in netloc:
-            auth = netloc[:netloc.rindex('@')]
-            netloc = netloc[netloc.rindex('@'):]
+            auth, netloc = netloc.split('@')
             self.username, self.password = auth.split(':')
         else:
             self.username = None




--- apt_proxy.py.orig   2005-08-20 03:15:20.000000000 +1000
+++ apt_proxy.py        2006-01-20 19:52:02.000000000 +1100
@@ -1306,7 +1306,7 @@
 
         if '@' in netloc:
             auth = netloc[:netloc.rindex('@')]
-            netloc = netloc[netloc.rindex('@'):]
+            netloc = netloc[netloc.rindex('@') + 1:]
             self.username, self.password = auth.split(':')
         else:
             self.username = None



006/01/20 19:33 EST [Channel,22,127.0.0.1] [Fetcher.activate] (debian) 
servers:1/debian/dists/sid/contrib/source/Sources.gz
2006/01/20 19:33 EST [Channel,22,127.0.0.1] Starting factory 
<twisted.internet.protocol._InstanceFactory instance at 0xb6c45fcc
>
2006/01/20 19:33 EST [-] Stopping factory 
<twisted.internet.protocol._InstanceFactory instance at 0xb6c45fcc>
2006/01/20 19:33 EST [-] [Fetcher] Connection Failed: [Failure instance: 
Traceback (failure with no frames): twisted.internet.e
rror.DNSLookupError: DNS lookup failed: address '@premium.planetmirror.com' not 
found: (-2, 'Name or service not known').
        ]
2006/01/20 19:33 EST [-] "[error] [debian] Connection Failed: 
/pub/debian/dists/sid/contrib/source/Sources.gz (DNS lookup faile
d: address '@premium.planetmirror.com' not found: (-2, 'Name or service not 
known').)"
2006/01/20 19:33 EST [-] [fetcher] no more Backends
2006/01/20 19:33 EST [-] [Fetcher] Finished receiving data, status:503 
saveData:0
2006/01/20 19:33 EST [-] [Fetcher] Last request removed
2006/01/20 19:33 EST [Channel,22,127.0.0.1] [debug] Client connection closed
2006/01/20 19:33 EST [Channel,22,127.0.0.1] Top 10:
2006/01/20 19:33 EST [Channel,22,127.0.0.1]        274 WeakKeyDictionary
2006/01/20 19:33 EST [Channel,22,127.0.0.1]        153 SelectReactor
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         90 Exception
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         76 DelayedCall
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         28 DBError
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         27 Deferred
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         26 Protocol
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         24 StandardError
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         24 ProtocolToConsumerAdapter
2006/01/20 19:33 EST [Channel,22,127.0.0.1]         17 Warning
2006/01/20 19:34 EST [-] [recycle] Pruning empty directory: 
/var/cache/apt-proxy/debian/dists/sid


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)


--- End Message ---
--- Begin Message ---
Source: apt-proxy
Source-Version: 1.9.36

We believe that the bug you reported is fixed in the latest version of
apt-proxy, which is due to be installed in the Debian FTP archive:

apt-proxy_1.9.36.dsc
  to pool/main/a/apt-proxy/apt-proxy_1.9.36.dsc
apt-proxy_1.9.36.tar.gz
  to pool/main/a/apt-proxy/apt-proxy_1.9.36.tar.gz
apt-proxy_1.9.36_all.deb
  to pool/main/a/apt-proxy/apt-proxy_1.9.36_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Halls <[EMAIL PROTECTED]> (supplier of updated apt-proxy package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 04 Jun 2007 11:06:08 +0100
Source: apt-proxy
Binary: apt-proxy
Architecture: source all
Version: 1.9.36
Distribution: unstable
Urgency: low
Maintainer: Chris Halls <[EMAIL PROTECTED]>
Changed-By: Chris Halls <[EMAIL PROTECTED]>
Description: 
 apt-proxy  - Debian archive proxy and partial mirror builder
Closes: 182855 266000 274679 303357 319005 322242 330492 348985 366262 382078 
386546 387243 393483 397399 397403 398217 404679
Changes: 
 apt-proxy (1.9.36) unstable; urgency=low
 .
   [ Chris Halls ]
   * Merge NMUs by Steinar H. Gunderson, Thomas Huriaux and Steve Langasek.
     Thanks guys! (Closes: #404679)
   * Close a longstanding bug where clients would hang when receiving
     files from the cache. The problem was caused by reusing the same
     file handle for several requests at once.
     (Closes: #274679, #382078, #322242, #397399, #397403, #398217)
   * Change the meaning of min_refresh_delay parameter, so the
     delay is measured from the modification time of the file on the
     backend instead of the time a client last requested this file.
     Now apt-proxy will always query backends when a file is too
     old (Closes: #266000)
   * Set process name to apt-proxy
   * Properly deal with escaped characters, including ~ in URLs on FTP
     backends. Unescape URLs and check for invalid characters when parsing
     a request. A big thanks to Ben Hutchings for the patch
     (Closes: #393483, #366262)
   * Fix [EMAIL PROTECTED] given in backend server URLs and add a test case.
     Thanks Jason Thomas for the patch (Closes: #348985)
   * Fix exception when sending ftp password to backend (Closes: #387243)
   * Remove extra '/' in HTTP GET requests (Closes: #330492)
   * Uncompress Packages.gz and Packages.bz2 on the fly, and
     update databases from these files (Closes: #319005, #303357)
   * Add unit tests for valid URLs containing /../ (Closes: #182855)
   * Remove obsolete GZipFetcher from fetchers.py
 .
   [ Mark Sheppard ]
   * Generate an error if a client attempts to retrieve
     http://server:9999/  (Closes: #386546)
   * When returning an error, generate an HTML page containing the error
Files: 
 a94c54a184f0e6d1ab2b9816df99b63a 726 admin extra apt-proxy_1.9.36.dsc
 a8b6cea540a9b0888dae5d2adad811ef 107319 admin extra apt-proxy_1.9.36.tar.gz
 db6c19bf0482c2a7cef6f9e562876b98 83942 admin extra apt-proxy_1.9.36_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGY+TKexmdExmX588RAti9AJ4xvPtmRRjc4PatmoSrr9DepsWTLwCffpqK
GpPMR+LAX33FZoHHqOsZF44=
=gVmq
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to