Your message dated Mon, 30 Jul 2007 12:17:22 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#192841: fixed in sysklogd 1.5-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: klogd
Version: 1.4.1
Severity: minor
Klogd will double '%' characters in its output. For example, I see
ICH2: not 100%% native mode: will probe irqs later
in my syslog instead of
ICH2: not 100% native mode: will probe irqs later
I believe this bug arose from the change made on 2000-09-12, which made
the change from 1998-01-25 unnecessary. Below are the relevant log
entries:
* Fri Jan 9 11:03:48 CET 1998: Martin Schulze <[EMAIL PROTECTED]>
* Corrected some code that caused klogd to dump core when
* receiving messages containing '%', some of them exist in
* 2.1.78. Thanks to Chu-yeon Park <[EMAIL PROTECTED]> for
* informing me.
* Sun Jan 25 20:47:46 CET 1998: Martin Schulze <[EMAIL PROTECTED]>
* As the bug covering the %'s introduced a problem with
* unevaluated priorities I've worked out a real fix that strips
* %'s to an even number which is harmless for printf.
* Tue Sep 12 22:14:33 CEST 2000: Martin Schulze <[EMAIL PROTECTED]>
* Don't feed a buffer directly to a printf-type routine, use
* "%s" as format string instead. Thanks to Jouko Pynnönen
* <[EMAIL PROTECTED]> for pointing this out.
I have created a patch, which simply removes the obsolete code. The diff
is attached.
Thanks,
Matthew*** sysklogd-1.4.1/klogd.c.orig Sun Mar 11 13:40:10 2001
--- sysklogd-1.4.1/klogd.c Fri Nov 15 14:52:41 2002
***************
*** 738,744 ****
switch( parse_state )
{
case PARSING_TEXT:
! delta = copyin( line, space, ptr, len, "\n[%" );
line += delta;
ptr += delta;
space -= delta;
--- 738,744 ----
switch( parse_state )
{
case PARSING_TEXT:
! delta = copyin( line, space, ptr, len, "\n[" );
line += delta;
ptr += delta;
space -= delta;
***************
*** 794,823 ****
parse_state = PARSING_SYMSTART; /* at < */
break;
}
- if( *ptr == '%' ) /* dangerous printf marker */
- {
- delta = 0;
- while (len && *ptr == '%')
- {
- *line++ = *ptr++; /* copy it in */
- space -= 1;
- len -= 1;
- delta++;
- }
- if (delta % 2) /* odd amount of %'s */
- {
- if (space)
- {
- *line++ = '%'; /* so simply add one */
- space -= 1;
- }
- else
- {
- *line++ = '\0'; /* remove the last one /
terminate the string */
- }
-
- }
- }
break;
case PARSING_SYMSTART:
--- 794,799 ----
--- End Message ---
--- Begin Message ---
Source: sysklogd
Source-Version: 1.5-1
We believe that the bug you reported is fixed in the latest version of
sysklogd, which is due to be installed in the Debian FTP archive:
klogd_1.5-1_i386.deb
to pool/main/s/sysklogd/klogd_1.5-1_i386.deb
sysklogd_1.5-1.diff.gz
to pool/main/s/sysklogd/sysklogd_1.5-1.diff.gz
sysklogd_1.5-1.dsc
to pool/main/s/sysklogd/sysklogd_1.5-1.dsc
sysklogd_1.5-1_i386.deb
to pool/main/s/sysklogd/sysklogd_1.5-1_i386.deb
sysklogd_1.5.orig.tar.gz
to pool/main/s/sysklogd/sysklogd_1.5.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin Schulze <[EMAIL PROTECTED]> (supplier of updated sysklogd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 30 Jul 2007 12:13:46 +0200
Source: sysklogd
Binary: sysklogd klogd
Architecture: source i386
Version: 1.5-1
Distribution: unstable
Urgency: low
Maintainer: Martin Schulze <[EMAIL PROTECTED]>
Changed-By: Martin Schulze <[EMAIL PROTECTED]>
Description:
klogd - Kernel Logging Daemon
sysklogd - System Logging Daemon
Closes: 107501 118856 136190 144499 166433 166763 178000 192841 196521 197602
201231 203710 238507 284877 291442 315605 415136 426271 427596 428964
Changes:
sysklogd (1.5-1) unstable; urgency=low
.
* New upstream version
. Use proper facility for MARK messages (closes: Bug#107501)
. Properly handle buffer full condition (closes: Bug#118856)
. Spelling fixes (closes: Bug#136190)
. Reconnect klogd to syslogd when disconnected (closes: Bug#144499,
Bug#178000, Bug#284877, Bug#415136)
. Fixed symbol lookup (closes: Bug#166433)
. Don't die too soon (closes: Bug#166763)
. No special rule for '%' in klogd anymore (closes: Bug#192841)
. Don't hang during broken startup anymore (closes: Bug#196521)
. Don't resolve hostnames needlessly (closes: Bug#197602)
. Stop using obsolete SO_BSDCOMPAT option (closes: Bug#201231, Bug#291442)
. Update klogd symbol parser (closes: Bug#203710)
. Don't add extra space when forwarding messages (closes: Bug#238507)
. Don't eat too much suspicious characters (closes: Bug#315605)
. Improved documentation (closes: Bug#426271)
. Removed <asm/linkage.h> (closes: Bug#427596)
* One of the many changes fixed another bug (closes: Bug#428964)
* Adjusted klogd stop method
Files:
1dc8840f6b1fc897690cae94e6dfcb7b 567 admin important sysklogd_1.5-1.dsc
e053094e8103165f98ddafe828f6ae4b 86557 admin important sysklogd_1.5.orig.tar.gz
c69e7bac5286b75293aa85ca697a71c2 23263 admin important sysklogd_1.5-1.diff.gz
cb2fc9a8cf1354977e24fa48bed42700 61064 admin important sysklogd_1.5-1_i386.deb
87b3164f94cbb882c536c5ed8f001003 42232 admin important klogd_1.5-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGrdOuW5ql+IAeqTIRAmQaAJ4ybZzkZ6zSyCIYx/LCpVoEHzWg0gCfRHG2
ZMzsIjd2MxnEhsZzlIgB2bA=
=jPKX
-----END PGP SIGNATURE-----
--- End Message ---
