Your message dated Sun, 05 Aug 2007 00:47:14 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#435555: fixed in util-linux 2.13~rc2-6
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: mount
Version: 2.13~rc2-4
Severity: normal
Tags: patch
While parsing /etc/fstab, swapoff does not make provision for UUID= and LABEL=
identifiers. It needs to resolve the device represented by these tokens to
correctly identify if it is present in /proc/swaps via function
is_in_proc_swaps() and attempting to do_swapoff().
At the moment, swapoff needlessly makes alarming noise at shutdown by
attempting to do stuff to a string rather than a block device, which can be
simulated:
# swapoff -a -v
swapoff on /dev/sda6
swapoff: cannot canonicalize UUID=519625a9-a64c-4a37-9277-1e2470644329: No such
file or directory
swapoff on UUID=519625a9-a64c-4a37-9277-1e2470644329
Use fsprobe_get_devname() to resolve actual device name, just as it is done
for swapon -a.
diff -Nrup util-linux-2.13~rc2/mount/swapon.c
util-linux-2.13~rc2.patched/mount/swapon.c
--- util-linux-2.13~rc2/mount/swapon.c 2007-06-29 20:19:34.000000000 +1000
+++ util-linux-2.13~rc2.patched/mount/swapon.c 2007-08-02 00:21:48.000000000
+1000
@@ -491,9 +491,18 @@ main_swapoff(int argc, char *argv[]) {
exit(2);
}
while ((fstab = getmntent(fp)) != NULL) {
- if (streq(fstab->mnt_type, MNTTYPE_SWAP) &&
- !is_in_proc_swaps(fstab->mnt_fsname))
- do_swapoff(fstab->mnt_fsname, QUIET);
+ const char *orig_special = fstab->mnt_fsname;
+ const char *special;
+
+ if (!streq(fstab->mnt_type, MNTTYPE_SWAP))
+ continue;
+
+ special = fsprobe_get_devname(orig_special);
+ if (!special)
+ continue;
+
+ if (!is_in_proc_swaps(special))
+ do_swapoff(special, QUIET);
}
fclose(fp);
}
---
Thanks, Kel.
--- End Message ---
--- Begin Message ---
Source: util-linux
Source-Version: 2.13~rc2-6
We believe that the bug you reported is fixed in the latest version of
util-linux, which is due to be installed in the Debian FTP archive:
bsdutils_2.13~rc2-6_i386.deb
to pool/main/u/util-linux/bsdutils_2.13~rc2-6_i386.deb
cfdisk-udeb_2.13~rc2-6_i386.udeb
to pool/main/u/util-linux/cfdisk-udeb_2.13~rc2-6_i386.udeb
fdisk-udeb_2.13~rc2-6_i386.udeb
to pool/main/u/util-linux/fdisk-udeb_2.13~rc2-6_i386.udeb
mount_2.13~rc2-6_i386.deb
to pool/main/u/util-linux/mount_2.13~rc2-6_i386.deb
util-linux-locales_2.13~rc2-6_all.deb
to pool/main/u/util-linux/util-linux-locales_2.13~rc2-6_all.deb
util-linux_2.13~rc2-6.diff.gz
to pool/main/u/util-linux/util-linux_2.13~rc2-6.diff.gz
util-linux_2.13~rc2-6.dsc
to pool/main/u/util-linux/util-linux_2.13~rc2-6.dsc
util-linux_2.13~rc2-6_i386.deb
to pool/main/u/util-linux/util-linux_2.13~rc2-6_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
LaMont Jones <[EMAIL PROTECTED]> (supplier of updated util-linux package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 4 Aug 2007 18:22:19 -0600
Source: util-linux
Binary: util-linux cfdisk-udeb fdisk-udeb util-linux-locales bsdutils mount
Architecture: all i386 source
Version: 2.13~rc2-6
Distribution: unstable
Urgency: low
Maintainer: LaMont Jones <[EMAIL PROTECTED]>
Changed-By: LaMont Jones <[EMAIL PROTECTED]>
Description:
bsdutils - Basic utilities from 4.4BSD-Lite
cfdisk-udeb - Partition a hard drive (cfdisk)
fdisk-udeb - Partition a hard drive (manual)
mount - Tools for mounting and manipulating filesystems
util-linux - Miscellaneous system utilities
util-linux-locales - Locales files for util-linux
Closes: 435555 436003
Changes:
util-linux (2.13~rc2-6) unstable; urgency=low
.
* More fixes from upstream
* mount.preinst: deal with no /proc/mounts. Closes: #436003
* swapoff: handle UUID= and LABEL=. Closes: #435555
Files:
0c0bab23faa026b3552af03f8066e755 565860 debian-installer extra
cfdisk-udeb_2.13~rc2-6_i386.udeb
0df5cdb1828252f21c31415ab8f51776 53724 utils required
bsdutils_2.13~rc2-6_i386.deb
13cde69712570e05c7f256cc9f62794d 405638 utils required
util-linux_2.13~rc2-6_i386.deb
4db58499acd0dacd06b662bd0d09b254 1278966 utils optional
util-linux-locales_2.13~rc2-6_all.deb
991bd02f832d1d54ea9b1a27d031c78a 65846 debian-installer extra
fdisk-udeb_2.13~rc2-6_i386.udeb
9df0db0640d806d998edcba24ec4bfab 806 base required util-linux_2.13~rc2-6.dsc
adae0aeb1515eb19e0275735cdd92b92 306267 base required
util-linux_2.13~rc2-6.diff.gz
be25d07f1288eee0ad904e394ece8484 133098 admin required
mount_2.13~rc2-6_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGtRlNzN/kmwoKyScRAnHWAKCIhm/6WcHjMy40CTf6y3hUs9xLVwCePfVB
n0SWwELWS3dC3CNj3ZHFBps=
=EEKN
-----END PGP SIGNATURE-----
--- End Message ---
