Your message dated Sun, 21 Oct 2007 12:37:44 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#432837: Directory support for INCLUDE (with patch)
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: shorewall
Version: 3.2.6-2
Severity: wishlist
Simply put, it would be nice if given a directory, the INCLUDE directive
would process all the files therein, which this patch does.
--- functions.orig 2006-11-18 17:40:07.000000000 +0000
+++ functions 2007-07-12 11:43:27.942659031 +0100
@@ -1856,7 +1856,17 @@
while read first rest; do
if [ "x$first" = "xINCLUDE" ]; then
if [ $2 -lt 4 ]; then
- read_file $(find_file $(expand ${rest%#*})) $(($2 + 1))
+ file=$(find_file $(expand ${rest%#*}))
+ if [ -d "$file" ]; then
+ for each in "$file"/*;
+ do
+ if [ -e "$each" ]; then # Allow empty directories
+ read_file "$each" $2 # Don't increment counter
+ fi
+ done
+ else
+ read_file $(find_file $(expand ${rest%#*})) $(($2 + 1))
+ fi
else
error_message "WARNING: INCLUDE in $1 ignored (nested too deeply)"
fi
Matthew
--
I must take issue with the term "a mere child", for it has been my
invariable experience that the company of a mere child is infinitely
preferable to that of a mere adult.
-- Fran Lebowitz
--- End Message ---
--- Begin Message ---
As it appears that in 2.5 months, there has been no interest in
rewritign the patch, I am closing the bug. Further 3.4 versions of
shorewall will not be packaged for Debian, so this is really a moot
point.
Regards,
-Roberto
--
Roberto C. Sánchez
http://people.connexer.com/~roberto
http://www.connexer.com
signature.asc
Description: Digital signature
--- End Message ---
