Your message dated Sat, 29 Dec 2007 13:03:44 +0100
with message-id <[EMAIL PROTECTED]>
and subject line fixd in libdbus-ruby 0.2.1-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: libdbus-ruby
Version: 0.2.0-1
Severity: wishlist
Tags: patch

This version of the Ruby DBus bindings throws a NotImplementedError
when trying to parse dictionaries (arrays of dict_entries), presumably
because it isn't implemented.  A patch is attached which attempts to
implement this.  Note that it does not check for dict_entries being
necessarily part of arrays, and I have not checked to see whether
other code checks for this.  At worst, a stray dict_entry that
violates the D-Bus specification may be deserialized as a two-element
array instead of as a dictionary.

   ---> Drake Wilson

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.22.2 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libdbus-ruby depends on:
ii  libdbus-ruby1.8               0.2.0-1    Ruby 1.8 binding for D-Bus

libdbus-ruby recommends no packages.

-- no debconf information
diff -ur libdbus-ruby-0.2.0/lib/dbus/marshall.rb 
libdbus-ruby-new/lib/dbus/marshall.rb
--- libdbus-ruby-0.2.0/lib/dbus/marshall.rb     2007-05-26 06:43:50.000000000 
-0500
+++ libdbus-ruby-new/lib/dbus/marshall.rb       2007-12-16 10:15:51.000000000 
-0600
@@ -195,6 +195,13 @@
         while @idx - start_idx < array_sz
           packet << do_parse(signature.child)
         end
+
+        if signature.child.sigtype == Type::DICT_ENTRY then
+          packet = packet.inject(Hash.new) { |hash, pair|
+            hash[pair[0]] = pair[1]
+            hash
+          }
+        end
       when Type::STRUCT
         align(8)
         packet = Array.new
@@ -212,6 +219,11 @@
         packet = get_string
       when Type::SIGNATURE
         packet = get_signature
+      when Type::DICT_ENTRY
+        align(8)
+        key = do_parse(signature.members[0])
+        value = do_parse(signature.members[1])
+        packet = [key, value]
       else
         raise NotImplementedError,
                "sigtype: #{signature.sigtype} (#{signature.sigtype.chr})"

--- End Message ---
--- Begin Message ---
Source: libdbus-ruby
Source-Version: 0.2.1-1

We believe that the bug you reported is fixed in the latest version of
libdbus-ruby, which is due to be installed in the Debian FTP archive:

libdbus-ruby1.8_0.2.1-1_all.deb
  to pool/main/libd/libdbus-ruby/libdbus-ruby1.8_0.2.1-1_all.deb
libdbus-ruby_0.2.1-1.diff.gz
  to pool/main/libd/libdbus-ruby/libdbus-ruby_0.2.1-1.diff.gz
libdbus-ruby_0.2.1-1.dsc
  to pool/main/libd/libdbus-ruby/libdbus-ruby_0.2.1-1.dsc
libdbus-ruby_0.2.1-1_all.deb
  to pool/main/libd/libdbus-ruby/libdbus-ruby_0.2.1-1_all.deb
libdbus-ruby_0.2.1.orig.tar.gz
  to pool/main/libd/libdbus-ruby/libdbus-ruby_0.2.1.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.  Thank you for reporting the bugs.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 29 Dec 2007 01:25:19 +0100
Source: libdbus-ruby
Binary: libdbus-ruby1.8 libdbus-ruby
Architecture: source all
Version: 0.2.1-1
Distribution: unstable
Urgency: low
Maintainer: Paul van Tilburg <[EMAIL PROTECTED]>
Changed-By: Paul van Tilburg <[EMAIL PROTECTED]>
Description: 
 libdbus-ruby - Ruby binding for D-Bus
 libdbus-ruby1.8 - Ruby 1.8 binding for D-Bus
Changes: 
 libdbus-ruby (0.2.1-1) unstable; urgency=low
 .
   * New upstream release.
   * Bumped standards version to 3.7.3; no changes required.
   * Added Homepage and Vcs-* fields.
Files: 
 dfb0101c10b746fb386d3d663235a547 1020 libs optional libdbus-ruby_0.2.1-1.dsc
 1f6398d8bbafa272c0b43878fec43276 56197 libs optional 
libdbus-ruby_0.2.1.orig.tar.gz
 f1289c069d9bbb430b5c89ae2dbf7de4 1681 libs optional 
libdbus-ruby_0.2.1-1.diff.gz
 13ea29f17baae9c5538d58d0012a91c8 24650 libs optional 
libdbus-ruby_0.2.1-1_all.deb
 3bd424505a5ba38d2628909dfa426a71 28302 libs optional 
libdbus-ruby1.8_0.2.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHdZY/JBBhylAGQYERAhGoAJ0QM6EHBwREheeHXiC0wtXsdTHSxACeM7E7
yqDCvmbdkTFxxXYJ5IfsYCM=
=sV4z
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to