Your message dated Mon, 14 Jan 2008 14:02:02 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#294788: fixed in bwm 1.1.0-8.2 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: bwm Version: 1.1.0-8 Severity: normal Tags: patch Long device names are not cut off properly. I've got a device named "tun6to4_ppp0" for IPv6 which gives me 3 garbled characters and moves the tables two spaces to the right as shown here: <----- snip -----> Bandwidth Monitor 1.1.0 Iface RX(KB/sec) TX(KB/sec) Total(KB/sec) dsl0 4.616 10.716 15.332 lo 0.106 0.106 0.212 eth0 59.919 316.439 376.358 eth1 0.000 0.000 0.000 teql0 0.000 0.000 0.000 sit0 0.000 0.000 0.000 ppp0 4.392 10.480 14.872 tun6to4_ppp·ëM 0.000 0.000 0.000 tun0 0.000 0.000 0.000 Total 69.033 337.741 406.774 Hit CTRL-C to end this madness. <----- snap -----> Cause for this error is the improper use of strncpy() which does not add an '\0' at the end of a string when characters are cut off. I've written two different patches to solve this problem. One patch aligns the device name to the left before cut-off, the other patch aligns the device name to the right. Please apply either one as you see fit. I think that the rightbound variant is the better one because it tries to keep the device names different as you can see in this example: original device name |leftbound |rightbound | ===========:---------|===========|===========| ppp0 : | ppp0| ppp0| ppp1 : | ppp1| ppp1| tun6to4_ppp0 |tun6to4_ppp|un6to4_ppp0| tun6to4_ppp1 |tun6to4_ppp|un6to4_ppp1| tun6to4_ppp2 |tun6to4_ppp|un6to4_ppp2| really_long_device |really_long|long_device| -- System Information: Debian Release: 3.1 APT prefers testing APT policy: (500, 'testing'), (50, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.10 Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15) Versions of packages bwm depends on: ii libc6 2.3.2.ds1-20 GNU C Library: Shared libraries an -- no debconf information -- ....Christian.Garbs.....................................http://www.cgarbs.de o _______________ /\_ _| | _\__`[_______________| ] [ \, ][ ][diff -Naru bwm-1.1.0.orig/bwm.c bwm-1.1.0/bwm.c --- bwm-1.1.0.orig/bwm.c 2005-02-11 17:51:23.000000000 +0100 +++ bwm-1.1.0/bwm.c 2005-02-11 17:53:26.000000000 +0100 @@ -126,6 +126,7 @@ buffer_pointer = buffer; buffer_pointer = strtok(buffer_pointer, " :"); strncpy(interface[inum].name, buffer_pointer, 11); + interface[inum].name[11]='\0'; field_number = 0;diff -Naru bwm-1.1.0.orig/bwm.c bwm-1.1.0/bwm.c --- bwm-1.1.0.orig/bwm.c 2005-02-11 17:51:23.000000000 +0100 +++ bwm-1.1.0/bwm.c 2005-02-11 17:54:41.000000000 +0100 @@ -125,7 +125,10 @@ { buffer_pointer = buffer; buffer_pointer = strtok(buffer_pointer, " :"); - strncpy(interface[inum].name, buffer_pointer, 11); + if (strlen(buffer_pointer) > 11) { + buffer_pointer += strlen(buffer_pointer) - 11; + } + strncpy(interface[inum].name, buffer_pointer, 12); field_number = 0;
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---Source: bwm Source-Version: 1.1.0-8.2 We believe that the bug you reported is fixed in the latest version of bwm, which is due to be installed in the Debian FTP archive: bwm_1.1.0-8.2.diff.gz to pool/main/b/bwm/bwm_1.1.0-8.2.diff.gz bwm_1.1.0-8.2.dsc to pool/main/b/bwm/bwm_1.1.0-8.2.dsc bwm_1.1.0-8.2_i386.deb to pool/main/b/bwm/bwm_1.1.0-8.2_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Lucas Nussbaum <[EMAIL PROTECTED]> (supplier of updated bwm package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Mon, 14 Jan 2008 14:23:59 +0100 Source: bwm Binary: bwm Architecture: source i386 Version: 1.1.0-8.2 Distribution: unstable Urgency: low Maintainer: Lenart Janos <[EMAIL PROTECTED]> Changed-By: Lucas Nussbaum <[EMAIL PROTECTED]> Description: bwm - BandWidth Monitor Closes: 175826 294788 362080 375394 384634 404374 Changes: bwm (1.1.0-8.2) unstable; urgency=low . * Non-maintainer upload. * debian/rules: fix bashisms (use of {,}). Ubuntu's patch was used as a basis. Closes: 375394. * Interface names over 11 characters displayed with corruption. Applied patch from Matthew William Solloway Bell (Closes: #404374, #294788) * Sometimes displayed too many digits. Applied patch from Mario Holbe. (Closes: #175826) * Fixed typos in bwm.1. Applied patch from A Costa. (Closes: #362080) * Fixed typo in description. Applied patch from Eric Cooper (Closes: #384634) Files: 814f91cda658a0d525dce05c0d3c9309 510 net optional bwm_1.1.0-8.2.dsc c5ff9405e315a3d497579e48bec83841 4207 net optional bwm_1.1.0-8.2.diff.gz 7ea9b7de0b5e03951497eaebb43bfc7d 8102 net optional bwm_1.1.0-8.2_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHi2jR2hliNwI7P08RAkJuAKC1J7bRMNC+KulC+C6t0KMl08QxoQCffVZI 8ziSIzV5gWKLd0wGiz+nQlU= =fjeI -----END PGP SIGNATURE-----
--- End Message ---
