Your message dated Wed, 16 Jan 2008 22:43:51 -0600
with message-id <[EMAIL PROTECTED]>
and subject line Using stock gtk buttons slows grun too much
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: grun
Version: 0.9.2-14
Severity: wishlist
Tags: patch
Grun should use the stock gtk buttons for its interface, instead of
custom made ones. This will allow it to have a consistent l&f with the
rest of gtk apps, use the user's theme icons, and be consistently
translated with all of GTK.
The following patch implements this:
----------------------------------------------------------------------
diff -r a7e1f1d8c9ef grun.c
--- a/grun.c Tue Aug 14 23:29:02 2007 -0500
+++ b/grun.c Sun Oct 07 10:57:12 2007 -0500
@@ -1231,7 +1231,7 @@ int PASCAL WinMain(HINSTANCE hInst, HINS
gtk_window_set_focus(GTK_WINDOW (win), GTK_COMBO (cmb)->entry);
gtk_widget_show(cmb);
- btn = gtk_button_new_with_label(gettext("OK"));
+ btn = gtk_button_new_from_stock(GTK_STOCK_EXECUTE);
gtk_widget_set_usize(GTK_WIDGET(btn), 70, 24);
gtk_fixed_put(GTK_FIXED (fix), btn, 5, 60);
gtk_signal_connect(GTK_OBJECT (btn), "clicked", (GtkSignalFunc) launch,
(gpointer) gdat);
@@ -1239,10 +1239,10 @@ int PASCAL WinMain(HINSTANCE hInst, HINS
gtk_widget_show(btn);
if (persist) {
- btn = gtk_button_new_with_label(gettext("Close"));
+ btn = gtk_button_new_from_stock(GTK_STOCK_CLOSE);
}
else {
- btn = gtk_button_new_with_label(gettext("Cancel"));
+ btn = gtk_button_new_from_stock(GTK_STOCK_CANCEL);
}
gtk_widget_set_usize(GTK_WIDGET(btn), 70, 24);
@@ -1256,7 +1256,7 @@ int PASCAL WinMain(HINSTANCE hInst, HINS
}
gtk_widget_show(btn);
- btn = gtk_button_new_with_label(gettext("Browse"));
+ btn = gtk_button_new_from_stock(GTK_STOCK_OPEN);
gtk_widget_set_usize(GTK_WIDGET(btn), 70, 24);
gtk_fixed_put(GTK_FIXED (fix), btn, 165, 60);
gtk_signal_connect(GTK_OBJECT (btn), "clicked", (GtkSignalFunc) browse,
(gpointer) gdat);
----------------------------------------------------------------------
-- no debconf information
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
After quite a while of testing, I've seen that using the stock buttons
slows down grun too much. It does not seem to improve even if grun is
started right after shutting down, so I guess it's not a matter of a
cold disk cache or something like that.
Therefore I withdraw the request to apply this patch. If I manage to
find a way to fix this, maybe by using stock buttons but without
icons, I'll reopen the bug with a new patch.
signature.asc
Description: Digital signature
--- End Message ---
