Your message dated Sat, 16 Feb 2008 21:02:09 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#450649: fixed in grep 2.5.3~dfsg-4 has caused the Debian Bug report #450649, regarding /bin/egrep: 30% speedup with calloc() rather than malloc() to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 450649: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=450649 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: grep Version: 2.5.3~dfsg-3 Severity: normal File: /bin/egrep Tags: patch I've been profiling egrep since it uses lots of CPU when logcheck does its thing. In dfa.c, top of function epsclosure, we have this (with oprofile sample counts): : MALLOC(visited, int, d->tindex); 48796 16.2440 : for (i = 0; i < d->tindex; ++i) 94442 31.4394 : visited[i] = 0; Replacing the home-made memset() loop above with doing CALLOC instead we get: : CALLOC(visited, int, d->tindex); : // for (i = 0; i < d->tindex; ++i) : // visited[i] = 0; Zero samples. But obviously all that didn't just disappear. It went into memset: samples % image name app name symbol name 60474 22.3932 libc-2.6.1.so libc-2.6.1.so memset So instead of taking 50% of the CPU time with MALLOC(), it takes 22% with CALLOC(). Please change MALLOC() to CALLOC() and remove the loop. Regards //Johan -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (990, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.22-2-686 (SMP w/2 CPU cores) Locale: LANG=sv_SE.UTF-8, LC_CTYPE=sv_SE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages grep depends on: ii libc6 2.6.1-1+b1 GNU C Library: Shared libraries grep recommends no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: grep Source-Version: 2.5.3~dfsg-4 We believe that the bug you reported is fixed in the latest version of grep, which is due to be installed in the Debian FTP archive: grep_2.5.3~dfsg-4.diff.gz to pool/main/g/grep/grep_2.5.3~dfsg-4.diff.gz grep_2.5.3~dfsg-4.dsc to pool/main/g/grep/grep_2.5.3~dfsg-4.dsc grep_2.5.3~dfsg-4_i386.deb to pool/main/g/grep/grep_2.5.3~dfsg-4_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Santiago Ruano Rincón <[EMAIL PROTECTED]> (supplier of updated grep package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sat, 16 Feb 2008 20:43:55 +0100 Source: grep Binary: grep Architecture: source i386 Version: 2.5.3~dfsg-4 Distribution: unstable Urgency: low Maintainer: Anibal Monsalve Salazar <[EMAIL PROTECTED]> Changed-By: Santiago Ruano Rincón <[EMAIL PROTECTED]> Description: grep - GNU grep, egrep and fgrep Closes: 226881 414168 450649 Changes: grep (2.5.3~dfsg-4) unstable; urgency=low . * rgrep: Make . the default when no file or directory names given. Thanks to Magnus Holmgren <[EMAIL PROTECTED]> (Closes: 414168) * grep.1: using \(aq instead of '. Thanks to Andrew Moise <[EMAIL PROTECTED]>. (Closes: #226881) * egrep: using calloc() instead of malloc() Thanks to Johan Walles <[EMAIL PROTECTED]> (Closes: #450649) * Updated watch file. * Bump Standard-version to 3.7.3. (No changes needed) Files: 9305d6ec070016950abf363ec71701fe 703 utils required grep_2.5.3~dfsg-4.dsc dc65370a70305ca8db423cc33eff078b 17435 utils required grep_2.5.3~dfsg-4.diff.gz 48c45f636a84347278928856b275f2c5 277366 utils required grep_2.5.3~dfsg-4_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHt0fzQUuEI2/szeARAtjlAJ9Zoq3ADUADwQiaa1p+mx2igS1IcACffuBw +zx/FMGu298Nr03n2LVGBPw= =U18i -----END PGP SIGNATURE-----
--- End Message ---
