Your message dated Sun, 16 Mar 2008 13:56:25 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Re: Bug#411047: cupsys does not apply printer specific
op-policy on startup
has caused the Debian Bug report #411047,
regarding cupsys does not apply printer specific op-policy on startup
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
411047: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=411047
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: cupsys
Version: 1.2.7-4.1
Severity: important
Tags: patch
Hi,
I have been deploying a etch-based cupsys server for my lab and have
noticed the following bug :
create a new policy in cupsd.conf (using the provided cupsd.conf file)
restart cupsys
apply that policy to a specific printer (lpadmin -p printer -o
printer-op-policy=the_policy, or through the web based interface)
test it, it works (my test case was to reject a specific IP adress
client)
restart cups, the policy _appears_ as applied (web interface, printer
settings and such) but it not really applied (so for example,
my unauthorized client can print through)
reapply manually the policy, it works again (client cannot print)
check printers.conf, the OpPolicy line is correct
this lead me to the conclusion that the policy was saved correctly but
not restored correctly on startup
after investigating quite a bit, I have produced a patch that I believe
fixes that behavior. At least "it works for me" (tm).
It seems the printer op-policy argument is correctly set, but there is
also a op-policy-ptr which was not updated when loading printers.
Updating that pointer as well when loading printers from printers.conf
made it work here.
Note that it might not be the correct fix, this might need input from
cupsys developers.
Untested : are other policys (error-policy/classes policies etc)
correctly loaded and applied on startup, my patch does nothing regarding
that ...
Cheers,
Mik
-- System Information:
Debian Release: 4.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-2-vserver-amd64
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8)
Versions of packages cupsys depends on:
ii adduser 3.102 Add and remove users and groups
ii cupsys-common 1.2.7-4.1 Common UNIX Printing System(tm) -
ii debconf [debconf-2.0] 1.5.11 Debian configuration management sy
ii gs-esp 8.15.3.dfsg.1-1 The Ghostscript PostScript interpr
ii libc6 2.3.6.ds1-11 GNU C Library: Shared libraries
ii libcupsimage2 1.2.7-4.1 Common UNIX Printing System(tm) -
ii libcupsys2 1.2.7-4.1 Common UNIX Printing System(tm) -
ii libdbus-1-3 1.0.2-1 simple interprocess messaging syst
ii libgnutls13 1.4.4-3 the GNU TLS library - runtime libr
ii libldap2 2.1.30-13.2 OpenLDAP libraries
ii libpam0g 0.79-4 Pluggable Authentication Modules l
ii libpaper1 1.1.21 Library for handling paper charact
ii libslp1 1.2.1-6 OpenSLP libraries
ii lsb-base 3.1-23 Linux Standard Base 3.1 init scrip
ii patch 2.5.9-4 Apply a diff file to an original
ii perl-modules 5.8.8-7 Core Perl modules
ii procps 1:3.2.7-3 /proc file system utilities
ii xpdf-utils [poppler-util 3.01-9 Portable Document Format (PDF) sui
ii zlib1g 1:1.2.3-13 compression library - runtime
Versions of packages cupsys recommends:
ii cupsys-client 1.2.7-4.1 Common UNIX Printing System(tm) -
ii foomatic-filters 3.0.2-20061031-1.1 linuxprinting.org printer support
pn smbclient <none> (no description available)
-- debconf information:
cupsys/raw-print: true
cupsys/browse: true
cupsys/ports: localhost:631 /var/run/cups/cups.sock
cupsys/backend: ipp, lpd, parallel, socket, usb
cupsys/portserror:
69_fix_oppolicy_startup_loading.patch
Description: application/shellscript
--- End Message ---
--- Begin Message ---
Version: 1.3.6-1
Hi Mickael,
Mickael Marchand [2007-02-15 14:36 +0100]:
> I have been deploying a etch-based cupsys server for my lab and have
> noticed the following bug :
> create a new policy in cupsd.conf (using the provided cupsd.conf file)
> restart cupsys
> apply that policy to a specific printer (lpadmin -p printer -o
> printer-op-policy=the_policy, or through the web based interface)
> test it, it works (my test case was to reject a specific IP adress
> client)
> restart cups, the policy _appears_ as applied (web interface, printer
> settings and such) but it not really applied (so for example,
> my unauthorized client can print through)
> reapply manually the policy, it works again (client cannot print)
> check printers.conf, the OpPolicy line is correct
>
> this lead me to the conclusion that the policy was saved correctly but
> not restored correctly on startup
> after investigating quite a bit, I have produced a patch that I believe
> fixes that behavior. At least "it works for me" (tm).
> It seems the printer op-policy argument is correctly set, but there is
> also a op-policy-ptr which was not updated when loading printers.
> Updating that pointer as well when loading printers from printers.conf
> made it work here.
> Note that it might not be the correct fix, this might need input from
> cupsys developers.
> Untested : are other policys (error-policy/classes policies etc)
> correctly loaded and applied on startup, my patch does nothing regarding
> that ...
I believe this is fixed in the current version 1.3.6. For the
cupsdFindPolicy() != NULL case, the op_policy_ptr is now correctly set
at the point in code where you patched it as well. For the == NULL
case, cupsdUpdatePrinters() sets it to the default policy.
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
My 5 today: #193696 (postgresql-common, debian-installer), #172837
(hal), #172853 (initramfs-tools), #189995 (langpack-locales, belocs-
locales-bin), #115768 (ntfs-config, hal)
Do 5 a day - every day! https://wiki.ubuntu.com/5-A-Day
signature.asc
Description: Digital signature
--- End Message ---
