Your message dated Sat, 22 Mar 2008 17:17:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#283788: fixed in console-common 0.7.74
has caused the Debian Bug report #283788,
regarding pattern to generous for searching variables in /etc/environment
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
283788: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=283788
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: console-tools
Version: 1:0.2.3dbs-55
Severity: minor

Hello,

/etc/init.d/console-screen.sh uses in lines 149f the following commands:

  value=$(egrep "^[^#]*${var}=" /etc/environment | cut -d= -f2)
  eval $var=$value

There ${var} is one of LANG, LC_ALL, LC_CTYPE. 

(keymap.sh uses the same code in lines 45f.)

If /etc/environment contains the following lines:

  LANG=de
  ERLANG=anything

then the code above does two things, which are in my eyes at least undesirable:

- both lines are matched by '^[^#]*LANG='
- the string 'LANG=de anything' is eval'd, resulting in the command
  anything being executed.

Something similar happens if the rhs of ERLANG contains more than one
word unquoted (and there is no line specifying LANG).

Moreover, note that $(...) is not supported by all sh-compatible shells.

So I suggest to change the two lines to:

  value=`egrep "^[[:space:]]*${var}=" /etc/environment | sed -n '$p' | cut -d= 
-f2-`
  eval $var='$value'

Regards
Uwe

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (900, 'testing'), (300, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages console-tools depends on:
ii  console-common             0.7.47        Basic infrastructure for text cons
ii  debconf                    1.4.40        Debian configuration management sy
ii  libc6                      2.3.2.ds1-18  GNU C Library: Shared libraries an
ii  libconsole                 1:0.2.3dbs-55 Shared libraries for Linux console
ii  sysvinit                   2.86-5        System-V like init

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: console-common
Source-Version: 0.7.74

We believe that the bug you reported is fixed in the latest version of
console-common, which is due to be installed in the Debian FTP archive:

console-common_0.7.74.dsc
  to pool/main/c/console-common/console-common_0.7.74.dsc
console-common_0.7.74.tar.gz
  to pool/main/c/console-common/console-common_0.7.74.tar.gz
console-common_0.7.74_all.deb
  to pool/main/c/console-common/console-common_0.7.74_all.deb
dh-consoledata_0.7.74_all.deb
  to pool/main/c/console-common/dh-consoledata_0.7.74_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <[EMAIL PROTECTED]> (supplier of updated console-common 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 22 Mar 2008 17:39:42 +0100
Source: console-common
Binary: console-common dh-consoledata
Architecture: source all
Version: 0.7.74
Distribution: unstable
Urgency: low
Maintainer: Alastair McKinstry <[EMAIL PROTECTED]>
Changed-By: Christian Perrier <[EMAIL PROTECTED]>
Description: 
 console-common - basic infrastructure for text console configuration
 dh-consoledata - debhelper-based script to help packaging console data files
Closes: 283788 462896 467089 467349 468953
Changes: 
 console-common (0.7.74) unstable; urgency=low
 .
   [ Debconf translations ]
   * Simplified Chinese. Closes: #462896
   * Arabic. Closes: #467089
   * Norwegian Bokmål. Closes: #467349
   * Slovenian
   * Romanian. Closes: #468953
 .
   [ Christian Perrier ]
   * Fix keymap.sh to better set CHARMAP. Thanks to Uwe Kleine-König
     for the patch. Closes: #283788
Files: 
 f73dfc2439c4f925b0f8f99152d0ec5d 675 utils optional console-common_0.7.74.dsc
 e06d2f82bff6384b2eb4ae8469d13fb5 160524 utils optional 
console-common_0.7.74.tar.gz
 5be3729984c1d9b41df685571e0ae93f 96052 utils optional 
console-common_0.7.74_all.deb
 2a0aff0f744adbac23a3a0ad8eb74b2c 61190 devel extra 
dh-consoledata_0.7.74_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFH5T1h1OXtrMAUPS0RAluIAJ99U0nMAmZf96sjqb39NF0sV66sZQCgo1cx
FIA+HEu/imhfkO4THiLb07s=
=fIy/
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to