Your message dated Mon, 21 Apr 2008 22:47:17 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#477200: fixed in epdfview 0.1.6-4
has caused the Debian Bug report #477200,
regarding epdfview: segmentation fault when opening print dialog
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
477200: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=477200
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: epdfview
Version: 0.1.6-3
Severity: normal

Hello,

I got a segmentation fault when trying to open the print dialog. This
never happened to me before epdfview entered into Debian (before I used
to run the svn trunk version and since that, I have never tried to
print a pdf file).

Moreover, there is no crash when I open the print dialog while the cups
server is not running (but of course the print dialog is empty: no
printer queue).

I found that it maybe related to something that was corrected in rev.
281 of svn trunk ("Added check to prevent segfaults while opening the
print dialog if the PPD file doesn't have the option that was
requrested"), then introduced in svn trunk after 0.1.6 release.

Indeed, after rebuilding epdfview package with the patch directly taken
from svn (in attachment, I just put it into the debian/patches
directory), I can now run epdfview without any crash when trying to open
the print dialog.

By the way, what to you think of packaging epdfview from a recent svn
trunk snapshot? It seems more mature and brings many improvements. And
as far as I remember it is at least as stable as the 0.1.6 release.

Best regards,

Pascal Dormeau

--- /trunk/src/PrintPter.cxx (revision 262)
+++ /trunk/src/PrintPter.cxx (revision 281)
@@ -231,17 +231,24 @@
                 view.clearPageSizeList ();
                 int pageSizeToSelect = 0;
-                ppd_choice_t *pageSizeChoice = pageSizeOption->choices;
-                for ( int currentSize = 0 ;
-                      currentSize < pageSizeOption->num_choices ;
-                      ++currentSize, ++pageSizeChoice )
-                {
-                    const gchar *sizeName = pageSizeChoice->text;
-                    const gchar *sizeValue = pageSizeChoice->choice;
-
-                    view.addPageSize (_(sizeName), sizeValue);
-                    if ( pageSizeChoice->marked )
+                if ( 0 != pageSizeOption )
+                {
+                    ppd_choice_t *pageSizeChoice = pageSizeOption->choices;
+                    for ( int currentSize = 0 ;
+                         currentSize < pageSizeOption->num_choices ;
+                         ++currentSize, ++pageSizeChoice )
                     {
-                        pageSizeToSelect = currentSize;
+                        const gchar *sizeName = pageSizeChoice->text;
+                        const gchar *sizeValue = pageSizeChoice->choice;
+
+                        view.addPageSize (_(sizeName), sizeValue);
+                        if ( pageSizeChoice->marked )
+                        {
+                            pageSizeToSelect = currentSize;
+                        }
                     }
+                }
+                else
+                {
+                    view.addPageSize (_("A4"), "A4");
                 }
                 view.selectPageSize (pageSizeToSelect);
@@ -252,17 +259,24 @@
                 view.clearResolutionList ();
                 int resolutionToSelect = 0;
-                ppd_choice_t *resolutionChoice = resolutionOption->choices;
-                for ( int currentRes = 0 ;
-                      currentRes < resolutionOption->num_choices ;
-                      ++currentRes, ++resolutionChoice )
-                {
-                    const gchar *resName = resolutionChoice->text;
-                    const gchar *resValue = resolutionChoice->choice;
-
-                    view.addResolution (_(resName), resValue);
-                    if ( resolutionChoice->marked )
+                if ( 0 != resolutionOption )
+                {
+                    ppd_choice_t *resolutionChoice = resolutionOption->choices;
+                    for ( int currentRes = 0 ;
+                            currentRes < resolutionOption->num_choices ;
+                            ++currentRes, ++resolutionChoice )
                     {
-                        resolutionToSelect = currentRes;
+                        const gchar *resName = resolutionChoice->text;
+                        const gchar *resValue = resolutionChoice->choice;
+
+                        view.addResolution (_(resName), resValue);
+                        if ( resolutionChoice->marked )
+                        {
+                            resolutionToSelect = currentRes;
+                        }
                     }
+                }
+                else
+                {
+                    view.addResolution (_("300 DPI"), "300x300dpi");
                 }
                 view.selectResolution (resolutionToSelect);
@@ -272,7 +286,7 @@
                     ppdFindOption (printerPPD, "ColorModel");
                 view.clearColorModelList ();
+                int colorModelToSelect = 0;
                 if ( NULL != colorModelOption )
                 {
-                    int colorModelToSelect = 0;
                     ppd_choice_t *colorModelChoice = colorModelOption->choices;
                     for ( int currentColor = 0 ;
@@ -289,5 +303,4 @@
                         }
                     }
-                    view.selectColorModel (colorModelToSelect);
                 }
                 else
@@ -295,4 +308,5 @@
                     view.addColorModel (_("Grayscale"), "Gray");
                 }
+                view.selectColorModel (colorModelToSelect);
                 ppdClose (printerPPD);
             }


--- End Message ---
--- Begin Message ---
Source: epdfview
Source-Version: 0.1.6-4

We believe that the bug you reported is fixed in the latest version of
epdfview, which is due to be installed in the Debian FTP archive:

epdfview_0.1.6-4.diff.gz
  to pool/main/e/epdfview/epdfview_0.1.6-4.diff.gz
epdfview_0.1.6-4.dsc
  to pool/main/e/epdfview/epdfview_0.1.6-4.dsc
epdfview_0.1.6-4_amd64.deb
  to pool/main/e/epdfview/epdfview_0.1.6-4_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yves-Alexis Perez <[EMAIL PROTECTED]> (supplier of updated epdfview package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 21 Apr 2008 23:26:11 +0200
Source: epdfview
Binary: epdfview
Architecture: source amd64
Version: 0.1.6-4
Distribution: unstable
Urgency: low
Maintainer: Yves-Alexis Perez <[EMAIL PROTECTED]>
Changed-By: Yves-Alexis Perez <[EMAIL PROTECTED]>
Description: 
 epdfview   - Lightweight pdf viewer based on poppler libs
Closes: 477200
Changes: 
 epdfview (0.1.6-4) unstable; urgency=low
 .
   * debian/patches: 03_fix-segfault-on-print added.             closes: #477200
Checksums-Sha1: 
 bf7f014c2fd4b8636c4e4ea66b6ac526209d2665 1077 epdfview_0.1.6-4.dsc
 484cd5b05954bcff2bacf310c42b89645a0e915e 2385 epdfview_0.1.6-4.diff.gz
 daf2f1aaa3be95d1b45f560e736fef35e9c8fea3 100004 epdfview_0.1.6-4_amd64.deb
Checksums-Sha256: 
 f9309dc07af04c0f34081d63c13051222231f675c79068cb7ae47bf5c0096377 1077 
epdfview_0.1.6-4.dsc
 8d32260b39afd34eb7035b938ddd8c117e099f7d713574d61857b4869621938f 2385 
epdfview_0.1.6-4.diff.gz
 1fd1d2c326ad9be9dad4a86bf0dfaee06ccdcad2e8cdbb17abbb3a9e0e7801ca 100004 
epdfview_0.1.6-4_amd64.deb
Files: 
 d0a4cf2cb9ee1187184e938967cdf94f 1077 x11 optional epdfview_0.1.6-4.dsc
 1fb677a28da650ee1431c02296664fa8 2385 x11 optional epdfview_0.1.6-4.diff.gz
 c63524795eae4b7aa3a7f0022bf6c94c 100004 x11 optional epdfview_0.1.6-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIDQmiTUTAIMXAW64RAmtNAKCKcl5jqxDs2/WiiY+8Lcm+JO48UgCgiNyz
UFeb2rLS239mKyz84+Ni3tk=
=2W9c
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to