Your message dated Sat, 10 May 2008 13:47:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#462407: fixed in bindgraph 0.2a-3
has caused the Debian Bug report #462407,
regarding unescaped colons in COMMENT field make graph generation fail
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
462407: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462407
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: bindgraph
Version: 0.2-5
Severity: grave
Tags: patch

Hi,

When browsing http://localhost/cgi-bin/bindgraph.cgi I do not see any
graphs, all I see is:

DNS Statistics for [hostname]
Last Hours Graph

bindgraph image 0
Day Graph

bindgraph image 1
Week Graph

bindgraph image 2
Month Graph

bindgraph image 3
Year Graph

bindgraph image 4

bindgraph 0.2 by Marco Delaurenti and Marco d'Itri


Digging deeper, I see the following error when generating the graphs
causing no graphs to appear when accessing the graph URLS (eg.
http://localhost/cgi-bin/bindgraph.cgi/bindgraph_1.png ):

ERROR: 
RRDs::graph(/var/cache/bindgraph/,cgi-bin,bindgraph.cgi/bindgraph_1.png.tmp, 
...): Garbage ': Thu Jan 24 15:10:00 2008    graph created on Thu Jan 24 
15:12:35 2008\r' after command:
COMMENT:last update: Thu Jan 24 15:10:00 2008    graph created on Thu Jan 24 
15:12:35 2008\r


After some searching with google, I determined that the error is caused
by unescaped colons (:) in the COMMENT field.  This behavior was
changed in rrdtool 1.2.x -- previously this was not an error.


So, attached is a patch to fix bindgraph.cgi to work with the rrdtool
1.2.x series.

--Joe

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.4.27-2um
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages bindgraph depends on:
ii  debconf [debconf-2.0]        1.5.11etch1 Debian configuration management sy
ii  libfile-tail-perl            0.98-5      File::Tail perl module
ii  librrds-perl                 1.2.15-0.3  Time-series data storage and displ

Versions of packages bindgraph recommends:
ii  bind9                     1:9.3.4-2etch1 Internet Domain Name Server
ii  lighttpd [httpd]          1.4.13-4etch4  A fast webserver with minimal memo
ii  thttpd [httpd]            2.23beta1-5    tiny/turbo/throttling HTTP server

-- debconf information excluded
--- /var/www/cgi-bin/bindgraph.cgi.orig 2008-01-24 14:55:11.000000000 +0000
+++ /var/www/cgi-bin/bindgraph.cgi      2008-01-24 15:01:21.000000000 +0000
@@ -93,6 +93,12 @@ sub graph($$$;$) {
                }
        }
 
+       # escape colons in COMMENT field (needed for rrdtool 1.2.x
+       my $update_time = localtime(last_update($rrd));
+       $update_time =~ s/\:/\\:/g;
+       my $time_now = localtime(time);
+       $time_now =~ s/\:/\\:/g;
+
        my ($text, $xs, $ys) = RRDs::graph(
                $file,
                '--imgformat', 'PNG',
@@ -106,8 +112,8 @@ sub graph($$$;$) {
                @rrdef,
                @rrprint,
                'COMMENT:\s',
-               'COMMENT:last update: ' . localtime(last_update($rrd))
-                       . '    graph created on ' . localtime(time) . '\r',
+               'COMMENT:last update\: ' . $update_time
+                       . '    graph created on ' . $time_now . '\r',
        );
        my $err = RRDs::error;
        die_fatal("RRDs::graph($file, ...): $err") if $err;

--- End Message ---
--- Begin Message ---
Source: bindgraph
Source-Version: 0.2a-3

We believe that the bug you reported is fixed in the latest version of
bindgraph, which is due to be installed in the Debian FTP archive:

bindgraph_0.2a-3.diff.gz
  to pool/main/b/bindgraph/bindgraph_0.2a-3.diff.gz
bindgraph_0.2a-3.dsc
  to pool/main/b/bindgraph/bindgraph_0.2a-3.dsc
bindgraph_0.2a-3_all.deb
  to pool/main/b/bindgraph/bindgraph_0.2a-3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jose Luis Tallon <[EMAIL PROTECTED]> (supplier of updated bindgraph package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 09 Mar 2008 01:18:35 +0100
Source: bindgraph
Binary: bindgraph
Architecture: source all
Version: 0.2a-3
Distribution: unstable
Urgency: high
Maintainer: Jose Luis Tallon <[EMAIL PROTECTED]>
Changed-By: Jose Luis Tallon <[EMAIL PROTECTED]>
Description: 
 bindgraph  - DNS statistics RRDtool frontend for BIND9
Closes: 318458 414729 427160 427204 462407 475388
Changes: 
 bindgraph (0.2a-3) unstable; urgency=high
 .
   * Acknowledge NMU
     - Updated to S-V 3.7.3 with no changes
 .
   * Bindgraph.cgi already worked with RRDtool 1.2.x since 2a (Closes: #462407)
 .
   * Reconfigure now updates logfile location (Closes: 318458)
 .
   * Debconf translations
     - Vietnamese (Closes: #427204)
     - Danish (Closes: #427160)
     - Finish (Closes: #475388)
     - Traditional Chinese (Closes: #414729)
 .
   * Remove debconf note 'configure_bind', considered to be abusive.
Checksums-Sha1: 
 1a99a02aab0f9e3747df31dc4eaafe712960f42c 1002 bindgraph_0.2a-3.dsc
 36fda48175a079d5e34a5cbd6725ca2e99d2a2e5 20000 bindgraph_0.2a-3.diff.gz
 75f7a4623bceea0878eda811ce5e28e225a4918e 22580 bindgraph_0.2a-3_all.deb
Checksums-Sha256: 
 b53b005ebbc021b252bde16b5c04bb7ef08316a0528d6ad7e9f1ae012a58cf97 1002 
bindgraph_0.2a-3.dsc
 de0a8c1975902d95fbee50ca03f99bbce69c3347a8ce897f45f5bbc1a6249e33 20000 
bindgraph_0.2a-3.diff.gz
 a5f989f4a7ade32722e92c31a3dc6f5754804ec96212bcdcc06581187054f3b1 22580 
bindgraph_0.2a-3_all.deb
Files: 
 629a4a7e404a47575210359bc34b5e62 1002 admin extra bindgraph_0.2a-3.dsc
 95969ffc6366d5018d288169f55de4e2 20000 admin extra bindgraph_0.2a-3.diff.gz
 32873020ad9981412fcaeec49a38e15b 22580 admin extra bindgraph_0.2a-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIJaKu1OXtrMAUPS0RApIgAJ4gbhOlxEvFkcJM55Lo30yu0RoUxQCdGIIN
AIg7X4sCQSvUXRmMJeMf2vY=
=crqp
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to