Your message dated Sat, 28 Jun 2008 10:48:09 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Re: Bug#488325: copying config.sub and config.guess should be 
done in build and not in clean
has caused the Debian Bug report #488325,
regarding copying config.sub and config.guess should be done in build and not 
in clean
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
488325: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=488325
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: opencryptoki
Version: 2.2.5+dfsg-1
Severity: minor

In debian/rules, the clean target does:

ifneq "$(wildcard /usr/share/misc/config.sub)" ""
        cp -f /usr/share/misc/config.sub config.sub
endif
ifneq "$(wildcard /usr/share/misc/config.guess)" ""
        cp -f /usr/share/misc/config.guess config.guess
endif


That's wrong because running the clean target may make those files different to
what the upstream tarball have, and thus leaving those changes in the diff.gz.

Those files should be copied in the build target and restored in the clean
target. Or copied in the build target and removed in the clean one, as dpkg will
ignore deleted files.

Cheers,
Emilio

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Emilio Pozuelo Monfort wrote:
> That's wrong because running the clean target may make those files different 
> to
> what the upstream tarball have, and thus leaving those changes in the diff.gz.

first of all, this is absolutely not wrong, it is just different (and
fully up to the maintainer on which way he preferes to update those files).

second, I already changed this some time ago,
see http://git.debian.net/?p=opencryptoki.git;a=shortlog;h=refs/heads/debian

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          [EMAIL PROTECTED]
Internet:       http://people.panthera-systems.net/~daniel-baumann/


--- End Message ---

Reply via email to