Your message dated Sat, 05 Jul 2008 12:47:11 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#485637: fixed in schroot 1.2.1-1 has caused the Debian Bug report #485637, regarding schroot: does not work on GNU/kFreeBSD to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 485637: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485637 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: schroot Severity: important Version: 1.2.0-1 Tags: patch User: [EMAIL PROTECTED] Usertags: kfreebsd Hi, the current version does not work on GNU/kFreeBSD. It is due to different order of elements in "struct flock" on Linux and on GNU/kFreeBSD. The POSIX does not mandate any order of elements, it only lists mandatory members (l_type, l_whence, l_start, l_len, l_pid). http://www.opengroup.org/onlinepubs/009695399/basedefs/fcntl.h.html I tried to use ISO C99 initializer, but it does not work in C++. http://gcc.gnu.org/onlinedocs/gcc-4.3.0/gcc/Designated-Inits.html So please, use attached patch or something similar. Thanks in advance Petronly in patch2: unchanged: --- schroot-1.2.0.orig/sbuild/sbuild-lock.cc +++ schroot-1.2.0/sbuild/sbuild-lock.cc @@ -163,15 +163,25 @@ // destructor under any circumstances. Any error is logged. if (locked) { +#if 0 struct flock read_lock = { - LOCK_NONE, - SEEK_SET, - 0, - 0, // Lock entire file - 0 + .l_type = LOCK_NONE, + .l_whence = SEEK_SET, + .l_start = 0, + .l_len = 0, // Lock entire file + .l_pid = 0 }; +#else + struct flock read_lock; + + read_lock.l_type = LOCK_NONE; + read_lock.l_whence = SEEK_SET; + read_lock.l_start = 0; + read_lock.l_len = 0; // Lock entire file + read_lock.l_pid = 0; +#endif if (fcntl(this->fd, F_SETLK, &read_lock) == -1) log_exception_warning(error(UNLOCK, strerror(errno))); } @@ -195,14 +205,25 @@ /* Wait on lock until interrupted by a signal if a timeout was set, otherwise return immediately. */ +#if 0 struct flock read_lock = { - lock_type, - SEEK_SET, - 0, - 0, // Lock entire file - 0 + .l_type = lock_type, + .l_whence = SEEK_SET, + .l_start = 0, + .l_len = 0, // Lock entire file + .l_pid = 0 }; +#else + struct flock read_lock; + + read_lock.l_type = lock_type; + read_lock.l_whence = SEEK_SET; + read_lock.l_start = 0; + read_lock.l_len = 0; // Lock entire file + read_lock.l_pid = 0; +#endif + if (fcntl(this->fd, (timeout != 0) ? F_SETLKW : F_SETLK,
--- End Message ---
--- Begin Message ---Source: schroot Source-Version: 1.2.1-1 We believe that the bug you reported is fixed in the latest version of schroot, which is due to be installed in the Debian FTP archive: dchroot-dsa_1.2.1-1_powerpc.deb to pool/main/s/schroot/dchroot-dsa_1.2.1-1_powerpc.deb dchroot_1.2.1-1_powerpc.deb to pool/main/s/schroot/dchroot_1.2.1-1_powerpc.deb libsbuild-dev_1.2.1-1_powerpc.deb to pool/main/s/schroot/libsbuild-dev_1.2.1-1_powerpc.deb libsbuild-doc_1.2.1-1_all.deb to pool/main/s/schroot/libsbuild-doc_1.2.1-1_all.deb schroot-common_1.2.1-1_all.deb to pool/main/s/schroot/schroot-common_1.2.1-1_all.deb schroot_1.2.1-1.diff.gz to pool/main/s/schroot/schroot_1.2.1-1.diff.gz schroot_1.2.1-1.dsc to pool/main/s/schroot/schroot_1.2.1-1.dsc schroot_1.2.1-1_powerpc.deb to pool/main/s/schroot/schroot_1.2.1-1_powerpc.deb schroot_1.2.1.orig.tar.gz to pool/main/s/schroot/schroot_1.2.1.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Roger Leigh <[EMAIL PROTECTED]> (supplier of updated schroot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Sat, 05 Jul 2008 11:41:33 +0100 Source: schroot Binary: schroot-common libsbuild-dev libsbuild-doc schroot dchroot dchroot-dsa Architecture: source all powerpc Version: 1.2.1-1 Distribution: unstable Urgency: low Maintainer: Debian buildd-tools Developers <[EMAIL PROTECTED]> Changed-By: Roger Leigh <[EMAIL PROTECTED]> Description: dchroot - Execute commands in a chroot environment dchroot-dsa - Execute commands in a chroot environment libsbuild-dev - development files for the Debian source builder libsbuild-doc - development documentation for the Debian source builder schroot - Execute commands in a chroot environment schroot-common - common files for schroot Closes: 475515 479498 479750 480174 480640 481648 485637 487588 488726 Changes: schroot (1.2.1-1) unstable; urgency=low . * New upstream stable release. * debian/control: - Upgrade to Standards-Version 3.8.0. - Don't Build-Depend upon -1 Debian revisions. * po: - Update eu translation (Closes: #479498). Thanks to Piarres Beobide. - Update fr translation (Closes: #481648). Thanks to Nicolas François. - Update pt translation (Closes: #480640). Thanks to Pedro Ribeiro. - Update vi translation (Closes: #479750). Thanks to Clytie Siddall. - Add zh_CN translation (Closes: #480174). Thanks to LI Daobing (李道兵). - Update zh_CN translation. Thanks to Ji ZhengYu. * sbuild/sbuild-lock.cc: Order of "struct flock" members is not assumed, for GNU/kFreeBSD portability (Closes: #485637). Thanks to Petr Salinger. * schroot.1.in, schroot.conf.5.in: Document /etc/schroot/chroot.d (Closes: #487588). * setup/10mount: Don't clear mount options for LVM snapshots (Closes: #488726). * New "loopback" chroot type allows loopback mounting of files (Closes: #475515). * Checksums-Sha1: fdad8fc3c68ebdcf61ffc660b8b2e233f3d25fd0 1589 schroot_1.2.1-1.dsc 05597a3e592f0454c87c6c0fb80df1ddac842c5a 7479868 schroot_1.2.1.orig.tar.gz 962bdbb42b88a1d791969829e872cbcdf62d2c41 20 schroot_1.2.1-1.diff.gz ba08f9b77990c39391af765eaca3123bfa657508 151350 schroot-common_1.2.1-1_all.deb f273e4642eba98d6ff92515c27b6cc6761bd6b38 3643576 libsbuild-doc_1.2.1-1_all.deb d481cb00c39a146eaf8019b9f4190a4dfc540af4 1293036 libsbuild-dev_1.2.1-1_powerpc.deb c6133ce1c229d7f4a1d755d275d3be91fad5bb16 695302 schroot_1.2.1-1_powerpc.deb cf81fbd2180edc831b312bfe9c8e31a704d08957 290604 dchroot_1.2.1-1_powerpc.deb a32b9a7b20a98b815424129d3a1b15af0764f144 290052 dchroot-dsa_1.2.1-1_powerpc.deb Checksums-Sha256: e1d313d91a15d2320cca35f5d2ea60fd7881539736527f99d0c75296f4937887 1589 schroot_1.2.1-1.dsc 2869dcbd8dcfdf8b714a5221c141fe8f45c04ac661f1427e727a3965d7cf1637 7479868 schroot_1.2.1.orig.tar.gz 3fbddf12260f267f267e7c04b738206f2061ed0f189c0d7b7f595c2dfeef7c9f 20 schroot_1.2.1-1.diff.gz 6f3a86b2c0990db532dc8244dc74b918b91ed860d7c1fd8addb0ab1a7aa65a18 151350 schroot-common_1.2.1-1_all.deb c32341ec3b42720a52b919d2df7b76ca13a2ffd594dd5455b6fadef5e13005e3 3643576 libsbuild-doc_1.2.1-1_all.deb 1d050003d8fd15df08cfa4c1448d5d1fdf41e0ddcf144e130df9011de07c8412 1293036 libsbuild-dev_1.2.1-1_powerpc.deb b19f4dbf0f951c1c767be3c785a0b416f4285f4f5f771aebd778060c1b588f7b 695302 schroot_1.2.1-1_powerpc.deb bf25ac6cc03cc1df400d13f6dea5efc16ffd82f536dbb743ddbe0972a3e88027 290604 dchroot_1.2.1-1_powerpc.deb a19bd31f586249a9e29bbc509c51fd17bfd5f1cb9d1ec81ac0fefaab3cba48f3 290052 dchroot-dsa_1.2.1-1_powerpc.deb Files: b045c75e6e91bca223e1d8bb64606928 1589 admin optional schroot_1.2.1-1.dsc 7c8a758429c5dfa80a6ed721d9fd359d 7479868 admin optional schroot_1.2.1.orig.tar.gz a21b1e305e3999489bf3423bfd1120ef 20 admin optional schroot_1.2.1-1.diff.gz 1d3fe431da750da1aabfe58c708360f3 151350 admin optional schroot-common_1.2.1-1_all.deb 0966b55e850ad6ec9901fe8406f7caf4 3643576 doc optional libsbuild-doc_1.2.1-1_all.deb d154881dc7c9fdd10456879e1163a22d 1293036 libdevel optional libsbuild-dev_1.2.1-1_powerpc.deb 2681b27d40ba05e013f3d519585668e4 695302 admin optional schroot_1.2.1-1_powerpc.deb 7766587e21038de8e27b2b84e524fc60 290604 admin optional dchroot_1.2.1-1_powerpc.deb 9db7db9c5e36250d1d4d6eb3ace0b32e 290052 admin optional dchroot-dsa_1.2.1-1_powerpc.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkhvZ/oACgkQVcFcaSW/uEgtBQCgg/c11vdM3RdFHvZtoBEdOSD6 fiQAn3yPKvXeurIGvWb4p38eOlBG+pml =KoF6 -----END PGP SIGNATURE-----
--- End Message ---
