Your message dated Tue, 15 Jul 2008 23:03:27 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#490095: fixed in lsb 3.2-14 has caused the Debian Bug report #490095, regarding lsb-base: init-functions pidofproc(), status_of_proc() to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 490095: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490095 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: lsb-base Version: 3.2-13 Severity: normal Tags: patch This patch fixes a couple of minor issues with pidofproc() and reverts a patch to status_of_proc(). pidofproc(): * If a pidfile is available, but the euid is not that of the process owner (or root), the "kill -0" call will fail with "Operation not permitted". This patch adds an "elif" block that uses "ps" to check for a matching process in the process table. Note that in cases where the pidfile is not available and /bin/pidof is used, such an ownership check is *not* performed. * The /bin/pidof call needs to "|| status="$?" in order to be "set -e" safe. This is a patch that Ubuntu is carrying and should be applied to Debian. * Also, per [1], pidofproc() should probably return 3 if the program is not running. At least it does at one point in the function, but not in the last return. Ubuntu has also been carrying this patch for some time. status_of_proc(): * So this patch reverts my last one for Bug #483285 (sorry!). That fix was to solve the problem that pidofproc() required privileges to do the "kill -0". At the urging of Matt Zimmerman and Steve Lanagasek, I fixed the problem in pidofproc() instead of hacking around it in status_of_proc(). [1] http://refspecs.linux-foundation.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html -- System Information: Debian Release: lenny/sid Architecture: amd64 (x86_64) Kernel: Linux 2.6.24-19-generic (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash--- lsb.debian/lsb-3.2/init-functions 2008-07-08 22:00:08.000000000 -0500 +++ lsb/lsb-3.2/init-functions 2008-07-09 14:04:45.000000000 -0500 @@ -81,14 +81,17 @@ pidofproc () { if $(kill -0 "${pid:-}" 2> /dev/null); then echo "$pid" return 0 + elif ps "${pid:-}" 2>&1 >/dev/null; then + echo "$pid" + return 0 # program is running, but not owned by this user else return 1 # program is dead and /var/run pid file exists fi fi fi if [ -x /bin/pidof -a ! "$specified" ]; then - /bin/pidof -o %PPID $1 - status="$?" + status="0" + /bin/pidof -o %PPID $1 || status="$?" if [ "$status" = 1 ]; then return 3 # program is not running fi @@ -137,7 +140,7 @@ killproc () { if [ -n "$sig" ]; then return 0 fi - return 0 # program is not running + return 3 # program is not running fi if [ "$status" = 0 -a "$is_term_sig" = yes ]; then @@ -152,18 +155,14 @@ status_of_proc () { daemon="$1" name="$2" status="0" - if [ -x /bin/pidof ]; then - /bin/pidof -o %PPID "$daemon" >/dev/null || status="$?" - if [ "$status" = 0 ]; then - log_success_msg "$name is running." - else - log_failure_msg "$name is not running." - fi + pidofproc $daemon >/dev/null || status="$?" + if [ "$status" = 0 ]; then + log_success_msg "$name is running." + return 0 else - log_failure_msg "/bin/pidof not available." - status="1" + log_failure_msg "$name is not running." + return $status fi - return "$status" } log_use_fancy_output () {
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---Source: lsb Source-Version: 3.2-14 We believe that the bug you reported is fixed in the latest version of lsb, which is due to be installed in the Debian FTP archive: lsb-base_3.2-14_all.deb to pool/main/l/lsb/lsb-base_3.2-14_all.deb lsb-core_3.2-14_amd64.deb to pool/main/l/lsb/lsb-core_3.2-14_amd64.deb lsb-cxx_3.2-14_amd64.deb to pool/main/l/lsb/lsb-cxx_3.2-14_amd64.deb lsb-desktop_3.2-14_amd64.deb to pool/main/l/lsb/lsb-desktop_3.2-14_amd64.deb lsb-graphics_3.2-14_amd64.deb to pool/main/l/lsb/lsb-graphics_3.2-14_amd64.deb lsb-languages_3.2-14_amd64.deb to pool/main/l/lsb/lsb-languages_3.2-14_amd64.deb lsb-multimedia_3.2-14_amd64.deb to pool/main/l/lsb/lsb-multimedia_3.2-14_amd64.deb lsb-printing_3.2-14_amd64.deb to pool/main/l/lsb/lsb-printing_3.2-14_amd64.deb lsb-qt4_3.2-14_amd64.deb to pool/main/l/lsb/lsb-qt4_3.2-14_amd64.deb lsb-release_3.2-14_all.deb to pool/main/l/lsb/lsb-release_3.2-14_all.deb lsb_3.2-14.dsc to pool/main/l/lsb/lsb_3.2-14.dsc lsb_3.2-14.tar.gz to pool/main/l/lsb/lsb_3.2-14.tar.gz lsb_3.2-14_all.deb to pool/main/l/lsb/lsb_3.2-14_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Chris Lawrence <[EMAIL PROTECTED]> (supplier of updated lsb package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Mon, 14 Jul 2008 11:30:52 -0500 Source: lsb Binary: lsb-core lsb-graphics lsb-cxx lsb-desktop lsb-qt4 lsb-languages lsb-multimedia lsb-printing lsb lsb-base lsb-release Architecture: source all amd64 Version: 3.2-14 Distribution: unstable Urgency: low Maintainer: Chris Lawrence <[EMAIL PROTECTED]> Changed-By: Chris Lawrence <[EMAIL PROTECTED]> Description: lsb - Linux Standard Base 3.2 support package lsb-base - Linux Standard Base 3.2 init script functionality lsb-core - Linux Standard Base 3.2 core support package lsb-cxx - Linux Standard Base 3.2 C++ support package lsb-desktop - Linux Standard Base 3.2 Desktop support package lsb-graphics - Linux Standard Base 3.2 graphics support package lsb-languages - Linux Standard Base 3.2 Runtime Languages package lsb-multimedia - Linux Standard Base 3.2 Multimedia package lsb-printing - Linux Standard Base 3.2 Printing package lsb-qt4 - Linux Standard Base 3.2 Qt4 support package lsb-release - Linux Standard Base version reporting utility Closes: 490095 490408 Changes: lsb (3.2-14) unstable; urgency=low . * Update pidofproc(), status_of_proc() to sync with Ubuntu. Thanks to Dustin Kirkland. (Closes: #490095) * Add hooks to init-functions, thanks to Miroslav Jezbera. These are documented in README.Debian in lsb-base. (Closes: #490408) Checksums-Sha1: f4609197906e5a6a36cf74e37b11788d52ba53e0 966 lsb_3.2-14.dsc d31f50433598a9176d24806c214656bc403fd9b3 51396 lsb_3.2-14.tar.gz 4ad36731221fdc5c774b926042e514bbd311391d 13866 lsb_3.2-14_all.deb 9f9df47474dab294d72e8e6d324af27a4b477451 18994 lsb-base_3.2-14_all.deb aa95cf525a1c15ed73c5126b0e9488d9da268907 19266 lsb-release_3.2-14_all.deb 1c7ea5cf6d9ca1a235b746703c13e334e3afbdfd 37078 lsb-core_3.2-14_amd64.deb 587d171d460fa0ab750ca596c4ee858275e64987 13904 lsb-graphics_3.2-14_amd64.deb aac7c52f3df5facd47ed3bfdbc4477e5009b4af3 13866 lsb-cxx_3.2-14_amd64.deb 974fe6b40e1d2e522564abd135851c8fc7f1e675 13996 lsb-desktop_3.2-14_amd64.deb b0383e52a953ba8d66ce011232a8bb3b393e0d7a 13932 lsb-qt4_3.2-14_amd64.deb b9505501ec1c72bb5e160eb98b6f566cd5c6bc77 13890 lsb-languages_3.2-14_amd64.deb 7d832af06ccd4aad436f3d1f27dccf9805a8416d 13876 lsb-multimedia_3.2-14_amd64.deb 03c799b2f0b7fb6208f51fa58fa5c8b36a88cb95 13900 lsb-printing_3.2-14_amd64.deb Checksums-Sha256: f5d32b17e2f3e22c74b5a41fcc574128e9ca0384dcdbea0a10f19b43786e05eb 966 lsb_3.2-14.dsc 8f758a876ac9d1a06a3a22b0ce385d2d7bd6d6415cb2a46aa8079060447cb135 51396 lsb_3.2-14.tar.gz f10cf14da24743a63274c1a9b2f5e4028dedb39738900dbeadd532e86f43d127 13866 lsb_3.2-14_all.deb 4462cb91106f4d04b7af2e6c0393c486ca0e42c870b1936340d4235cd270db3f 18994 lsb-base_3.2-14_all.deb 662ff3224440e6a506d734717d366112c9a77931bf450797e04a6f62f9f69c90 19266 lsb-release_3.2-14_all.deb c9c5517dd58685eb2946a7278c8451b1df176244cdecf7a99ce96809758fa183 37078 lsb-core_3.2-14_amd64.deb bdcf4d596badb4ac156404f81b07d935aca55386c2ace56202a73d294543f2d6 13904 lsb-graphics_3.2-14_amd64.deb f2dc23bb2863532933f67d67fd0951d7cb29e1f92b0ac73901af4a50b2d4c9a9 13866 lsb-cxx_3.2-14_amd64.deb 8db98674e85e5038acfa0f95213f48a2fb7c9c84ba7e28cb760164c351bd9b8e 13996 lsb-desktop_3.2-14_amd64.deb 765d597aef5b54e4a96d6b00a12b24e8c845390f146a20f2bf445a987cc1adeb 13932 lsb-qt4_3.2-14_amd64.deb d63a8500c18bbc6da52f25f243daac0fed47fd9fc490ad319c2af1072efa14ce 13890 lsb-languages_3.2-14_amd64.deb b17acde1b21e31f7e79801e3f2b1c2e31199f2783632dba30923f2f0bf25a52d 13876 lsb-multimedia_3.2-14_amd64.deb d42fdb80b00d7204c61ac5e7ae142e1646af2c2a01084432bc87b8e2c9d47b18 13900 lsb-printing_3.2-14_amd64.deb Files: 833425b6984c280afe3fa75df3b109fa 966 misc extra lsb_3.2-14.dsc a7d5548217a56e26fc8007819167d7bf 51396 misc extra lsb_3.2-14.tar.gz e1f2fbf1ccf197ff314d7589e99ebd06 13866 misc extra lsb_3.2-14_all.deb 11bb2c8d50bc7720ad7c4f2203426e9f 18994 misc required lsb-base_3.2-14_all.deb 3c7a89843a0bdf6415e8d4166d31f878 19266 misc extra lsb-release_3.2-14_all.deb 413546030ae85c43e12a1b92ee0a02e0 37078 misc extra lsb-core_3.2-14_amd64.deb e16862111bcc60e79714bb72dde2262a 13904 misc extra lsb-graphics_3.2-14_amd64.deb b95a2dcac1963feeef3d50857dfb971d 13866 misc extra lsb-cxx_3.2-14_amd64.deb c889780818bf0945324095954817ce1e 13996 misc extra lsb-desktop_3.2-14_amd64.deb 9e6a60eba4bba21c6004b46552770c95 13932 misc extra lsb-qt4_3.2-14_amd64.deb c68ac445f3a3bb24eccad7d9606266cb 13890 misc extra lsb-languages_3.2-14_amd64.deb a84b2bc28a326fdf093c772d5470bef9 13876 misc extra lsb-multimedia_3.2-14_amd64.deb 566b2c1f893cffd7673f8e2b51c5c8b4 13900 misc extra lsb-printing_3.2-14_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkh7gJ4ACgkQ2wQKE6PXubwdeACeKSQ0Nxq/ajCJJir1ujzq+eHv aIgAoL6geURU4VxJcS7Zu6SGlu52q9Kw =cGKO -----END PGP SIGNATURE-----
--- End Message ---
