Your message dated Tue, 22 Jul 2008 07:47:05 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#486378: fixed in sitecopy 1:0.16.6-1 has caused the Debian Bug report #486378, regarding [sitecopy] Crash on a progress bar because of the use of deprecated API to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 486378: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=486378 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: sitecopy Version: 1:0.16.3-17 Severity: important Tags: patch --- Please enter the report below this line. --- I experimented several crashes with sitecopy and decided to track them down. I found out that the progress bar of libneon was somehow involved. It seems that even though the DISABLE_PROGRESS macro has been called the progress bar seems to keep stay active from time to time. Looking more precisely at the libneon API, I found out that ne_set_progress was deprecated. See src/ne_session.h:102 which states that: /* DEPRECATED API: Set a progress callback for the session; this is * deprecated in favour of ne_set_notifier(). The progress callback * is invoked for after each block of the request and response body to * indicate request and response progress (there is no way to * distinguish between the two using this interface alone). * * NOTE: Use of this interface is mutually exclusive with the use of * ne_set_notifier(). A call to ne_set_progress() removes the * notifier callback, and vice versa. */ void ne_set_progress(ne_session *sess, ne_progress progress, void *userdata); I tried out to change the ENABLE_PROGRESS/DISABLE_PROGRESS for the new API call (ne_set_notifier) and it went nicely on all my problematic examples. Therefore, I suggest the following patch: =================================================== diff -ruN sitecopy-0.16.3-orig/src/davdriver.c sitecopy-0.16.3/src/davdriver.c --- sitecopy-0.16.3-orig/src/davdriver.c 2008-06-15 19:22:12.000000000 +0200 +++ sitecopy-0.16.3/src/davdriver.c 2008-06-15 19:23:54.000000000 +0200 @@ -62,9 +62,9 @@ const char *root; }; -#define ENABLE_PROGRESS do { ne_set_progress(sess, site_sock_progress_cb, NULL); } while (0) +#define ENABLE_PROGRESS do { ne_set_notifier(sess, site_sock_progress_cb, NULL); } while (0) -#define DISABLE_PROGRESS do { ne_set_progress(sess, NULL, NULL); } while (0) +#define DISABLE_PROGRESS do { ne_set_notifier(sess, NULL, NULL); } while (0) /* TODO: * not really sure whether we should be using an enum here... what =================================================== *** Please apply *** --- System information. --- Architecture: i386 Kernel: Linux 2.6.25.4 Debian Release: lenny/sid 500 unstable ftp.fr.debian.org --- Package information. --- Depends (Version) | Installed =========================-+-============ libc6 (>= 2.7-1) | 2.7-12 libneon27 (>= 0.28.1) | 0.28.2-2
--- End Message ---
--- Begin Message ---Source: sitecopy Source-Version: 1:0.16.6-1 We believe that the bug you reported is fixed in the latest version of sitecopy, which is due to be installed in the Debian FTP archive: sitecopy_0.16.6-1.diff.gz to pool/main/s/sitecopy/sitecopy_0.16.6-1.diff.gz sitecopy_0.16.6-1.dsc to pool/main/s/sitecopy/sitecopy_0.16.6-1.dsc sitecopy_0.16.6-1_i386.deb to pool/main/s/sitecopy/sitecopy_0.16.6-1_i386.deb sitecopy_0.16.6.orig.tar.gz to pool/main/s/sitecopy/sitecopy_0.16.6.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sandro Tosi <[EMAIL PROTECTED]> (supplier of updated sitecopy package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Tue, 22 Jul 2008 07:31:05 +0200 Source: sitecopy Binary: sitecopy Architecture: source i386 Version: 1:0.16.6-1 Distribution: unstable Urgency: low Maintainer: [EMAIL PROTECTED] Changed-By: Sandro Tosi <[EMAIL PROTECTED]> Description: sitecopy - A program for managing a WWW site via FTP, DAV or HTTP Closes: 410703 486378 Changes: sitecopy (1:0.16.6-1) unstable; urgency=low . * New upstream release - fix a crash with progress bar enabled; Closes: #486378 * debian/control - set myself as maintainer, Kartik as uploader - set Vcs-{Browser,Git} fields - bump Standards-Version to 3.8.0 + debian/README.source added - added DM-Upload-Allowed flag * debian/patches/05_libneon27_transition.dpatch - removed since merged upstream * debian/copyrightdebian/copyright - updated upstream email and copyright years * debian/patches/10_bts410703_preserve_storage_files_sigint.dpatch - added to preserve storage files if SIGINT (Ctrl+C) is sent to sitecopy; thanks to Andreas Henriksson for the patch; Closes: #410703 Checksums-Sha1: 31d8836f8b2353c45969217e8cf5e363c170669f 1343 sitecopy_0.16.6-1.dsc 2de3679d98c31331f48ff10e824c615a180f2d3b 1022265 sitecopy_0.16.6.orig.tar.gz ddfd6b6bb3c1889938584f1191d34e876f205f4d 23748 sitecopy_0.16.6-1.diff.gz f448d86a7185cfcf6cc3bb0d09d105fb424bb3c6 138744 sitecopy_0.16.6-1_i386.deb Checksums-Sha256: 9c44accec5ee170cbd799085e0dd3c7ad3824a9ab801f9cb166accdbd0995e55 1343 sitecopy_0.16.6-1.dsc e06fdda007e54ddc6fae90a4e79768e5bfb7770c1139bcaac2e10d841d7458af 1022265 sitecopy_0.16.6.orig.tar.gz 5795cd2b04786bccf300b9c170b89159c5f04c931d6613717b40448a4bd061f6 23748 sitecopy_0.16.6-1.diff.gz 4ad353bfa269cd75f8dc76bb0b3457a148e0c612481689ec12c32bfd99693875 138744 sitecopy_0.16.6-1_i386.deb Files: 4d9418f003f71bb0314eff67a75c99c9 1343 web extra sitecopy_0.16.6-1.dsc b3aeb5a5f00af3db90b408e8c32a6c01 1022265 web extra sitecopy_0.16.6.orig.tar.gz 708389e1b6fafe72fa8d3e8d407ef8f3 23748 web extra sitecopy_0.16.6-1.diff.gz 5671efe0ee8d63eaee1ec648f59478f3 138744 web extra sitecopy_0.16.6-1_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iD8DBQFIhYyfB9xWPR9BuQcRAkhYAKCC3qqn8CgubE/jJjJ0UVAEJkd3OgCgkgMV qwhkI2nJJf4qmZ6bWaGaD80= =dq6Q -----END PGP SIGNATURE-----
--- End Message ---
