Your message dated Thu, 07 Aug 2008 16:47:03 +0000 with message-id <[EMAIL PROTECTED]> and subject line Bug#487217: fixed in wbxml2 0.9.2-5 has caused the Debian Bug report #487217, regarding libwbxml2-0: Several SyncML flaws to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [EMAIL PROTECTED] immediately.) -- 487217: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=487217 Debian Bug Tracking System Contact [EMAIL PROTECTED] with problems
--- Begin Message ---Package: libwbxml2-0 Version: 0.9.2-4 Severity: important I'm one of the upstream maintainers of libsyncml. I found several flaws in the wbxml library in respect to correct handling of SyncML. Below are short descriptions to every file which must be patched. Patches are attached. wbxml_encoder.c: incomplete SyncML 1.2 detection wbxml_tables.c: wrong namespaces (the specifications of SyncML require big letters) (e.g. SYNCML:SYNCML1.1 and not syncml:SYNCML1.1) wbxml_tree.c: missing debug statement in case of an error missing content type (function is used by XML and WBXML callbacks) wbxml_tree_clb_xml.c: localName includes the namespace of a tag (syncml:devinf:DevInf) the XML parser needs the document type to determine the code pages Additionally I will send the patches to the upstream maintainer of the library too ([EMAIL PROTECTED]). -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.25-2-686 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages libwbxml2-0 depends on: ii libc6 2.7-11 GNU C Library: Shared libraries ii libexpat1 1.95.8-4 XML parsing C library - runtime li ii libpopt0 1.10-3 lib for parsing cmdline parameters ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime libwbxml2-0 recommends no packages. -- no debconf informationdiff -ru wbxml2-0.9.2-original/src/wbxml_encoder.c wbxml2-0.9.2/src/wbxml_encoder.c --- wbxml2-0.9.2-original/src/wbxml_encoder.c 2006-07-11 13:47:45.000000000 +0200 +++ wbxml2-0.9.2/src/wbxml_encoder.c 2008-06-20 11:24:17.000000000 +0200 @@ -1936,7 +1936,8 @@ #if defined( WBXML_SUPPORT_SYNCML ) /* If this is a SyncML document ? */ if ((encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML10) || - (encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML11)) + (encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML11) || + (encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML12)) { /** @todo We must check too if we are in a <Type> */ @@ -4019,7 +4020,8 @@ #if defined( WBXML_SUPPORT_SYNCML ) /* Change text in <Type> from "application/vnd.syncml-devinf+wbxml" to "application/vnd.syncml-devinf+xml" */ if (((encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML10) || - (encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML11)) && + (encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML11) || + (encoder->lang->langID == WBXML_LANG_SYNCML_SYNCML12)) && (encoder->current_tag != NULL) && (encoder->current_tag->wbxmlCodePage == 0x01 ) && (encoder->current_tag->wbxmlToken == 0x13 ) && diff -ru wbxml2-0.9.2-original/src/wbxml_tables.c wbxml2-0.9.2/src/wbxml_tables.c --- wbxml2-0.9.2-original/src/wbxml_tables.c 2006-07-11 13:47:45.000000000 +0200 +++ wbxml2-0.9.2/src/wbxml_tables.c 2008-06-20 11:28:18.000000000 +0200 @@ -1601,21 +1601,21 @@ #if defined( WBXML_SUPPORT_SYNCML ) const WBXMLNameSpaceEntry sv_syncml_syncml10_ns_table[] = { - { "syncml:SYNCML1.0", 0x00 }, /**< Code Page 0: SYNCML1.0 */ + { "SYNCML:SYNCML1.0", 0x00 }, /**< Code Page 0: SYNCML1.0 */ { "syncml:metinf", 0x01 }, /**< Code Page 1: metinf */ { NULL, 0x00 } }; const WBXMLNameSpaceEntry sv_syncml_syncml11_ns_table[] = { - { "syncml:SYNCML1.1", 0x00 }, /**< Code Page 0: SYNCML1.1 */ + { "SYNCML:SYNCML1.1", 0x00 }, /**< Code Page 0: SYNCML1.1 */ { "syncml:metinf", 0x01 }, /**< Code Page 1: metinf */ { NULL, 0x00 } }; const WBXMLNameSpaceEntry sv_syncml_syncml12_ns_table[] = { - { "syncml:SYNCML1.2", 0x00 }, /**< Code Page 0: SYNCML1.2 */ + { "SYNCML:SYNCML1.2", 0x00 }, /**< Code Page 0: SYNCML1.2 */ { "syncml:metinf", 0x01 }, /**< Code Page 1: metinf */ { NULL, 0x00 } }; diff -ru wbxml2-0.9.2-original/src/wbxml_tree.c wbxml2-0.9.2/src/wbxml_tree.c --- wbxml2-0.9.2-original/src/wbxml_tree.c 2006-07-11 13:47:45.000000000 +0200 +++ wbxml2-0.9.2/src/wbxml_tree.c 2008-06-20 11:33:54.000000000 +0200 @@ -244,7 +244,10 @@ } else { if ((ret = wbxml_tree_clb_ctx.error) != WBXML_OK) + { + WBXML_ERROR((WBXML_CONV, "xml2wbxml conversion failed - context error %i", ret)); wbxml_tree_destroy(wbxml_tree_clb_ctx.tree); + } else *tree = wbxml_tree_clb_ctx.tree; } @@ -798,11 +801,20 @@ { /* Check <Type> value */ if ((tmp_node->children != NULL) && (tmp_node->children->type == WBXML_TREE_TEXT_NODE)) { + /* This function is used by wbxml and xml callbacks. + * So content types must be handled for both situations. + */ + /* application/vnd.syncml-devinf+wbxml */ if (wbxml_buffer_compare_cstr(tmp_node->children->content, "application/vnd.syncml-devinf+wbxml") == 0) { return WBXML_SYNCML_DATA_TYPE_WBXML; } + /* application/vnd.syncml-devinf+xml */ + if (wbxml_buffer_compare_cstr(tmp_node->children->content, "application/vnd.syncml-devinf+xml") == 0) { + return WBXML_SYNCML_DATA_TYPE_NORMAL; + } + /* text/clear */ if (wbxml_buffer_compare_cstr(tmp_node->children->content, "text/clear") == 0) { return WBXML_SYNCML_DATA_TYPE_CLEAR; diff -ru wbxml2-0.9.2-original/src/wbxml_tree_clb_xml.c wbxml2-0.9.2/src/wbxml_tree_clb_xml.c --- wbxml2-0.9.2-original/src/wbxml_tree_clb_xml.c 2006-07-11 13:47:46.000000000 +0200 +++ wbxml2-0.9.2/src/wbxml_tree_clb_xml.c 2008-06-20 11:39:27.000000000 +0200 @@ -142,7 +142,7 @@ #if defined( WBXML_SUPPORT_SYNCML ) /* If this is an embedded (not root) "DevInf" document, skip it */ - if ((WBXML_STRCMP(localName, "DevInf") == 0) && + if ((WBXML_STRCMP(localName, "syncml:devinf:DevInf") == 0) && (tree_ctx->current != NULL)) { tree_ctx->skip_start = XML_GetCurrentByteIndex(tree_ctx->xml_parser); @@ -192,7 +192,7 @@ /* End of skipped node */ #if defined( WBXML_SUPPORT_SYNCML ) - if (WBXML_STRCMP(localName, "DevInf") == 0) { + if (WBXML_STRCMP(localName, "syncml:devinf:DevInf") == 0) { /* Get embedded DevInf Document */ devinf_doc = wbxml_buffer_create(tree_ctx->input_buff + tree_ctx->skip_start, XML_GetCurrentByteIndex(tree_ctx->xml_parser) - tree_ctx->skip_start, @@ -210,6 +210,16 @@ return; } + /* Add doctype to give the XML parser a chance + * SyncML 1.2 is downward compatible to older versions. + */ + if (!wbxml_buffer_insert_cstr(devinf_doc, "<!DOCTYPE DevInf PUBLIC '-//SYNCML//DTD DevInf 1.2//EN' 'http://www.openmobilealliance.org/tech/DTD/OMA-SyncML-Device_Information-DTD-1.2.dtd' >\n", 0)) + { + tree_ctx->error = WBXML_ERROR_NOT_ENOUGH_MEMORY; + wbxml_buffer_destroy(devinf_doc); + return; + } + WBXML_DEBUG((WBXML_PARSER, "\t DevInf Doc : '%s'", wbxml_buffer_get_cstr(devinf_doc))); /* Parse 'DevInf' Document */
--- End Message ---
--- Begin Message ---Source: wbxml2 Source-Version: 0.9.2-5 We believe that the bug you reported is fixed in the latest version of wbxml2, which is due to be installed in the Debian FTP archive: libwbxml2-0-dbg_0.9.2-5_i386.deb to pool/main/w/wbxml2/libwbxml2-0-dbg_0.9.2-5_i386.deb libwbxml2-0_0.9.2-5_i386.deb to pool/main/w/wbxml2/libwbxml2-0_0.9.2-5_i386.deb libwbxml2-dev_0.9.2-5_i386.deb to pool/main/w/wbxml2/libwbxml2-dev_0.9.2-5_i386.deb libwbxml2-utils_0.9.2-5_i386.deb to pool/main/w/wbxml2/libwbxml2-utils_0.9.2-5_i386.deb wbxml2_0.9.2-5.diff.gz to pool/main/w/wbxml2/wbxml2_0.9.2-5.diff.gz wbxml2_0.9.2-5.dsc to pool/main/w/wbxml2/wbxml2_0.9.2-5.dsc A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Michael Banck <[EMAIL PROTECTED]> (supplier of updated wbxml2 package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Wed, 06 Aug 2008 18:00:34 +0200 Source: wbxml2 Binary: libwbxml2-dev libwbxml2-0-dbg libwbxml2-0 libwbxml2-utils Architecture: source i386 Version: 0.9.2-5 Distribution: unstable Urgency: low Maintainer: Michael Banck <[EMAIL PROTECTED]> Changed-By: Michael Banck <[EMAIL PROTECTED]> Description: libwbxml2-0 - WBXML parsing and encoding library libwbxml2-0-dbg - WBXML library development file libwbxml2-dev - WBXML library development file libwbxml2-utils - Binary XML utilities Closes: 487217 493436 Changes: wbxml2 (0.9.2-5) unstable; urgency=low . * New maintainer. + debian/control (Maintainer): Set to myself. * debian/control (Standards-Version): Bumped to 3.8.0. * debian/control (libwbxml2-utils/Description): Make the short description a bit more readable; closes: #493436. * debian/patches/05-syncml-fixes.patch: New patch, fixes a couple of issues with SyncML, by Michael Bell; closes: #487217. Checksums-Sha1: 8eab8ce8a3fb583c09308821fbebc134b87d00a9 1120 wbxml2_0.9.2-5.dsc 477d0997d1b5821a5a252a780551ee7025c33b5c 10567 wbxml2_0.9.2-5.diff.gz b9adaa7d81e0855a1516e5b80360b9b36a64410a 90842 libwbxml2-dev_0.9.2-5_i386.deb d3e27601161889ee9c3b2e95a059524e1e192f60 88184 libwbxml2-0-dbg_0.9.2-5_i386.deb ecf5f5218cd4538cd433914ff015f5e8eb7d6785 66996 libwbxml2-0_0.9.2-5_i386.deb 58a573a1e3c7cd3046e7f7442f5141bbf2a978eb 21102 libwbxml2-utils_0.9.2-5_i386.deb Checksums-Sha256: bed047f1620af5227227a9332162b340ffbd1c91c94625fa740cb3ebcd00352c 1120 wbxml2_0.9.2-5.dsc dc68717104be95640b7e28a97734b77bfe66ce6b4c3062d0edd8400b2ff5d3dd 10567 wbxml2_0.9.2-5.diff.gz 6c7ff8a05a266cb864222a12238c851ed5b62a19a04eb2a9faf6f481ab768cf9 90842 libwbxml2-dev_0.9.2-5_i386.deb 2efade873928ef949d5df076fecd18ac2cb2e3248d74a0bc05bbe76879a543b3 88184 libwbxml2-0-dbg_0.9.2-5_i386.deb 24222dc417f3f68978d7002070defdd2d8381c985ccdd22525c352932b0439d0 66996 libwbxml2-0_0.9.2-5_i386.deb b5787be9e9e49a3088206322a663d53f20195ef51deae42b2a7b044b24941fb7 21102 libwbxml2-utils_0.9.2-5_i386.deb Files: 761630f22e461a73a7e9bbc0b4c8677b 1120 libs optional wbxml2_0.9.2-5.dsc 9e99ad1caa15eafd6c8aa5b0acac30c3 10567 libs optional wbxml2_0.9.2-5.diff.gz 65666351c5b8bd5cad3091f89f768b5b 90842 libdevel optional libwbxml2-dev_0.9.2-5_i386.deb 06d672c71f5d7004db0fba0c97b3abae 88184 libdevel extra libwbxml2-0-dbg_0.9.2-5_i386.deb 27f1daaa2a90711becc8d523e2e14827 66996 libs optional libwbxml2-0_0.9.2-5_i386.deb 2a5c0b852790fe1dbd41c724e7ec8dd8 21102 text optional libwbxml2-utils_0.9.2-5_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFImyR/mHaJYZ7RAb8RAgqdAKCOmuR4j5wWMlGpEYh4QjgHXi8SrwCeK6fg BnKYp1aAK5+rmzjPHA4cMFw= =o35g -----END PGP SIGNATURE-----
--- End Message ---
