Your message dated Mon, 08 Sep 2008 17:17:02 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#498226: fixed in dbconfig-common 1.8.40
has caused the Debian Bug report #498226,
regarding misses documentation on depends
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
498226: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498226
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: dbconfig-common
Version: 1.8.39
Severity: normal
Tags: patch

Hi Sean,

dbconfig-common doesn't document that you need to add client dependencies
to your package. I've done so in attached patch, both in the doc itself as
in the example packages.

I've chosen to Recommend the packages since they are not strictly
required: the admin that refuses the entire dbconfig-common process will
not need them. I've also moved the server Recommends to Suggests.

The patch also fixes two typos I came across, let me know if you want them
separated out.

One final thing, the file examples/db-test-sqlite3-2.0/debian/rules needs
to have the svn:executable property set in the repository, now it fails to
build after a checkout.

cheers,
Thijs
Index: debian/po/nl.po
===================================================================
--- debian/po/nl.po	(revision 461)
+++ debian/po/nl.po	(working copy)
@@ -382,7 +382,7 @@
 "help, this was the error encountered:"
 msgstr ""
 "Er is een fout opgetreden tijdens het opwaarderen van de database. Mocht u "
-"geïnteresseerd zijnj, dit is de tegengekomen foutmelding:"
+"geïnteresseerd zijn, dit is de tegengekomen foutmelding:"
 
 #. Type: select
 #. Description
Index: doc/dbconfig-common.sgml
===================================================================
--- doc/dbconfig-common.sgml	(revision 461)
+++ doc/dbconfig-common.sgml	(working copy)
@@ -75,6 +75,12 @@
 		creation, upgrade/remove/purge logic, et c.  after all,
 		the goal of <package>dbconfig-common</package> is to make life easier for
 		both the local admin <em>and</em> the package maintainer :)
+		<sect1 id="depends">update package dependencies
+			<p>
+			Your package needs to depend on <package>dbconfig-common</package>.
+			Also you should add Recommends for the command line client packages
+			of the database types you support, e.g. <package>mysql-client</package> or
+			<package>postgresql-client</package>.
 		<sect1 id="hooks">putting hooks into the maintainer scripts
 			<p>
 			in the <var>config</var>, <var>postinst</var>,
Index: internal/common
===================================================================
--- internal/common	(revision 461)
+++ internal/common	(working copy)
@@ -135,7 +135,7 @@
 		"mysql"|"psql"|"sqlite"|"sqlite3")
 			if ! _dbc_detect_installed_dbtype $1; then
 				dbc_error="No $1 client to execute.  (have
-				       you installed the ${dbc_dbclientpackage:-$1} package?"
+				       you installed the ${dbc_dbclientpackage:-$1} package?)"
 				dbc_logline "sanity check failed for $1"
 				return 1
 			fi
Index: examples/db-test-multidbtype-2.0/debian/control
===================================================================
--- examples/db-test-multidbtype-2.0/debian/control	(revision 461)
+++ examples/db-test-multidbtype-2.0/debian/control	(working copy)
@@ -8,7 +8,8 @@
 Package: db-test-multidbtype
 Architecture: all
 Depends: dbconfig-common
-Recommends: mysql-server | postgresql
+Recommends: mysql-client | postgresql-client | sqlite | sqlite3
+Suggests: mysql-server | postgresql
 Description: a package to test dbconfig-common (generic version)
  this is a package to test the dbconfig-common package.  
  .
Index: examples/db-test-mysql-frontend-2.0/debian/control
===================================================================
--- examples/db-test-mysql-frontend-2.0/debian/control	(revision 461)
+++ examples/db-test-mysql-frontend-2.0/debian/control	(working copy)
@@ -8,7 +8,8 @@
 Package: db-test-mysql-frontend
 Architecture: all
 Depends: dbconfig-common
-Recommends: mysql-server
+Recommends: mysql-client
+Suggests: mysql-server
 Description: a package to test dbconfig-common (mysql version)
  this is a package to test the dbconfig-common package.  
  .

Property changes on: examples/db-test-sqlite3-2.0/debian/rules
___________________________________________________________________
Added: svn:executable
   + *

Index: examples/db-test-mysql-2.0/debian/control
===================================================================
--- examples/db-test-mysql-2.0/debian/control	(revision 461)
+++ examples/db-test-mysql-2.0/debian/control	(working copy)
@@ -8,7 +8,8 @@
 Package: db-test-mysql
 Architecture: all
 Depends: dbconfig-common
-Recommends: mysql-server
+Recommends: mysql-client
+Suggests: mysql-server
 Description: a package to test dbconfig-common (mysql version)
  this is a package to test the dbconfig-common package.  
  .
Index: examples/db-test-mysql-perl-2.0/debian/control
===================================================================
--- examples/db-test-mysql-perl-2.0/debian/control	(revision 461)
+++ examples/db-test-mysql-perl-2.0/debian/control	(working copy)
@@ -8,7 +8,8 @@
 Package: db-test-mysql-perl
 Architecture: all
 Depends: dbconfig-common, libdbd-mysql-perl
-Recommends: mysql-server
+Recommends: mysql-client
+Suggests: mysql-server
 Description: a package to test dbconfig-common (mysql+perl version)
  this is a package to test the dbconfig-common package.  
  .
Index: examples/db-test-pgsql-migration-1.9/debian/control
===================================================================
--- examples/db-test-pgsql-migration-1.9/debian/control	(revision 461)
+++ examples/db-test-pgsql-migration-1.9/debian/control	(working copy)
@@ -7,7 +7,8 @@
 
 Package: db-test-pgsql-migration
 Architecture: all
-Recommends: postgresql
+Recommends: postgresql-client
+Suggests: postgresql
 Description: a package to test dbconfig-common (migration version)
  this is a package to test the dbconfig-common package.  
  .
Index: examples/db-test-mysql-2.1/debian/control
===================================================================
--- examples/db-test-mysql-2.1/debian/control	(revision 461)
+++ examples/db-test-mysql-2.1/debian/control	(working copy)
@@ -8,7 +8,8 @@
 Package: db-test-mysql
 Architecture: all
 Depends: dbconfig-common
-Recommends: mysql-server
+Recommends: mysql-client
+Suggests: mysql-server
 Description: a package to test dbconfig-common (mysql version)
  this is a package to test the dbconfig-common package.  
  .
Index: examples/db-test-pgsql-2.0/debian/control
===================================================================
--- examples/db-test-pgsql-2.0/debian/control	(revision 461)
+++ examples/db-test-pgsql-2.0/debian/control	(working copy)
@@ -7,8 +7,9 @@
 
 Package: db-test-pgsql
 Architecture: all
-Recommends: postgresql
 Depends: dbconfig-common
+Recommends: postgresql-client
+Suggests: postgresql
 Description: a package to test dbconfig-common (pgsql version)
  this is a package to test the dbconfig-common package.  
  .
Index: examples/db-test-pgsql-migration-2.0/debian/control
===================================================================
--- examples/db-test-pgsql-migration-2.0/debian/control	(revision 461)
+++ examples/db-test-pgsql-migration-2.0/debian/control	(working copy)
@@ -7,8 +7,9 @@
 
 Package: db-test-pgsql-migration
 Architecture: all
-Recommends: postgresql
 Depends: dbconfig-common
+Recommends: postgresql-client
+Suggests: postgresql
 Description: a package to test dbconfig-common (migration version)
  this is a package to test the dbconfig-common package.  
  .

--- End Message ---
--- Begin Message ---
Source: dbconfig-common
Source-Version: 1.8.40

We believe that the bug you reported is fixed in the latest version of
dbconfig-common, which is due to be installed in the Debian FTP archive:

dbconfig-common_1.8.40.dsc
  to pool/main/d/dbconfig-common/dbconfig-common_1.8.40.dsc
dbconfig-common_1.8.40.tar.gz
  to pool/main/d/dbconfig-common/dbconfig-common_1.8.40.tar.gz
dbconfig-common_1.8.40_all.deb
  to pool/main/d/dbconfig-common/dbconfig-common_1.8.40_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sean Finney <[EMAIL PROTECTED]> (supplier of updated dbconfig-common package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 08 Sep 2008 18:36:54 +0200
Source: dbconfig-common
Binary: dbconfig-common
Architecture: source all
Version: 1.8.40
Distribution: unstable
Urgency: low
Maintainer: Sean Finney <[EMAIL PROTECTED]>
Changed-By: Sean Finney <[EMAIL PROTECTED]>
Description: 
 dbconfig-common - common framework for packaging database applications
Closes: 498226 498226
Changes: 
 dbconfig-common (1.8.40) unstable; urgency=low
 .
   * Fixes from Thijs Kinkhorst:
     - fix for spelling error in debian/po/nl.po
     - fix for typo in internal/common
     - update documentation and examples to be more explicit about dependencies,
       recommends, and suggests (closes: #498226).
     - add Vcs-* headers to control file (closes: #498226).
Checksums-Sha1: 
 f2b7bd08b390fb50dc2269e7c348f91ea465b962 1000 dbconfig-common_1.8.40.dsc
 3c917a881ae8775eb4b255c2085bfebf8b654938 334762 dbconfig-common_1.8.40.tar.gz
 a9349c9291032233c9af7c5eca643d60b3ed6b34 488204 dbconfig-common_1.8.40_all.deb
Checksums-Sha256: 
 6fd4d7bc10cdacbfda81ae92f8d432c72513b1da4d88e22cc90977798063ebcd 1000 
dbconfig-common_1.8.40.dsc
 5c901775f39b3ee1074e92c9a9cf48fb0289737089e3224fe3e6ef8dea6c448d 334762 
dbconfig-common_1.8.40.tar.gz
 81829e5f074fab429f626b351ae5ff43083cc23e0eda3d5ea68c2aad633a820f 488204 
dbconfig-common_1.8.40_all.deb
Files: 
 52c5769adb875643482c34b5f8c8c286 1000 admin optional dbconfig-common_1.8.40.dsc
 a71b2df3fc1d359208122ea9a577946f 334762 admin optional 
dbconfig-common_1.8.40.tar.gz
 1bf2a8c17c18e837f880c93f193990d4 488204 admin optional 
dbconfig-common_1.8.40_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFIxVniynjLPm522B0RAhW+AJ9nj9Vh/GuvpRDQQyrjsH8iZObCXgCfblug
DSQjB35bLW7vN0i31AUQ1Ig=
=zeQt
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to