Your message dated Fri, 12 Sep 2008 16:02:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#497295: fixed in rebuildd 0.3.5
has caused the Debian Bug report #497295,
regarding rebuildd: Support passing other pbuilder options to 
rebuildd-init-build-system
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
497295: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=497295
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: rebuildd
Version: 0.3.5
Severity: wishlist
Tags: patch

Hi,

it would be nice to be able to pass more pbuilder options to the build
init script, for example by adding:

PBUILDER_OTHER_OPTIONS[0]="--components=main contrib"
PBUILDER_OTHER_OPTIONS[1]="--othermirror=deb http://my.apt.repo sid main"

to /etc/default/rebuildd.

Attached you find a patch that implements this feature. Unfortunately
it makes use of Bash arrays, which are not supported by dash, so that
I had to change the shell from "/bin/sh" to "/bin/bash".

I didn't find a simple way to get the same result with dash, pbuilder
itself uses bash (head -1 /usr/sbin/pbuilder), probably for the same
reason, as /etc/pbuilderrc make use of Bash arrays as well for the
DEBOOTSTRAPOPTS variable.

Ciao,

Free

diff --git a/debian/rebuildd.default b/debian/rebuildd.default
index e690123..f9317b7 100644
--- a/debian/rebuildd.default
+++ b/debian/rebuildd.default
@@ -20,6 +20,10 @@ PBUILDER_BIN=/usr/sbin/pbuilder
 # Default Debian mirror
 # PBUILDER_MIRROR=http://ftp.debian.org/debian
 
+# Pass other options to pbuilder
+# PBUILDER_OTHER_OPTIONS[0]="--components=main contrib"
+# PBUILDER_OTHER_OPTIONS[1]="--othermirror=deb http://my.apt.repo sid main"
+
 # Distributions to generate and manage
 ARCHS="$(dpkg --print-architecture)"
 DISTS="etch lenny sid"
diff --git a/rebuildd-init-build-system b/rebuildd-init-build-system
index cd87b45..c326ccc 100755
--- a/rebuildd-init-build-system
+++ b/rebuildd-init-build-system
@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/bash
 
 # Exit on errors
 set -e
@@ -7,6 +7,7 @@ set -e
 PBUILDER_BIN="/usr/sbin/pbuilder"
 PBUILDER_CACHE_PATH="/var/cache/pbuilder"
 PBUILDER_MIRROR="http://ftp.debian.org/debian";
+PBUILDER_OTHER_OPTIONS=()
 
 if [ -f /etc/default/rebuildd ]
 then
@@ -27,7 +28,7 @@ pbuilder_create ()
             for a in $ARCHS
             do
                 echo "I: Initializing pbuilder for ${d}-${a}"
-                $PBUILDER_BIN create --debootstrapopts --arch=$a --basetgz 
$PBUILDER_CACHE_PATH/${d}-${a}.tgz --distribution $d --mirror $PBUILDER_MIRROR
+                $PBUILDER_BIN create --debootstrapopts --arch=$a --basetgz 
$PBUILDER_CACHE_PATH/${d}-${a}.tgz --distribution $d --mirror $PBUILDER_MIRROR 
"[EMAIL PROTECTED]"
             done
         done
         echo "I: Init done, please remember to set rebuildd configuration to 
the correct value:"
@@ -48,7 +49,7 @@ cowbuilder_create ()
             for a in $ARCHS
             do
                 echo "I: Initializing cowbuilder for ${d}-${a}"
-                $COWBUILDER_BIN --create --debootstrapopts --arch=$a 
--basepath $PBUILDER_CACHE_PATH/${d}-${a}.cow --distribution $d --mirror 
$PBUILDER_MIRROR
+                $COWBUILDER_BIN --create --debootstrapopts --arch=$a 
--basepath $PBUILDER_CACHE_PATH/${d}-${a}.cow --distribution $d --mirror 
$PBUILDER_MIRROR "[EMAIL PROTECTED]"
             done
         done
 



--- End Message ---
--- Begin Message ---
Source: rebuildd
Source-Version: 0.3.5

We believe that the bug you reported is fixed in the latest version of
rebuildd, which is due to be installed in the Debian FTP archive:

rebuildd_0.3.5.dsc
  to pool/main/r/rebuildd/rebuildd_0.3.5.dsc
rebuildd_0.3.5.tar.gz
  to pool/main/r/rebuildd/rebuildd_0.3.5.tar.gz
rebuildd_0.3.5_all.deb
  to pool/main/r/rebuildd/rebuildd_0.3.5_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Danjou <[EMAIL PROTECTED]> (supplier of updated rebuildd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 31 Aug 2008 20:51:29 +0200
Source: rebuildd
Binary: rebuildd
Architecture: source all
Version: 0.3.5
Distribution: unstable
Urgency: low
Maintainer: Julien Danjou <[EMAIL PROTECTED]>
Changed-By: Julien Danjou <[EMAIL PROTECTED]>
Description: 
 rebuildd   - build daemon aiming at rebuilding Debian packages
Closes: 486146 497275 497295
Changes: 
 rebuildd (0.3.5) unstable; urgency=low
 .
   * Bump standard version
   * Fix arch usage in httpd (Closes: #486146)
   * Fix typo in rebuildd.default (Closes: #497275)
   * Support passing other pbuilder options to rebuildd-init-build-system
     (Closes: #497295)
Checksums-Sha1: 
 0895a067dc41c5b02f06bbe9b40e41e41482ef61 787 rebuildd_0.3.5.dsc
 6080b2626afe6edbe7ca13a9841dc0dcdcfcd68f 22652 rebuildd_0.3.5.tar.gz
 25a9fbc6d9a65fdd4f2c4cfd1c59b936d8aee7e9 24510 rebuildd_0.3.5_all.deb
Checksums-Sha256: 
 ba47875394b98f24c2c7513099556404c2c6b0c8d5394184e4ea364921c94bac 787 
rebuildd_0.3.5.dsc
 adb9f52c9c689e485c673241adac9c1487746e136e8e42b2668637e46f19082b 22652 
rebuildd_0.3.5.tar.gz
 bf0ae306b590ea1eb63334ac0aa3a1e68f7e8252786f8ee356df1c172a687d56 24510 
rebuildd_0.3.5_all.deb
Files: 
 f589eca87391f4fefaa5c724199dd9d7 787 devel extra rebuildd_0.3.5.dsc
 fc15358d9f0fd1d126d2dbb89e0dc337 22652 devel extra rebuildd_0.3.5.tar.gz
 94527cf9a912e53dfbfa17caa10a59d2 24510 devel extra rebuildd_0.3.5_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkjKkaAACgkQpGK1HsL+5c1UvgCfSbrpUdy+6+ap+Z+spIH5HKzJ
n+wAoLGnGCEnh0FpyAJ4Fc4HVVd/aKtC
=W8pR
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to