Your message dated Fri, 26 Sep 2008 21:47:07 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#500264: fixed in cpio 2.9-14
has caused the Debian Bug report #500264,
regarding cpio: --owner doesn't accept user or group names
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
500264: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=500264
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: cpio
Version: 2.9-13
Severity: important
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu intrepid ubuntu-patch
Hi,
In the unstable/testing version of cpio --owner doesn't accept user or
group names.
# cpio --owner root
cpio: root: invalid user
This bug was reported in Ubuntu at
https://bugs.launchpad.net/bugs/273259/
and the reporter, Jason Wessel, noted that the reason for this was that
the package compiles in a dummy version of getpwnam, as HAVE_GETPWNAM
is not defined during the build.
I found other instances where dummy functions would be used due
to mismatches between the code and the build system. The attached
patch is my proposed way of fixing this in the minimal way possible
for all the occurrences I could find.
I believe this is fixed in experimental, as upstream has changed
this area of the code, but it may be worth double checking that.
I would appreciate any suggested improvements for the patch,
and also checking that I did not miss any definitions that should be
added.
Thanks,
James
diff -u cpio-2.9/configure cpio-2.9/configure
--- cpio-2.9/configure
+++ cpio-2.9/configure
@@ -7585,7 +7585,7 @@
-for ac_func in fchmod fchown chown link symlink getuid geteuid setuid getgid setgid mknod pipe
+for ac_func in fchmod fchown chown link symlink getpwnam getgrnam getpwuid getgrgid getuid geteuid setuid getgid setgid mknod pipe fork
do
as_ac_var=`echo "ac_cv_func_$ac_func" | $as_tr_sh`
{ echo "$as_me:$LINENO: checking for $ac_func" >&5
diff -u cpio-2.9/lib/system.c cpio-2.9/lib/system.c
--- cpio-2.9/lib/system.c
+++ cpio-2.9/lib/system.c
@@ -23,7 +23,7 @@
#include <unistd.h>
#include <errno.h>
-#ifndef HAVE_PWUID
+#ifndef HAVE_GETPWUID
struct passwd *
getpwuid (uid_t uid __attribute__ ((unused)))
{
diff -u cpio-2.9/configure.ac cpio-2.9/configure.ac
--- cpio-2.9/configure.ac
+++ cpio-2.9/configure.ac
@@ -47,7 +47,7 @@
AC_HEADER_STDC
AC_HEADER_DIRENT
-AC_CHECK_FUNCS([fchmod fchown chown link symlink getuid geteuid setuid getgid setgid mknod pipe])
+AC_CHECK_FUNCS([fchmod fchown chown link symlink getpwnam getgrnam getpwuid getgrgid getuid geteuid setuid getgid setgid mknod pipe fork])
# gnulib modules
gl_INIT
diff -u cpio-2.9/config.h.in cpio-2.9/config.h.in
--- cpio-2.9/config.h.in
+++ cpio-2.9/config.h.in
@@ -334,6 +334,9 @@
/* Define to 1 if you have the `flockfile' function. */
#undef HAVE_FLOCKFILE
+/* Define to 1 if you have the `fork' function. */
+#undef HAVE_FORK
+
/* Define to 1 if you have the `funlockfile' function. */
#undef HAVE_FUNLOCKFILE
@@ -352,6 +355,12 @@
/* Define to 1 if you have the `getgid' function. */
#undef HAVE_GETGID
+/* Define to 1 if you have the `getgrgid' function. */
+#undef HAVE_GETGRGID
+
+/* Define to 1 if you have the `getgrnam' function. */
+#undef HAVE_GETGRNAM
+
/* Define to 1 if you have the <getopt.h> header file. */
#undef HAVE_GETOPT_H
@@ -361,6 +370,12 @@
/* Define to 1 if you have the `getpagesize' function. */
#undef HAVE_GETPAGESIZE
+/* Define to 1 if you have the `getpwnam' function. */
+#undef HAVE_GETPWNAM
+
+/* Define to 1 if you have the `getpwuid' function. */
+#undef HAVE_GETPWUID
+
/* Define if the GNU gettext() function is already present or preinstalled. */
#undef HAVE_GETTEXT
diff -u cpio-2.9/debian/changelog cpio-2.9/debian/changelog
--- cpio-2.9/debian/changelog
+++ cpio-2.9/debian/changelog
@@ -1,3 +1,13 @@
+cpio (2.9-14) unstable; urgency=low
+
+ * Make sure that HAVE_GETPWNAM, HAVE_GETGRNAM, HAVE_GETPWUID and
+ HAVE_GETGRGID are defined so that the real functions are used, rather
+ than dummy ones. Having HAVE_GETPWNAM defined makes --owner work with
+ user and group names again.
+ - Also switch lib/system.h to use HAVE_GETPWUID instead of HAVE_PWUID.
+
+ -- James Westby <[EMAIL PROTECTED]> Fri, 26 Sep 2008 18:22:01 +0100
+
cpio (2.9-13) unstable; urgency=low
* Remove pre-sarge fixup from postinst, and remove preinst entirely.
--- End Message ---
--- Begin Message ---
Source: cpio
Source-Version: 2.9-14
We believe that the bug you reported is fixed in the latest version of
cpio, which is due to be installed in the Debian FTP archive:
cpio-win32_2.9-14_all.deb
to pool/main/c/cpio/cpio-win32_2.9-14_all.deb
cpio_2.9-14.diff.gz
to pool/main/c/cpio/cpio_2.9-14.diff.gz
cpio_2.9-14.dsc
to pool/main/c/cpio/cpio_2.9-14.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Clint Adams <[EMAIL PROTECTED]> (supplier of updated cpio package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 26 Sep 2008 16:58:29 -0400
Source: cpio
Binary: cpio cpio-win32
Architecture: source all
Version: 2.9-14
Distribution: unstable
Urgency: low
Maintainer: Clint Adams <[EMAIL PROTECTED]>
Changed-By: Clint Adams <[EMAIL PROTECTED]>
Description:
cpio - GNU cpio -- a program to manage archives of files
cpio-win32 - GNU cpio -- a program to manage archives of files (win32 build)
Closes: 500264
Changes:
cpio (2.9-14) unstable; urgency=low
.
[ James Westby ]
* Make sure that HAVE_GETPWNAM, HAVE_GETGRNAM, HAVE_GETPWUID and
HAVE_GETGRGID are defined so that the real functions are used, rather
than dummy ones. Having HAVE_GETPWNAM defined makes --owner work with
user and group names again.
- Also switch lib/system.h to use HAVE_GETPWUID instead of HAVE_PWUID.
closes: #500264.
.
[ Clint Adams ]
* Bump to Standards-Version 3.8.0.
Checksums-Sha1:
9226c146c7d69c9dbba8e775f4daed231dd5c949 1078 cpio_2.9-14.dsc
b7a1c2aae1f77081b681b9bea7f292667ea1c32a 107533 cpio_2.9-14.diff.gz
76d79372be7cd7b419f1aa272ba7fc07edce7a51 74126 cpio-win32_2.9-14_all.deb
Checksums-Sha256:
e13bceff92d94cdc1bab8fb0434d7c0f8947d622345d6cf339c2881e1d213902 1078
cpio_2.9-14.dsc
ff0c80366b1acd2f107df16eee46b1254dfc1895ee6f73a5b575a36ed4245038 107533
cpio_2.9-14.diff.gz
5a71d48cd18a653f29ae23870f1279efa8a7552afda98f855f72adc1130f55ab 74126
cpio-win32_2.9-14_all.deb
Files:
295ca47ebc964bb5d7a782f4f4eade35 1078 utils important cpio_2.9-14.dsc
c5d5a2a3ffcbf17bdd4b351e5bef6ced 107533 utils important cpio_2.9-14.diff.gz
f40610e88dd9f8812900e52d4db860a4 74126 utils extra cpio-win32_2.9-14_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Debian!
iD8DBQFI3VRP5m0u66uWM3ARArZ9AJ0ZohG7GJXsLqrKJxh017ZGVW570gCfSoIl
y7pFrZQfg+p4xwAOFNZ0i2c=
=6D8P
-----END PGP SIGNATURE-----
--- End Message ---
