Your message dated Sun, 26 Jun 2005 14:47:22 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#315025: fixed in helpdeco 2.1.2-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 20 Jun 2005 06:18:34 +0000
>From [EMAIL PROTECTED] Sun Jun 19 23:18:34 2005
Return-path: <[EMAIL PROTECTED]>
Received: from d029163.adsl.hansenet.de (localhost.localdomain) [80.171.29.163]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DkFc9-000536-00; Sun, 19 Jun 2005 23:18:33 -0700
Received: from aj by localhost.localdomain with local (Exim 4.50)
id 1DkFc6-0003si-5t; Mon, 20 Jun 2005 08:18:30 +0200
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
From: Andreas Jochens <[EMAIL PROTECTED]>
Subject: helpdeco: FTBFS (amd64/gcc-4.0): invalid lvalue in increment
Message-Id: <[EMAIL PROTECTED]>
Date: Mon, 20 Jun 2005 08:18:30 +0200
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: helpdeco
Version: 2.1.1-2
Severity: normal
Tags: patch
When building 'helpdeco' on amd64/unstable with gcc-4.0,
I get the following error:
helpdeco.c: In function 'DumpTopic':
helpdeco.c:4353: warning: pointer targets in passing argument 1 of
'HexDumpMemory' differ in signedness
helpdeco.c:4427: error: invalid lvalue in increment
helpdeco.c:4447: error: invalid lvalue in increment
helpdeco.c: In function 'main':
helpdeco.c:5809: warning: format '%d' expects type 'int', but argument 3 has
type 'long unsigned int'
make[1]: *** [helpdeco.o] Error 1
make[1]: Leaving directory `/helpdeco-2.1.1'
make: *** [build] Error 2
With the attached patch 'helpdeco' can be compiled
on amd64 using gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/helpdeco-2.1.1/helpdec1.c ./helpdec1.c
--- ../tmp-orig/helpdeco-2.1.1/helpdec1.c 2005-05-19 14:11:36.000000000
+0200
+++ ./helpdec1.c 2005-06-20 08:12:49.000000000 +0200
@@ -612,20 +612,41 @@
/* scan-functions for reading compressed values from LinkData1 */
short scanint(char **ptr) /* scan a compressed short */
{
- if(*(*ptr)&1) return (*(((unsigned short *)(*ptr))++)>>1)-0x4000;
- return (*(((unsigned char *)(*ptr))++)>>1)-0x40;
+ short ret;
+ if(*(*ptr)&1) {
+ ret = (*(((unsigned short *)(*ptr)))>>1)-0x4000;
+ ptr=((unsigned short *)*ptr)+1;
+ } else {
+ ret = (*(((unsigned char *)(*ptr)))>>1)-0x40;
+ ptr=((unsigned char *)*ptr)+1;
+ }
+ return ret;
}
unsigned short scanword(char **ptr) /* scan a compressed unsiged short */
{
- if(*(*ptr)&1) return *(((unsigned short *)(*ptr))++)>>1;
- return *(((unsigned char *)(*ptr))++)>>1;
+ short ret;
+ if(*(*ptr)&1) {
+ ret = (*(((unsigned short *)(*ptr)))>>1);
+ ptr=((unsigned short *)*ptr)+1;
+ } else {
+ ret = (*(((unsigned char *)(*ptr)))>>1);
+ ptr=((unsigned char *)*ptr)+1;
+ }
+ return ret;
}
long scanlong(char **ptr) /* scan a compressed long */
{
- if(*(*ptr)&1) return (*(((unsigned long *)(*ptr))++)>>1)-0x40000000L;
- return (*(((unsigned short *)(*ptr))++)>>1)-0x4000;
+ long ret;
+ if(*(*ptr)&1) {
+ ret = (*(((unsigned long *)(*ptr)))>>1)-0x40000000L;
+ ptr=((unsigned long *)*ptr)+1;
+ } else {
+ ret = (*(((unsigned short *)(*ptr)))>>1)-0x4000;
+ ptr=((unsigned short *)*ptr)+1;
+ }
+ return ret;
}
/* locates internal file FileName or internal directory if FileName is NULL
diff -urN ../tmp-orig/helpdeco-2.1.1/helpdeco.c ./helpdeco.c
--- ../tmp-orig/helpdeco-2.1.1/helpdeco.c 2005-05-19 14:11:38.000000000
+0200
+++ ./helpdeco.c 2005-06-20 08:02:44.000000000 +0200
@@ -4424,7 +4424,8 @@
}
printf("%02x %d id=%04x ",*(unsigned char *)ptr,*(unsigned char
*)(ptr+1)-0x80,*(unsigned short *)(ptr+2));
ptr+=4;
- x2=*((unsigned short *)ptr)++;
+ x2=*((unsigned short *)ptr);
+ ptr=((unsigned short *)ptr)+1;
if(x2&0x0001) printf("unknownbit01=%ld ",scanlong(&ptr)); /*
found in MVBs, purpose unknown, may mean that x2 is compressed long */
if(x2&0x0002) printf("topspacing=%d ",scanint(&ptr));
if(x2&0x0004) printf("bottomspacing=%d ",scanint(&ptr));
@@ -4444,7 +4445,8 @@
if(x1&0x20) fputs("thickborder ",stdout);
if(x1&0x40) fputs("doubleborder ",stdout);
if(x1&0x80) fputs("unknownborder",stdout);
- printf("%04x ",*((unsigned short *)ptr)++);
+ printf("%04x ",*((unsigned short *)ptr));
+ ptr=(unsigned short*)ptr+1;
}
if(x2&0x0200)
{
---------------------------------------
Received: (at 315025-close) by bugs.debian.org; 26 Jun 2005 18:51:56 +0000
>From [EMAIL PROTECTED] Sun Jun 26 11:51:56 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DmcEV-0000PH-00; Sun, 26 Jun 2005 11:51:56 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DmcA6-0001Fc-00; Sun, 26 Jun 2005 14:47:22 -0400
From: Paul Wise <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#315025: fixed in helpdeco 2.1.2-1
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sun, 26 Jun 2005 14:47:22 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: helpdeco
Source-Version: 2.1.2-1
We believe that the bug you reported is fixed in the latest version of
helpdeco, which is due to be installed in the Debian FTP archive:
helpdeco_2.1.2-1.diff.gz
to pool/main/h/helpdeco/helpdeco_2.1.2-1.diff.gz
helpdeco_2.1.2-1.dsc
to pool/main/h/helpdeco/helpdeco_2.1.2-1.dsc
helpdeco_2.1.2-1_i386.deb
to pool/main/h/helpdeco/helpdeco_2.1.2-1_i386.deb
helpdeco_2.1.2.orig.tar.gz
to pool/main/h/helpdeco/helpdeco_2.1.2.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Paul Wise <[EMAIL PROTECTED]> (supplier of updated helpdeco package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 23 Jun 2005 12:05:19 +0800
Source: helpdeco
Binary: helpdeco
Architecture: source i386
Version: 2.1.2-1
Distribution: unstable
Urgency: low
Maintainer: Paul Wise <[EMAIL PROTECTED]>
Changed-By: Paul Wise <[EMAIL PROTECTED]>
Description:
helpdeco - decompiler for windows help (WinHelp) files
Closes: 315025
Changes:
helpdeco (2.1.2-1) unstable; urgency=low
.
* New upstream release - fixes gcc4 FTBFS (Closes: #315025)
Files:
f450b6daf820c0113352097523df554e 573 utils optional helpdeco_2.1.2-1.dsc
932ee704b2d937d4a93da4adc36f2f20 80079 utils optional
helpdeco_2.1.2.orig.tar.gz
a7a26063c967ffe1533030331ee1fa59 3617 utils optional helpdeco_2.1.2-1.diff.gz
18d1dfb460c9cce6b4c90b3189698074 87118 utils optional helpdeco_2.1.2-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCvvUi9n4qXRzy1ioRAsjAAJ9k5QmuXucyV5l6z22KJ8PYCATSjgCePQo3
Ga6yChcWv7HRpukNFl1VCEk=
=t+jT
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
