Your message dated Thu, 30 Jun 2005 18:47:46 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#315757: fixed in hal 0.4.8-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 25 Jun 2005 16:09:57 +0000
>From [EMAIL PROTECTED] Sat Jun 25 09:09:57 2005
Return-path: <[EMAIL PROTECTED]>
Received: from jim.skynet.lt [212.122.68.65] 
        by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
        id 1DmDEC-0000d5-00; Sat, 25 Jun 2005 09:09:56 -0700
Received: (qmail 73615 invoked from network); 25 Jun 2005 16:09:24 -0000
Received: from unknown (HELO MDXDebian.ozas.sytes.net) (212.122.71.78)
  by jim.skynet.lt with SMTP; 25 Jun 2005 16:09:24 -0000
Received: from modax by MDXDebian.ozas.sytes.net with local (Exim 4.51)
        id 1DmDDd-0006Yd-BN; Sat, 25 Jun 2005 19:09:21 +0300
Content-Type: multipart/mixed; boundary="===============4961695709952938564=="
MIME-Version: 1.0
From: Modestas Vainius <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: libhal-storage0: libhal-storage.c:hal_volume_from_udi():vol->disk_type 
is
 not set correctly for DVD+R and DVD+RW disks (typos)
X-Mailer: reportbug 3.15
Date: Sat, 25 Jun 2005 19:09:21 +0300
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

This is a multi-part MIME message sent by reportbug.

--===============4961695709952938564==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: libhal-storage0
Version: 0.4.8-2
Severity: important
Tags: patch

hal-spec claims, that:

volume.disc.type (string)     Yes  This property specifies the physical type of 
the disc
...
     dvd_plus_r     DVD+R disc
     dvd_plus_rw     DVD+RW disc
...

However, in libhal-storage.c:hal_volume_from_udi() we have
(as of 0.4.8-2):

  } else if (strcmp (disc_type_textual, "dvd_plusr") == 0) {
        vol->disc_type = HAL_VOLUME_DISC_TYPE_DVDPLUSR;
  } else if (strcmp (disc_type_textual, "dvd_plusrw") == 0) {
         vol->disc_type = HAL_VOLUME_DISC_TYPE_DVDPLUSRW;
  }

As you see, there are two typos (dvd_plusr - should be dvd_plus_r,
and dvd_plusrw - should be dvd_plus_rw), which prevent a disk type
to be set for DVD+R and DVD+RW disks. As a result, KDE 3.4 media
manager misrecognize those disks, claiming they are CD-ROMs.

The attached patch fixes the typos. It should be put in debian/patches.
The patched hal compiles without any problems with pbuilder and KDE 3.4
media manager behaves as expected after installing it. Please include it
in the next hal revision, because the nature of the bug may trick the people
heavily relying on the info provided by Hal/KDE/Gnome into thinking that
their DVD drive is faulty (yes, I had this thought!). I'm not sure
whether the bug is worth fixing in sarge. It's very trivial and just can't
break anything.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-mdx
Locale: LANG=lt_LT, LC_CTYPE=lt_LT (charmap=ISO-8859-13)

Versions of packages libhal-storage0 depends on:
ii  dbus-1                      0.23.4-3     simple interprocess messaging syst
ii  libc6                       2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libhal0                     0.4.8-2mdx1  Hardware Abstraction Layer - share
ii  libpopt0                    1.7-5        lib for parsing cmdline parameters

libhal-storage0 recommends no packages.

-- no debconf information

--===============4961695709952938564==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="dvd_plus_r_rw_typo.diff"

diff -uNr hal-0.4.8.old/libhal-storage/libhal-storage.c 
hal-0.4.8/libhal-storage/libhal-storage.c
--- hal-0.4.8.old/libhal-storage/libhal-storage.c       2005-06-25 
18:26:30.000000000 +0300
+++ hal-0.4.8/libhal-storage/libhal-storage.c   2005-06-25 18:27:41.000000000 
+0300
@@ -1028,9 +1028,9 @@
                        vol->disc_type = HAL_VOLUME_DISC_TYPE_DVDR;
                } else if (strcmp (disc_type_textual, "dvd_rw") == 0) {
                        vol->disc_type = HAL_VOLUME_DISC_TYPE_DVDRW;
-               } else if (strcmp (disc_type_textual, "dvd_plusr") == 0) {
+               } else if (strcmp (disc_type_textual, "dvd_plus_r") == 0) {
                        vol->disc_type = HAL_VOLUME_DISC_TYPE_DVDPLUSR;
-               } else if (strcmp (disc_type_textual, "dvd_plusrw") == 0) {
+               } else if (strcmp (disc_type_textual, "dvd_plus_rw") == 0) {
                        vol->disc_type = HAL_VOLUME_DISC_TYPE_DVDPLUSRW;
                }
        }

--===============4961695709952938564==--

---------------------------------------
Received: (at 315757-close) by bugs.debian.org; 30 Jun 2005 22:53:06 +0000
>From [EMAIL PROTECTED] Thu Jun 30 15:53:06 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1Do7u6-0007F7-00; Thu, 30 Jun 2005 15:53:06 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
        id 1Do7ow-0008NG-00; Thu, 30 Jun 2005 18:47:46 -0400
From: Sjoerd Simons <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#315757: fixed in hal 0.4.8-3
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Thu, 30 Jun 2005 18:47:46 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: hal
Source-Version: 0.4.8-3

We believe that the bug you reported is fixed in the latest version of
hal, which is due to be installed in the Debian FTP archive:

hal-device-manager_0.4.8-3_all.deb
  to pool/main/h/hal/hal-device-manager_0.4.8-3_all.deb
hal-doc_0.4.8-3_all.deb
  to pool/main/h/hal/hal-doc_0.4.8-3_all.deb
hal_0.4.8-3.diff.gz
  to pool/main/h/hal/hal_0.4.8-3.diff.gz
hal_0.4.8-3.dsc
  to pool/main/h/hal/hal_0.4.8-3.dsc
hal_0.4.8-3_powerpc.deb
  to pool/main/h/hal/hal_0.4.8-3_powerpc.deb
libhal-dev_0.4.8-3_powerpc.deb
  to pool/main/h/hal/libhal-dev_0.4.8-3_powerpc.deb
libhal-storage-dev_0.4.8-3_powerpc.deb
  to pool/main/h/hal/libhal-storage-dev_0.4.8-3_powerpc.deb
libhal-storage0_0.4.8-3_powerpc.deb
  to pool/main/h/hal/libhal-storage0_0.4.8-3_powerpc.deb
libhal0_0.4.8-3_powerpc.deb
  to pool/main/h/hal/libhal0_0.4.8-3_powerpc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sjoerd Simons <[EMAIL PROTECTED]> (supplier of updated hal package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 30 Jun 2005 23:32:30 +0200
Source: hal
Binary: libhal-dev hal-doc libhal-storage-dev libhal-storage0 libhal0 hal 
hal-device-manager
Architecture: source powerpc all
Version: 0.4.8-3
Distribution: unstable
Urgency: low
Maintainer: Sjoerd Simons <[EMAIL PROTECTED]>
Changed-By: Sjoerd Simons <[EMAIL PROTECTED]>
Description: 
 hal        - Hardware Abstraction Layer
 hal-device-manager - Hardware Abstraction Layer user interface
 hal-doc    - Hardware Abstraction Layer
 libhal-dev - Hardware Abstraction Layer - development files
 libhal-storage-dev - Hardware Abstraction Layer - development files
 libhal-storage0 - Hardware Abstraction Layer - shared library for storage 
devices
 libhal0    - Hardware Abstraction Layer - shared library
Closes: 315757
Changes: 
 hal (0.4.8-3) unstable; urgency=low
 .
   * debian/patches/dvd_plus_r_rw_typo.diff
     + Fix dvd+r and dvd+rw typo's in libhal-storage0 (Patch by Modestas
     Vainius) (Closes: #315757)
Files: 
 8ff16c121c8c5639a979135c023be187 824 admin optional hal_0.4.8-3.dsc
 d22ae2a586dfa6e0c65db2f7d6ed2123 25843 admin optional hal_0.4.8-3.diff.gz
 9121947116aacb64b3ab1f62c5407562 155348 admin optional 
hal-device-manager_0.4.8-3_all.deb
 5a3efd3d65bfba60033ae995b755ce5e 696294 doc optional hal-doc_0.4.8-3_all.deb
 6d1fac9846f7ee41317893ad5fa79ffa 229278 admin optional hal_0.4.8-3_powerpc.deb
 3512b1f7249f9ed3fab2a334cbd48ba4 91962 libs optional 
libhal0_0.4.8-3_powerpc.deb
 f79d0977ffe6c23415c86156ef07610f 93054 libs optional 
libhal-storage0_0.4.8-3_powerpc.deb
 3482d4314bf97f525e0fcd547cd080c0 95196 libdevel optional 
libhal-dev_0.4.8-3_powerpc.deb
 3b2860236829e9b34356cbb7daab604c 93816 libdevel optional 
libhal-storage-dev_0.4.8-3_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCxHSwgTd+SodosdIRArRSAJ9UYg3CZxBwQiVZo7W8UJn8u5S5/QCfb5XZ
WSxBdfeA3YvuByHOBHanhBo=
=ZuNK
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to